canvas: Fully stateless backend (#38214)

I think this simplifies canvas backends greatly. Before there were many
(needless) hoops from abstract to concrete (backend) and back, now we
can do most stuff on abstract types.

Testing: Existing WPT tests
Fixes: #38022 

try run: https://github.com/sagudev/servo/actions/runs/16450978211

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
sagudev 2025-07-24 20:11:29 +02:00 committed by GitHub
parent 86d8317460
commit d39e701b46
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 650 additions and 806 deletions

View file

@ -3,55 +3,26 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use canvas_traits::canvas::{ use canvas_traits::canvas::{
CompositionOrBlending, FillOrStrokeStyle, LineCapStyle, LineJoinStyle, Path, CompositionOptions, FillOrStrokeStyle, LineOptions, Path, ShadowOptions,
}; };
use compositing_traits::SerializableImageData; use compositing_traits::SerializableImageData;
use euclid::default::{Point2D, Rect, Size2D, Transform2D, Vector2D}; use euclid::default::{Point2D, Rect, Size2D, Transform2D};
use pixels::Snapshot; use pixels::Snapshot;
use style::color::AbsoluteColor;
use webrender_api::ImageDescriptor; use webrender_api::ImageDescriptor;
use crate::canvas_data::{CanvasPaintState, Filter, TextRun}; use crate::canvas_data::{Filter, TextRun};
pub(crate) trait Backend: Clone + Sized { pub(crate) trait Backend: Clone + Sized {
type Pattern<'a>: PatternHelpers + Clone;
type StrokeOptions: StrokeOptionsHelpers + Clone;
type Color: Clone;
type DrawOptions: DrawOptionsHelpers + Clone;
type CompositionOp;
type DrawTarget: GenericDrawTarget<Self>; type DrawTarget: GenericDrawTarget<Self>;
type SourceSurface; type SourceSurface;
type GradientStop;
type GradientStops;
fn get_composition_op(&self, opts: &Self::DrawOptions) -> Self::CompositionOp;
fn need_to_draw_shadow(&self, color: &Self::Color) -> bool;
fn set_shadow_color(&mut self, color: AbsoluteColor, state: &mut CanvasPaintState<'_, Self>);
fn set_fill_style(
&mut self,
style: FillOrStrokeStyle,
state: &mut CanvasPaintState<'_, Self>,
drawtarget: &Self::DrawTarget,
);
fn set_stroke_style(
&mut self,
style: FillOrStrokeStyle,
state: &mut CanvasPaintState<'_, Self>,
drawtarget: &Self::DrawTarget,
);
fn set_global_composition(
&mut self,
op: CompositionOrBlending,
state: &mut CanvasPaintState<'_, Self>,
);
fn create_drawtarget(&self, size: Size2D<u64>) -> Self::DrawTarget; fn create_drawtarget(&self, size: Size2D<u64>) -> Self::DrawTarget;
fn new_paint_state<'a>(&self) -> CanvasPaintState<'a, Self>;
} }
// This defines required methods for a DrawTarget (currently only implemented for raqote). The // This defines required methods for a DrawTarget (currently only implemented for raqote). The
// prototypes are derived from the now-removed Azure backend's methods. // prototypes are derived from the now-removed Azure backend's methods.
pub(crate) trait GenericDrawTarget<B: Backend> { pub(crate) trait GenericDrawTarget<B: Backend> {
fn clear_rect(&mut self, rect: &Rect<f32>); fn clear_rect(&mut self, rect: &Rect<f32>, transform: Transform2D<f32>);
fn copy_surface( fn copy_surface(
&mut self, &mut self,
surface: B::SourceSurface, surface: B::SourceSurface,
@ -66,72 +37,59 @@ pub(crate) trait GenericDrawTarget<B: Backend> {
dest: Rect<f64>, dest: Rect<f64>,
source: Rect<f64>, source: Rect<f64>,
filter: Filter, filter: Filter,
draw_options: &B::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
); );
fn draw_surface_with_shadow( fn draw_surface_with_shadow(
&self, &self,
surface: B::SourceSurface, surface: B::SourceSurface,
dest: &Point2D<f32>, dest: &Point2D<f32>,
color: &B::Color, shadow_options: ShadowOptions,
offset: &Vector2D<f32>, composition_options: CompositionOptions,
sigma: f32, );
operator: B::CompositionOp, fn fill(
&mut self,
path: &Path,
style: FillOrStrokeStyle,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
); );
fn fill(&mut self, path: &Path, pattern: &B::Pattern<'_>, draw_options: &B::DrawOptions);
fn fill_text( fn fill_text(
&mut self, &mut self,
text_runs: Vec<TextRun>, text_runs: Vec<TextRun>,
start: Point2D<f32>, start: Point2D<f32>,
pattern: &B::Pattern<'_>, style: FillOrStrokeStyle,
draw_options: &B::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
); );
fn fill_rect( fn fill_rect(
&mut self, &mut self,
rect: &Rect<f32>, rect: &Rect<f32>,
pattern: &B::Pattern<'_>, style: FillOrStrokeStyle,
draw_options: &B::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
); );
fn get_size(&self) -> Size2D<i32>; fn get_size(&self) -> Size2D<i32>;
fn get_transform(&self) -> Transform2D<f32>;
fn pop_clip(&mut self); fn pop_clip(&mut self);
fn push_clip(&mut self, path: &Path); fn push_clip(&mut self, path: &Path, transform: Transform2D<f32>);
fn push_clip_rect(&mut self, rect: &Rect<i32>); fn push_clip_rect(&mut self, rect: &Rect<i32>);
fn set_transform(&mut self, matrix: &Transform2D<f32>);
fn stroke( fn stroke(
&mut self, &mut self,
path: &Path, path: &Path,
pattern: &B::Pattern<'_>, style: FillOrStrokeStyle,
stroke_options: &B::StrokeOptions, line_options: LineOptions,
draw_options: &B::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
); );
fn stroke_rect( fn stroke_rect(
&mut self, &mut self,
rect: &Rect<f32>, rect: &Rect<f32>,
pattern: &B::Pattern<'_>, style: FillOrStrokeStyle,
stroke_options: &B::StrokeOptions, line_options: LineOptions,
draw_options: &B::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
); );
fn surface(&self) -> B::SourceSurface; fn surface(&self) -> B::SourceSurface;
fn image_descriptor_and_serializable_data(&self) -> (ImageDescriptor, SerializableImageData); fn image_descriptor_and_serializable_data(&self) -> (ImageDescriptor, SerializableImageData);
fn snapshot(&self) -> Snapshot; fn snapshot(&self) -> Snapshot;
} }
pub(crate) trait PatternHelpers {
fn is_zero_size_gradient(&self) -> bool;
fn x_bound(&self) -> Option<u32>;
fn y_bound(&self) -> Option<u32>;
}
pub(crate) trait StrokeOptionsHelpers {
fn set_line_width(&mut self, _val: f32);
fn set_miter_limit(&mut self, _val: f32);
fn set_line_join(&mut self, val: LineJoinStyle);
fn set_line_cap(&mut self, val: LineCapStyle);
fn set_line_dash(&mut self, items: Vec<f32>);
fn set_line_dash_offset(&mut self, offset: f32);
}
pub(crate) trait DrawOptionsHelpers {
fn set_alpha(&mut self, val: f32);
fn is_clear(&self) -> bool;
}

View file

@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this * License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use std::marker::PhantomData;
use std::mem; use std::mem;
use std::sync::Arc; use std::sync::Arc;
@ -18,16 +17,10 @@ use fonts::{
use log::warn; use log::warn;
use pixels::Snapshot; use pixels::Snapshot;
use range::Range; use range::Range;
use servo_arc::Arc as ServoArc;
use style::color::AbsoluteColor;
use style::properties::style_structs::Font as FontStyleStruct;
use unicode_script::Script; use unicode_script::Script;
use webrender_api::ImageKey; use webrender_api::ImageKey;
use crate::backend::{ use crate::backend::{Backend, GenericDrawTarget as _};
Backend, DrawOptionsHelpers as _, GenericDrawTarget as _, PatternHelpers,
StrokeOptionsHelpers as _,
};
// Asserts on WR texture cache update for zero sized image with raw data. // Asserts on WR texture cache update for zero sized image with raw data.
// https://github.com/servo/webrender/blob/main/webrender/src/texture_cache.rs#L1475 // https://github.com/servo/webrender/blob/main/webrender/src/texture_cache.rs#L1475
@ -109,33 +102,29 @@ pub(crate) enum Filter {
Nearest, Nearest,
} }
pub(crate) struct CanvasData<'a, B: Backend> { pub(crate) struct CanvasData<B: Backend> {
backend: B, backend: B,
drawtarget: B::DrawTarget, drawtarget: B::DrawTarget,
state: CanvasPaintState<'a, B>,
saved_states: Vec<CanvasPaintState<'a, B>>,
compositor_api: CrossProcessCompositorApi, compositor_api: CrossProcessCompositorApi,
image_key: ImageKey, image_key: ImageKey,
font_context: Arc<FontContext>, font_context: Arc<FontContext>,
} }
impl<'a, B: Backend> CanvasData<'a, B> { impl<B: Backend> CanvasData<B> {
pub(crate) fn new( pub(crate) fn new(
size: Size2D<u64>, size: Size2D<u64>,
compositor_api: CrossProcessCompositorApi, compositor_api: CrossProcessCompositorApi,
font_context: Arc<FontContext>, font_context: Arc<FontContext>,
backend: B, backend: B,
) -> CanvasData<'a, B> { ) -> CanvasData<B> {
let size = size.max(MIN_WR_IMAGE_SIZE); let size = size.max(MIN_WR_IMAGE_SIZE);
let draw_target = backend.create_drawtarget(size); let draw_target = backend.create_drawtarget(size);
let image_key = compositor_api.generate_image_key_blocking().unwrap(); let image_key = compositor_api.generate_image_key_blocking().unwrap();
let (descriptor, data) = draw_target.image_descriptor_and_serializable_data(); let (descriptor, data) = draw_target.image_descriptor_and_serializable_data();
compositor_api.add_image(image_key, descriptor, data); compositor_api.add_image(image_key, descriptor, data);
CanvasData { CanvasData {
state: backend.new_paint_state(),
backend, backend,
drawtarget: draw_target, drawtarget: draw_target,
saved_states: vec![],
compositor_api, compositor_api,
image_key, image_key,
font_context, font_context,
@ -146,12 +135,16 @@ impl<'a, B: Backend> CanvasData<'a, B> {
self.image_key self.image_key
} }
#[allow(clippy::too_many_arguments)]
pub(crate) fn draw_image( pub(crate) fn draw_image(
&mut self, &mut self,
snapshot: Snapshot, snapshot: Snapshot,
dest_rect: Rect<f64>, dest_rect: Rect<f64>,
source_rect: Rect<f64>, source_rect: Rect<f64>,
smoothing_enabled: bool, smoothing_enabled: bool,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
// We round up the floating pixel values to draw the pixels // We round up the floating pixel values to draw the pixels
let source_rect = source_rect.ceil(); let source_rect = source_rect.ceil();
@ -162,42 +155,37 @@ impl<'a, B: Backend> CanvasData<'a, B> {
snapshot snapshot
}; };
let draw_options = self.state.draw_options.clone(); let writer = |draw_target: &mut B::DrawTarget, transform| {
let writer = |draw_target: &mut B::DrawTarget| {
write_image::<B>( write_image::<B>(
draw_target, draw_target,
snapshot, snapshot,
dest_rect, dest_rect,
smoothing_enabled, smoothing_enabled,
&draw_options, composition_options,
transform,
); );
}; };
if self.need_to_draw_shadow() { if shadow_options.need_to_draw_shadow() {
let rect = Rect::new( let rect = Rect::new(
Point2D::new(dest_rect.origin.x as f32, dest_rect.origin.y as f32), Point2D::new(dest_rect.origin.x as f32, dest_rect.origin.y as f32),
Size2D::new(dest_rect.size.width as f32, dest_rect.size.height as f32), Size2D::new(dest_rect.size.width as f32, dest_rect.size.height as f32),
); );
// TODO(pylbrecht) pass another closure for raqote // TODO(pylbrecht) pass another closure for raqote
self.draw_with_shadow(&rect, writer); self.draw_with_shadow(
&rect,
shadow_options,
composition_options,
transform,
writer,
);
} else { } else {
writer(&mut self.drawtarget); writer(&mut self.drawtarget, transform);
}
}
pub(crate) fn save_context_state(&mut self) {
self.saved_states.push(self.state.clone());
}
pub(crate) fn restore_context_state(&mut self) {
if let Some(state) = self.saved_states.pop() {
let _ = mem::replace(&mut self.state, state);
self.drawtarget.set_transform(&self.state.transform);
self.drawtarget.pop_clip();
} }
} }
#[allow(clippy::too_many_arguments)]
pub(crate) fn fill_text_with_size( pub(crate) fn fill_text_with_size(
&mut self, &mut self,
text: String, text: String,
@ -206,13 +194,17 @@ impl<'a, B: Backend> CanvasData<'a, B> {
max_width: Option<f64>, max_width: Option<f64>,
is_rtl: bool, is_rtl: bool,
size: f64, size: f64,
style: FillOrStrokeStyle,
text_options: &TextOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
// > Step 2: Replace all ASCII whitespace in text with U+0020 SPACE characters. // > Step 2: Replace all ASCII whitespace in text with U+0020 SPACE characters.
let text = replace_ascii_whitespace(text); let text = replace_ascii_whitespace(text);
// > Step 3: Let font be the current font of target, as given by that object's font // > Step 3: Let font be the current font of target, as given by that object's font
// > attribute. // > attribute.
let Some(ref font_style) = self.state.font_style else { let Some(ref font_style) = text_options.font else {
return; return;
}; };
@ -250,7 +242,18 @@ impl<'a, B: Backend> CanvasData<'a, B> {
if let Some(max_width) = max_width { if let Some(max_width) = max_width {
let new_size = (max_width / total_advance * size).floor().max(5.); let new_size = (max_width / total_advance * size).floor().max(5.);
if total_advance > max_width && new_size != size { if total_advance > max_width && new_size != size {
self.fill_text_with_size(text, x, y, Some(max_width), is_rtl, new_size); self.fill_text_with_size(
text,
x,
y,
Some(max_width),
is_rtl,
new_size,
style,
text_options,
composition_options,
transform,
);
return; return;
} }
} }
@ -262,6 +265,7 @@ impl<'a, B: Backend> CanvasData<'a, B> {
&first_font.metrics, &first_font.metrics,
total_advance as f32, total_advance as f32,
is_rtl, is_rtl,
text_options,
); );
// > Step 8: Let result be an array constructed by iterating over each glyph in the inline box // > Step 8: Let result be an array constructed by iterating over each glyph in the inline box
@ -269,19 +273,23 @@ impl<'a, B: Backend> CanvasData<'a, B> {
// > as it is in the inline box, positioned on a coordinate space using CSS pixels with its // > as it is in the inline box, positioned on a coordinate space using CSS pixels with its
// > origin is at the anchor point. // > origin is at the anchor point.
self.maybe_bound_shape_with_pattern( self.maybe_bound_shape_with_pattern(
self.state.fill_style.clone(), style,
composition_options,
&Rect::from_size(Size2D::new(total_advance, size)), &Rect::from_size(Size2D::new(total_advance, size)),
|self_| { transform,
|self_, style| {
self_.drawtarget.fill_text( self_.drawtarget.fill_text(
shaped_runs, shaped_runs,
start, start,
&self_.state.fill_style, style,
&self_.state.draw_options, composition_options,
transform,
); );
}, },
); );
} }
#[allow(clippy::too_many_arguments)]
/// <https://html.spec.whatwg.org/multipage/#text-preparation-algorithm> /// <https://html.spec.whatwg.org/multipage/#text-preparation-algorithm>
pub(crate) fn fill_text( pub(crate) fn fill_text(
&mut self, &mut self,
@ -290,21 +298,37 @@ impl<'a, B: Backend> CanvasData<'a, B> {
y: f64, y: f64,
max_width: Option<f64>, max_width: Option<f64>,
is_rtl: bool, is_rtl: bool,
style: FillOrStrokeStyle,
text_options: TextOptions,
_shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
let Some(ref font_style) = self.state.font_style else { let Some(ref font_style) = text_options.font else {
return; return;
}; };
let size = font_style.font_size.computed_size(); let size = font_style.font_size.computed_size();
self.fill_text_with_size(text, x, y, max_width, is_rtl, size.px() as f64); self.fill_text_with_size(
text,
x,
y,
max_width,
is_rtl,
size.px() as f64,
style,
&text_options,
composition_options,
transform,
);
} }
/// <https://html.spec.whatwg.org/multipage/#text-preparation-algorithm> /// <https://html.spec.whatwg.org/multipage/#text-preparation-algorithm>
/// <https://html.spec.whatwg.org/multipage/#dom-context-2d-measuretext> /// <https://html.spec.whatwg.org/multipage/#dom-context-2d-measuretext>
pub(crate) fn measure_text(&mut self, text: String) -> TextMetrics { pub(crate) fn measure_text(&mut self, text: String, text_options: TextOptions) -> TextMetrics {
// > Step 2: Replace all ASCII whitespace in text with U+0020 SPACE characters. // > Step 2: Replace all ASCII whitespace in text with U+0020 SPACE characters.
let text = replace_ascii_whitespace(text); let text = replace_ascii_whitespace(text);
let Some(ref font_style) = self.state.font_style else { let Some(ref font_style) = text_options.font else {
return TextMetrics::default(); return TextMetrics::default();
}; };
@ -349,13 +373,13 @@ impl<'a, B: Backend> CanvasData<'a, B> {
}, },
}; };
let anchor_x = match self.state.text_align { let anchor_x = match text_options.align {
TextAlign::End => total_advance, TextAlign::End => total_advance,
TextAlign::Center => total_advance / 2., TextAlign::Center => total_advance / 2.,
TextAlign::Right => total_advance, TextAlign::Right => total_advance,
_ => 0., _ => 0.,
}; };
let anchor_y = match self.state.text_baseline { let anchor_y = match text_options.baseline {
TextBaseline::Top => ascent, TextBaseline::Top => ascent,
TextBaseline::Hanging => hanging_baseline, TextBaseline::Hanging => hanging_baseline,
TextBaseline::Ideographic => ideographic_baseline, TextBaseline::Ideographic => ideographic_baseline,
@ -425,8 +449,9 @@ impl<'a, B: Backend> CanvasData<'a, B> {
metrics: &FontMetrics, metrics: &FontMetrics,
width: f32, width: f32,
is_rtl: bool, is_rtl: bool,
text_options: &TextOptions,
) -> Point2D<f32> { ) -> Point2D<f32> {
let text_align = match self.state.text_align { let text_align = match text_options.align {
TextAlign::Start if is_rtl => TextAlign::Right, TextAlign::Start if is_rtl => TextAlign::Right,
TextAlign::Start => TextAlign::Left, TextAlign::Start => TextAlign::Left,
TextAlign::End if is_rtl => TextAlign::Left, TextAlign::End if is_rtl => TextAlign::Left,
@ -441,7 +466,7 @@ impl<'a, B: Backend> CanvasData<'a, B> {
let ascent = metrics.ascent.to_f32_px(); let ascent = metrics.ascent.to_f32_px();
let descent = metrics.descent.to_f32_px(); let descent = metrics.descent.to_f32_px();
let anchor_y = match self.state.text_baseline { let anchor_y = match text_options.baseline {
TextBaseline::Top => ascent, TextBaseline::Top => ascent,
TextBaseline::Hanging => ascent * HANGING_BASELINE_DEFAULT, TextBaseline::Hanging => ascent * HANGING_BASELINE_DEFAULT,
TextBaseline::Ideographic => -descent * IDEOGRAPHIC_BASELINE_DEFAULT, TextBaseline::Ideographic => -descent * IDEOGRAPHIC_BASELINE_DEFAULT,
@ -453,152 +478,148 @@ impl<'a, B: Backend> CanvasData<'a, B> {
point2(x + anchor_x, y + anchor_y) point2(x + anchor_x, y + anchor_y)
} }
pub(crate) fn fill_rect(&mut self, rect: &Rect<f32>) { pub(crate) fn fill_rect(
if self.state.fill_style.is_zero_size_gradient() { &mut self,
rect: &Rect<f32>,
style: FillOrStrokeStyle,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
if style.is_zero_size_gradient() {
return; // Paint nothing if gradient size is zero. return; // Paint nothing if gradient size is zero.
} }
if self.need_to_draw_shadow() { if shadow_options.need_to_draw_shadow() {
self.draw_with_shadow(rect, |new_draw_target: &mut B::DrawTarget| { self.draw_with_shadow(
new_draw_target.fill_rect(rect, &self.state.fill_style, &self.state.draw_options); rect,
}); shadow_options,
composition_options,
transform,
|new_draw_target: &mut B::DrawTarget, transform| {
new_draw_target.fill_rect(rect, style, composition_options, transform);
},
);
} else { } else {
self.maybe_bound_shape_with_pattern( self.maybe_bound_shape_with_pattern(
self.state.fill_style.clone(), style,
composition_options,
&rect.cast(), &rect.cast(),
|self_| { transform,
self_.drawtarget.fill_rect( |self_, style| {
rect, self_
&self_.state.fill_style, .drawtarget
&self_.state.draw_options, .fill_rect(rect, style, composition_options, transform);
);
}, },
); );
} }
} }
pub(crate) fn clear_rect(&mut self, rect: &Rect<f32>) { pub(crate) fn clear_rect(&mut self, rect: &Rect<f32>, transform: Transform2D<f32>) {
self.drawtarget.clear_rect(rect); self.drawtarget.clear_rect(rect, transform);
} }
pub(crate) fn stroke_rect(&mut self, rect: &Rect<f32>) { pub(crate) fn stroke_rect(
if self.state.stroke_style.is_zero_size_gradient() { &mut self,
rect: &Rect<f32>,
style: FillOrStrokeStyle,
line_options: LineOptions,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
if style.is_zero_size_gradient() {
return; // Paint nothing if gradient size is zero. return; // Paint nothing if gradient size is zero.
} }
if self.need_to_draw_shadow() { if shadow_options.need_to_draw_shadow() {
self.draw_with_shadow(rect, |new_draw_target: &mut B::DrawTarget| { self.draw_with_shadow(
new_draw_target.stroke_rect( rect,
rect, shadow_options,
&self.state.stroke_style, composition_options,
&self.state.stroke_opts, transform,
&self.state.draw_options, |new_draw_target: &mut B::DrawTarget, transform| {
); new_draw_target.stroke_rect(
}); rect,
style,
line_options,
composition_options,
transform,
);
},
);
} else { } else {
self.maybe_bound_shape_with_pattern( self.maybe_bound_shape_with_pattern(
self.state.stroke_style.clone(), style,
composition_options,
&rect.cast(), &rect.cast(),
|self_| { transform,
|self_, style| {
self_.drawtarget.stroke_rect( self_.drawtarget.stroke_rect(
rect, rect,
&self_.state.stroke_style, style,
&self_.state.stroke_opts, line_options,
&self_.state.draw_options, composition_options,
transform,
); );
}, },
) )
} }
} }
pub(crate) fn fill_path(&mut self, path: &Path) { pub(crate) fn fill_path(
if self.state.fill_style.is_zero_size_gradient() { &mut self,
path: &Path,
style: FillOrStrokeStyle,
_shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
if style.is_zero_size_gradient() {
return; // Paint nothing if gradient size is zero. return; // Paint nothing if gradient size is zero.
} }
self.maybe_bound_shape_with_pattern( self.maybe_bound_shape_with_pattern(
self.state.fill_style.clone(), style,
composition_options,
&path.bounding_box(), &path.bounding_box(),
|self_| { transform,
|self_, style| {
self_ self_
.drawtarget .drawtarget
.fill(path, &self_.state.fill_style, &self_.state.draw_options) .fill(path, style, composition_options, transform)
}, },
) )
} }
pub(crate) fn stroke_path(&mut self, path: &Path) { pub(crate) fn stroke_path(
if self.state.stroke_style.is_zero_size_gradient() { &mut self,
path: &Path,
style: FillOrStrokeStyle,
line_options: LineOptions,
_shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
if style.is_zero_size_gradient() {
return; // Paint nothing if gradient size is zero. return; // Paint nothing if gradient size is zero.
} }
self.maybe_bound_shape_with_pattern( self.maybe_bound_shape_with_pattern(
self.state.stroke_style.clone(), style,
composition_options,
&path.bounding_box(), &path.bounding_box(),
|self_| { transform,
self_.drawtarget.stroke( |self_, style| {
path, self_
&self_.state.stroke_style, .drawtarget
&self_.state.stroke_opts, .stroke(path, style, line_options, composition_options, transform);
&self_.state.draw_options,
);
}, },
) )
} }
pub(crate) fn clip_path(&mut self, path: &Path) { pub(crate) fn clip_path(&mut self, path: &Path, transform: Transform2D<f32>) {
self.drawtarget.push_clip(path); self.drawtarget.push_clip(path, transform);
}
pub(crate) fn set_fill_style(&mut self, style: FillOrStrokeStyle) {
self.backend
.set_fill_style(style, &mut self.state, &self.drawtarget);
}
pub(crate) fn set_stroke_style(&mut self, style: FillOrStrokeStyle) {
self.backend
.set_stroke_style(style, &mut self.state, &self.drawtarget);
}
pub(crate) fn set_line_width(&mut self, width: f32) {
self.state.stroke_opts.set_line_width(width);
}
pub(crate) fn set_line_cap(&mut self, cap: LineCapStyle) {
self.state.stroke_opts.set_line_cap(cap);
}
pub(crate) fn set_line_join(&mut self, join: LineJoinStyle) {
self.state.stroke_opts.set_line_join(join);
}
pub(crate) fn set_miter_limit(&mut self, limit: f32) {
self.state.stroke_opts.set_miter_limit(limit);
}
pub(crate) fn set_line_dash(&mut self, items: Vec<f32>) {
self.state.stroke_opts.set_line_dash(items);
}
pub(crate) fn set_line_dash_offset(&mut self, offset: f32) {
self.state.stroke_opts.set_line_dash_offset(offset);
}
pub(crate) fn get_transform(&self) -> Transform2D<f32> {
self.drawtarget.get_transform()
}
pub(crate) fn set_transform(&mut self, transform: &Transform2D<f32>) {
self.state.transform = *transform;
self.drawtarget.set_transform(transform);
}
pub(crate) fn set_global_alpha(&mut self, alpha: f32) {
self.state.draw_options.set_alpha(alpha);
}
pub(crate) fn set_global_composition(&mut self, op: CompositionOrBlending) {
self.backend.set_global_composition(op, &mut self.state);
} }
/// <https://html.spec.whatwg.org/multipage/#reset-the-rendering-context-to-its-default-state> /// <https://html.spec.whatwg.org/multipage/#reset-the-rendering-context-to-its-default-state>
@ -612,13 +633,6 @@ impl<'a, B: Backend> CanvasData<'a, B> {
.backend .backend
.create_drawtarget(Size2D::new(size.width, size.height)); .create_drawtarget(Size2D::new(size.width, size.height));
// Step 3. Clear the context's drawing state stack.
self.saved_states.clear();
// Step 4. Reset everything that drawing state consists of to their
// initial values.
self.state = self.backend.new_paint_state();
self.update_image_rendering(); self.update_image_rendering();
} }
@ -644,71 +658,35 @@ impl<'a, B: Backend> CanvasData<'a, B> {
); );
} }
pub(crate) fn set_shadow_offset_x(&mut self, value: f64) {
self.state.shadow_offset_x = value;
}
pub(crate) fn set_shadow_offset_y(&mut self, value: f64) {
self.state.shadow_offset_y = value;
}
pub(crate) fn set_shadow_blur(&mut self, value: f64) {
self.state.shadow_blur = value;
}
pub(crate) fn set_shadow_color(&mut self, value: AbsoluteColor) {
self.backend.set_shadow_color(value, &mut self.state);
}
pub(crate) fn set_font(&mut self, font_style: FontStyleStruct) {
self.state.font_style = Some(ServoArc::new(font_style))
}
pub(crate) fn set_text_align(&mut self, text_align: TextAlign) {
self.state.text_align = text_align;
}
pub(crate) fn set_text_baseline(&mut self, text_baseline: TextBaseline) {
self.state.text_baseline = text_baseline;
}
// https://html.spec.whatwg.org/multipage/#when-shadows-are-drawn
fn need_to_draw_shadow(&self) -> bool {
self.backend.need_to_draw_shadow(&self.state.shadow_color) &&
(self.state.shadow_offset_x != 0.0f64 ||
self.state.shadow_offset_y != 0.0f64 ||
self.state.shadow_blur != 0.0f64)
}
fn create_draw_target_for_shadow(&self, source_rect: &Rect<f32>) -> B::DrawTarget { fn create_draw_target_for_shadow(&self, source_rect: &Rect<f32>) -> B::DrawTarget {
let mut draw_target = self.drawtarget.create_similar_draw_target(&Size2D::new( self.drawtarget.create_similar_draw_target(&Size2D::new(
source_rect.size.width as i32, source_rect.size.width as i32,
source_rect.size.height as i32, source_rect.size.height as i32,
)); ))
let matrix = self.state.transform.then(
&Transform2D::identity().pre_translate(-source_rect.origin.to_vector().cast::<f32>()),
);
draw_target.set_transform(&matrix);
draw_target
} }
fn draw_with_shadow<F>(&self, rect: &Rect<f32>, draw_shadow_source: F) fn draw_with_shadow<F>(
where &self,
F: FnOnce(&mut B::DrawTarget), rect: &Rect<f32>,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
draw_shadow_source: F,
) where
F: FnOnce(&mut B::DrawTarget, Transform2D<f32>),
{ {
let shadow_src_rect = self.state.transform.outer_transformed_rect(rect); let shadow_src_rect = transform.outer_transformed_rect(rect);
let mut new_draw_target = self.create_draw_target_for_shadow(&shadow_src_rect); let mut new_draw_target = self.create_draw_target_for_shadow(&shadow_src_rect);
draw_shadow_source(&mut new_draw_target); let shadow_transform = transform.then(
&Transform2D::identity()
.pre_translate(-shadow_src_rect.origin.to_vector().cast::<f32>()),
);
draw_shadow_source(&mut new_draw_target, shadow_transform);
self.drawtarget.draw_surface_with_shadow( self.drawtarget.draw_surface_with_shadow(
new_draw_target.surface(), new_draw_target.surface(),
&Point2D::new(shadow_src_rect.origin.x, shadow_src_rect.origin.y), &Point2D::new(shadow_src_rect.origin.x, shadow_src_rect.origin.y),
&self.state.shadow_color, shadow_options,
&Vector2D::new( composition_options,
self.state.shadow_offset_x as f32,
self.state.shadow_offset_y as f32,
),
(self.state.shadow_blur / 2.0f64) as f32,
self.backend.get_composition_op(&self.state.draw_options),
); );
} }
@ -716,17 +694,23 @@ impl<'a, B: Backend> CanvasData<'a, B> {
/// of the given pattern. /// of the given pattern.
fn maybe_bound_shape_with_pattern<F>( fn maybe_bound_shape_with_pattern<F>(
&mut self, &mut self,
pattern: B::Pattern<'_>, style: FillOrStrokeStyle,
composition_options: CompositionOptions,
path_bound_box: &Rect<f64>, path_bound_box: &Rect<f64>,
transform: Transform2D<f32>,
draw_shape: F, draw_shape: F,
) where ) where
F: FnOnce(&mut Self), F: FnOnce(&mut Self, FillOrStrokeStyle),
{ {
let x_bound = pattern.x_bound(); let x_bound = style.x_bound();
let y_bound = pattern.y_bound(); let y_bound = style.y_bound();
// Clear operations are also unbounded. // Clear operations are also unbounded.
if self.state.draw_options.is_clear() || (x_bound.is_none() && y_bound.is_none()) { if matches!(
draw_shape(self); composition_options.composition_operation,
CompositionOrBlending::Composition(CompositionStyle::Clear)
) || (x_bound.is_none() && y_bound.is_none())
{
draw_shape(self, style);
return; return;
} }
let rect = Rect::from_size(Size2D::new( let rect = Rect::from_size(Size2D::new(
@ -734,9 +718,9 @@ impl<'a, B: Backend> CanvasData<'a, B> {
y_bound.unwrap_or(path_bound_box.size.height.ceil() as u32), y_bound.unwrap_or(path_bound_box.size.height.ceil() as u32),
)) ))
.cast(); .cast();
let rect = self.get_transform().outer_transformed_rect(&rect); let rect = transform.outer_transformed_rect(&rect);
self.drawtarget.push_clip_rect(&rect.cast()); self.drawtarget.push_clip_rect(&rect.cast());
draw_shape(self); draw_shape(self, style);
self.drawtarget.pop_clip(); self.drawtarget.pop_clip();
} }
@ -765,9 +749,13 @@ impl<'a, B: Backend> CanvasData<'a, B> {
self.drawtarget.snapshot() self.drawtarget.snapshot()
} }
} }
pub(crate) fn pop_clip(&mut self) {
self.drawtarget.pop_clip();
}
} }
impl<B: Backend> Drop for CanvasData<'_, B> { impl<B: Backend> Drop for CanvasData<B> {
fn drop(&mut self) { fn drop(&mut self) {
self.compositor_api.delete_image(self.image_key); self.compositor_api.delete_image(self.image_key);
} }
@ -776,24 +764,6 @@ impl<B: Backend> Drop for CanvasData<'_, B> {
const HANGING_BASELINE_DEFAULT: f32 = 0.8; const HANGING_BASELINE_DEFAULT: f32 = 0.8;
const IDEOGRAPHIC_BASELINE_DEFAULT: f32 = 0.5; const IDEOGRAPHIC_BASELINE_DEFAULT: f32 = 0.5;
#[derive(Clone)]
pub(crate) struct CanvasPaintState<'a, B: Backend> {
pub(crate) draw_options: B::DrawOptions,
pub(crate) fill_style: B::Pattern<'a>,
pub(crate) stroke_style: B::Pattern<'a>,
pub(crate) stroke_opts: B::StrokeOptions,
/// The current 2D transform matrix.
pub(crate) transform: Transform2D<f32>,
pub(crate) shadow_offset_x: f64,
pub(crate) shadow_offset_y: f64,
pub(crate) shadow_blur: f64,
pub(crate) shadow_color: B::Color,
pub(crate) font_style: Option<ServoArc<FontStyleStruct>>,
pub(crate) text_align: TextAlign,
pub(crate) text_baseline: TextBaseline,
pub(crate) _backend: PhantomData<B>,
}
/// It writes an image to the destination target /// It writes an image to the destination target
/// draw_target: the destination target where the image_data will be copied /// draw_target: the destination target where the image_data will be copied
/// image_data: Pixel information of the image to be written. It takes RGBA8 /// image_data: Pixel information of the image to be written. It takes RGBA8
@ -806,7 +776,8 @@ fn write_image<B: Backend>(
snapshot: Snapshot, snapshot: Snapshot,
dest_rect: Rect<f64>, dest_rect: Rect<f64>,
smoothing_enabled: bool, smoothing_enabled: bool,
draw_options: &B::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
if snapshot.size().is_empty() { if snapshot.size().is_empty() {
return; return;
@ -828,7 +799,14 @@ fn write_image<B: Backend>(
.create_source_surface_from_data(snapshot) .create_source_surface_from_data(snapshot)
.unwrap(); .unwrap();
draw_target.draw_surface(source_surface, dest_rect, image_rect, filter, draw_options); draw_target.draw_surface(
source_surface,
dest_rect,
image_rect,
filter,
composition_options,
transform,
);
} }
pub(crate) trait RectToi32 { pub(crate) trait RectToi32 {

View file

@ -2,6 +2,8 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this * License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
#![allow(clippy::too_many_arguments)]
use std::borrow::ToOwned; use std::borrow::ToOwned;
use std::collections::HashMap; use std::collections::HashMap;
use std::sync::Arc; use std::sync::Arc;
@ -18,26 +20,24 @@ use ipc_channel::router::ROUTER;
use log::warn; use log::warn;
use net_traits::ResourceThreads; use net_traits::ResourceThreads;
use pixels::Snapshot; use pixels::Snapshot;
use style::color::AbsoluteColor;
use style::properties::style_structs::Font as FontStyleStruct;
use webrender_api::ImageKey; use webrender_api::ImageKey;
use crate::canvas_data::*; use crate::canvas_data::*;
use crate::raqote_backend::RaqoteBackend; use crate::raqote_backend::RaqoteBackend;
pub struct CanvasPaintThread<'a> { pub struct CanvasPaintThread {
canvases: HashMap<CanvasId, Canvas<'a>>, canvases: HashMap<CanvasId, Canvas>,
next_canvas_id: CanvasId, next_canvas_id: CanvasId,
compositor_api: CrossProcessCompositorApi, compositor_api: CrossProcessCompositorApi,
font_context: Arc<FontContext>, font_context: Arc<FontContext>,
} }
impl<'a> CanvasPaintThread<'a> { impl CanvasPaintThread {
fn new( fn new(
compositor_api: CrossProcessCompositorApi, compositor_api: CrossProcessCompositorApi,
system_font_service: Arc<SystemFontServiceProxy>, system_font_service: Arc<SystemFontServiceProxy>,
resource_threads: ResourceThreads, resource_threads: ResourceThreads,
) -> CanvasPaintThread<'a> { ) -> CanvasPaintThread {
CanvasPaintThread { CanvasPaintThread {
canvases: HashMap::new(), canvases: HashMap::new(),
next_canvas_id: CanvasId(0), next_canvas_id: CanvasId(0),
@ -146,21 +146,27 @@ impl<'a> CanvasPaintThread<'a> {
composition_options, composition_options,
transform, transform,
) => { ) => {
let canvas = self.canvas(canvas_id); self.canvas(canvas_id).fill_text(
canvas.set_transform(&transform); text,
canvas.set_fill_style(style); x,
canvas.set_text_options(text_options); y,
canvas.set_shadow_options(shadow_options); max_width,
canvas.set_composition_options(composition_options); is_rtl,
canvas.fill_text(text, x, y, max_width, is_rtl); style,
text_options,
shadow_options,
composition_options,
transform,
);
}, },
Canvas2dMsg::FillRect(rect, style, shadow_options, composition_options, transform) => { Canvas2dMsg::FillRect(rect, style, shadow_options, composition_options, transform) => {
let canvas = self.canvas(canvas_id); self.canvas(canvas_id).fill_rect(
canvas.set_transform(&transform); &rect,
canvas.set_fill_style(style); style,
canvas.set_shadow_options(shadow_options); shadow_options,
canvas.set_composition_options(composition_options); composition_options,
canvas.fill_rect(&rect); transform,
);
}, },
Canvas2dMsg::StrokeRect( Canvas2dMsg::StrokeRect(
rect, rect,
@ -170,25 +176,26 @@ impl<'a> CanvasPaintThread<'a> {
composition_options, composition_options,
transform, transform,
) => { ) => {
let canvas = self.canvas(canvas_id); self.canvas(canvas_id).stroke_rect(
canvas.set_transform(&transform); &rect,
canvas.set_stroke_style(style); style,
canvas.set_line_options(line_options); line_options,
canvas.set_shadow_options(shadow_options); shadow_options,
canvas.set_composition_options(composition_options); composition_options,
canvas.stroke_rect(&rect); transform,
);
}, },
Canvas2dMsg::ClearRect(ref rect, transform) => { Canvas2dMsg::ClearRect(ref rect, transform) => {
self.canvas(canvas_id).set_transform(&transform); self.canvas(canvas_id).clear_rect(rect, transform)
self.canvas(canvas_id).clear_rect(rect)
}, },
Canvas2dMsg::FillPath(style, path, shadow_options, composition_options, transform) => { Canvas2dMsg::FillPath(style, path, shadow_options, composition_options, transform) => {
let canvas = self.canvas(canvas_id); self.canvas(canvas_id).fill_path(
canvas.set_transform(&transform); &path,
canvas.set_fill_style(style); style,
canvas.set_shadow_options(shadow_options); shadow_options,
canvas.set_composition_options(composition_options); composition_options,
canvas.fill_path(&path); transform,
);
}, },
Canvas2dMsg::StrokePath( Canvas2dMsg::StrokePath(
path, path,
@ -198,18 +205,17 @@ impl<'a> CanvasPaintThread<'a> {
composition_options, composition_options,
transform, transform,
) => { ) => {
let canvas = self.canvas(canvas_id); self.canvas(canvas_id).stroke_path(
canvas.set_transform(&transform); &path,
canvas.set_stroke_style(style); style,
canvas.set_line_options(line_options); line_options,
canvas.set_shadow_options(shadow_options); shadow_options,
canvas.set_composition_options(composition_options); composition_options,
canvas.stroke_path(&path); transform,
);
}, },
Canvas2dMsg::ClipPath(path, transform) => { Canvas2dMsg::ClipPath(path, transform) => {
let canvas = self.canvas(canvas_id); self.canvas(canvas_id).clip_path(&path, transform);
canvas.set_transform(&transform);
canvas.clip_path(&path);
}, },
Canvas2dMsg::DrawImage( Canvas2dMsg::DrawImage(
snapshot, snapshot,
@ -219,18 +225,15 @@ impl<'a> CanvasPaintThread<'a> {
shadow_options, shadow_options,
composition_options, composition_options,
transform, transform,
) => { ) => self.canvas(canvas_id).draw_image(
let canvas = self.canvas(canvas_id); snapshot.to_owned(),
canvas.set_transform(&transform); dest_rect,
canvas.set_shadow_options(shadow_options); source_rect,
canvas.set_composition_options(composition_options); smoothing_enabled,
canvas.draw_image( shadow_options,
snapshot.to_owned(), composition_options,
dest_rect, transform,
source_rect, ),
smoothing_enabled,
)
},
Canvas2dMsg::DrawEmptyImage( Canvas2dMsg::DrawEmptyImage(
image_size, image_size,
dest_rect, dest_rect,
@ -238,18 +241,15 @@ impl<'a> CanvasPaintThread<'a> {
shadow_options, shadow_options,
composition_options, composition_options,
transform, transform,
) => { ) => self.canvas(canvas_id).draw_image(
let canvas = self.canvas(canvas_id); Snapshot::cleared(image_size),
canvas.set_transform(&transform); dest_rect,
canvas.set_shadow_options(shadow_options); source_rect,
canvas.set_composition_options(composition_options); false,
self.canvas(canvas_id).draw_image( shadow_options,
Snapshot::cleared(image_size), composition_options,
dest_rect, transform,
source_rect, ),
false,
)
},
Canvas2dMsg::DrawImageInOther( Canvas2dMsg::DrawImageInOther(
other_canvas_id, other_canvas_id,
image_size, image_size,
@ -263,20 +263,20 @@ impl<'a> CanvasPaintThread<'a> {
let snapshot = self let snapshot = self
.canvas(canvas_id) .canvas(canvas_id)
.read_pixels(Some(source_rect.to_u32()), Some(image_size)); .read_pixels(Some(source_rect.to_u32()), Some(image_size));
let canvas = self.canvas(other_canvas_id); self.canvas(other_canvas_id).draw_image(
canvas.set_transform(&transform); snapshot,
canvas.set_composition_options(composition_options); dest_rect,
canvas.set_shadow_options(shadow_options); source_rect,
canvas.draw_image(snapshot, dest_rect, source_rect, smoothing); smoothing,
shadow_options,
composition_options,
transform,
);
}, },
Canvas2dMsg::MeasureText(text, sender, text_options) => { Canvas2dMsg::MeasureText(text, sender, text_options) => {
let canvas = self.canvas(canvas_id); let metrics = self.canvas(canvas_id).measure_text(text, text_options);
canvas.set_text_options(text_options);
let metrics = canvas.measure_text(text);
sender.send(metrics).unwrap(); sender.send(metrics).unwrap();
}, },
Canvas2dMsg::RestoreContext => self.canvas(canvas_id).restore_context_state(),
Canvas2dMsg::SaveContext => self.canvas(canvas_id).save_context_state(),
Canvas2dMsg::GetImageData(dest_rect, canvas_size, sender) => { Canvas2dMsg::GetImageData(dest_rect, canvas_size, sender) => {
let snapshot = self let snapshot = self
.canvas(canvas_id) .canvas(canvas_id)
@ -291,64 +291,130 @@ impl<'a> CanvasPaintThread<'a> {
self.canvas(canvas_id).update_image_rendering(); self.canvas(canvas_id).update_image_rendering();
sender.send(()).unwrap(); sender.send(()).unwrap();
}, },
Canvas2dMsg::PopClip => self.canvas(canvas_id).pop_clip(),
} }
} }
fn canvas(&mut self, canvas_id: CanvasId) -> &mut Canvas<'a> { fn canvas(&mut self, canvas_id: CanvasId) -> &mut Canvas {
self.canvases.get_mut(&canvas_id).expect("Bogus canvas id") self.canvases.get_mut(&canvas_id).expect("Bogus canvas id")
} }
} }
enum Canvas<'a> { enum Canvas {
Raqote(CanvasData<'a, RaqoteBackend>), Raqote(CanvasData<RaqoteBackend>),
} }
impl Canvas<'_> { impl Canvas {
fn set_fill_style(&mut self, style: FillOrStrokeStyle) { fn pop_clip(&mut self) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.set_fill_style(style), Canvas::Raqote(canvas_data) => canvas_data.pop_clip(),
} }
} }
fn fill_text(&mut self, text: String, x: f64, y: f64, max_width: Option<f64>, is_rtl: bool) { fn fill_text(
&mut self,
text: String,
x: f64,
y: f64,
max_width: Option<f64>,
is_rtl: bool,
style: FillOrStrokeStyle,
text_options: TextOptions,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.fill_text(text, x, y, max_width, is_rtl), Canvas::Raqote(canvas_data) => canvas_data.fill_text(
text,
x,
y,
max_width,
is_rtl,
style,
text_options,
shadow_options,
composition_options,
transform,
),
} }
} }
fn fill_rect(&mut self, rect: &Rect<f32>) { fn fill_rect(
&mut self,
rect: &Rect<f32>,
style: FillOrStrokeStyle,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.fill_rect(rect), Canvas::Raqote(canvas_data) => {
canvas_data.fill_rect(rect, style, shadow_options, composition_options, transform)
},
} }
} }
fn set_stroke_style(&mut self, style: FillOrStrokeStyle) { fn stroke_rect(
&mut self,
rect: &Rect<f32>,
style: FillOrStrokeStyle,
line_options: LineOptions,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.set_stroke_style(style), Canvas::Raqote(canvas_data) => canvas_data.stroke_rect(
rect,
style,
line_options,
shadow_options,
composition_options,
transform,
),
} }
} }
fn stroke_rect(&mut self, rect: &Rect<f32>) { fn fill_path(
&mut self,
path: &Path,
style: FillOrStrokeStyle,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.stroke_rect(rect), Canvas::Raqote(canvas_data) => {
canvas_data.fill_path(path, style, shadow_options, composition_options, transform)
},
} }
} }
fn fill_path(&mut self, path: &Path) { fn stroke_path(
&mut self,
path: &Path,
style: FillOrStrokeStyle,
line_options: LineOptions,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.fill_path(path), Canvas::Raqote(canvas_data) => canvas_data.stroke_path(
path,
style,
line_options,
shadow_options,
composition_options,
transform,
),
} }
} }
fn stroke_path(&mut self, path: &Path) { fn clear_rect(&mut self, rect: &Rect<f32>, transform: Transform2D<f32>) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.stroke_path(path), Canvas::Raqote(canvas_data) => canvas_data.clear_rect(rect, transform),
}
}
fn clear_rect(&mut self, rect: &Rect<f32>) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.clear_rect(rect),
} }
} }
@ -358,11 +424,20 @@ impl Canvas<'_> {
dest_rect: Rect<f64>, dest_rect: Rect<f64>,
source_rect: Rect<f64>, source_rect: Rect<f64>,
smoothing_enabled: bool, smoothing_enabled: bool,
shadow_options: ShadowOptions,
composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
match self { match self {
Canvas::Raqote(canvas_data) => { Canvas::Raqote(canvas_data) => canvas_data.draw_image(
canvas_data.draw_image(snapshot, dest_rect, source_rect, smoothing_enabled) snapshot,
}, dest_rect,
source_rect,
smoothing_enabled,
shadow_options,
composition_options,
transform,
),
} }
} }
@ -376,123 +451,15 @@ impl Canvas<'_> {
} }
} }
fn restore_context_state(&mut self) { fn measure_text(&mut self, text: String, text_options: TextOptions) -> TextMetrics {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.restore_context_state(), Canvas::Raqote(canvas_data) => canvas_data.measure_text(text, text_options),
} }
} }
fn save_context_state(&mut self) { fn clip_path(&mut self, path: &Path, transform: Transform2D<f32>) {
match self { match self {
Canvas::Raqote(canvas_data) => canvas_data.save_context_state(), Canvas::Raqote(canvas_data) => canvas_data.clip_path(path, transform),
}
}
fn set_line_width(&mut self, width: f32) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_line_width(width),
}
}
fn set_line_cap(&mut self, cap: LineCapStyle) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_line_cap(cap),
}
}
fn set_line_join(&mut self, join: LineJoinStyle) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_line_join(join),
}
}
fn set_miter_limit(&mut self, limit: f32) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_miter_limit(limit),
}
}
fn set_line_dash(&mut self, items: Vec<f32>) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_line_dash(items),
}
}
fn set_line_dash_offset(&mut self, offset: f32) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_line_dash_offset(offset),
}
}
fn set_transform(&mut self, matrix: &Transform2D<f32>) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_transform(matrix),
}
}
fn set_global_alpha(&mut self, alpha: f32) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_global_alpha(alpha),
}
}
fn set_global_composition(&mut self, op: CompositionOrBlending) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_global_composition(op),
}
}
fn set_shadow_offset_x(&mut self, value: f64) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_shadow_offset_x(value),
}
}
fn set_shadow_offset_y(&mut self, value: f64) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_shadow_offset_y(value),
}
}
fn set_shadow_blur(&mut self, value: f64) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_shadow_blur(value),
}
}
fn set_shadow_color(&mut self, color: AbsoluteColor) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_shadow_color(color),
}
}
fn set_font(&mut self, font_style: FontStyleStruct) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_font(font_style),
}
}
fn set_text_align(&mut self, text_align: TextAlign) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_text_align(text_align),
}
}
fn set_text_baseline(&mut self, text_baseline: TextBaseline) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.set_text_baseline(text_baseline),
}
}
fn measure_text(&mut self, text: String) -> TextMetrics {
match self {
Canvas::Raqote(canvas_data) => canvas_data.measure_text(text),
}
}
fn clip_path(&mut self, path: &Path) {
match self {
Canvas::Raqote(canvas_data) => canvas_data.clip_path(path),
} }
} }
@ -513,41 +480,4 @@ impl Canvas<'_> {
Canvas::Raqote(canvas_data) => canvas_data.recreate(size), Canvas::Raqote(canvas_data) => canvas_data.recreate(size),
} }
} }
fn set_text_options(&mut self, text_options: TextOptions) {
if let Some(font) = text_options.font {
self.set_font(font);
}
self.set_text_align(text_options.align);
self.set_text_baseline(text_options.baseline);
}
fn set_shadow_options(&mut self, shadow_options: ShadowOptions) {
self.set_shadow_color(shadow_options.color);
self.set_shadow_offset_x(shadow_options.offset_x);
self.set_shadow_offset_y(shadow_options.offset_y);
self.set_shadow_blur(shadow_options.blur);
}
fn set_composition_options(&mut self, composition_options: CompositionOptions) {
self.set_global_alpha(composition_options.alpha as f32);
self.set_global_composition(composition_options.composition_operation);
}
fn set_line_options(&mut self, line_options: LineOptions) {
let LineOptions {
width,
cap_style,
join_style,
miter_limit,
dash,
dash_offset,
} = line_options;
self.set_line_width(width as f32);
self.set_line_cap(cap_style);
self.set_line_join(join_style);
self.set_miter_limit(miter_limit as f32);
self.set_line_dash(dash);
self.set_line_dash_offset(dash_offset as f32);
}
} }

View file

@ -8,21 +8,19 @@ use std::collections::HashMap;
use canvas_traits::canvas::*; use canvas_traits::canvas::*;
use compositing_traits::SerializableImageData; use compositing_traits::SerializableImageData;
use cssparser::color::clamp_unit_f32; use cssparser::color::clamp_unit_f32;
use euclid::default::{Point2D, Rect, Size2D, Transform2D, Vector2D}; use euclid::default::{Point2D, Rect, Size2D, Transform2D};
use font_kit::font::Font; use font_kit::font::Font;
use fonts::{ByteIndex, FontIdentifier, FontTemplateRefMethods}; use fonts::{ByteIndex, FontIdentifier, FontTemplateRefMethods};
use ipc_channel::ipc::IpcSharedMemory; use ipc_channel::ipc::IpcSharedMemory;
use log::warn; use log::warn;
use pixels::{Snapshot, SnapshotAlphaMode, SnapshotPixelFormat}; use pixels::{Snapshot, SnapshotAlphaMode, SnapshotPixelFormat};
use range::Range; use range::Range;
use raqote::PathBuilder; use raqote::{DrawOptions, PathBuilder, StrokeStyle};
use style::color::AbsoluteColor; use style::color::AbsoluteColor;
use webrender_api::{ImageDescriptor, ImageDescriptorFlags, ImageFormat}; use webrender_api::{ImageDescriptor, ImageDescriptorFlags, ImageFormat};
use crate::backend::{ use crate::backend::{Backend, GenericDrawTarget};
Backend, DrawOptionsHelpers, GenericDrawTarget, PatternHelpers, StrokeOptionsHelpers, use crate::canvas_data::{Filter, TextRun};
};
use crate::canvas_data::{CanvasPaintState, Filter, TextRun};
thread_local! { thread_local! {
/// The shared font cache used by all canvases that render on a thread. It would be nicer /// The shared font cache used by all canvases that render on a thread. It would be nicer
@ -36,80 +34,12 @@ thread_local! {
pub(crate) struct RaqoteBackend; pub(crate) struct RaqoteBackend;
impl Backend for RaqoteBackend { impl Backend for RaqoteBackend {
type Pattern<'a> = Pattern;
type StrokeOptions = raqote::StrokeStyle;
type Color = raqote::SolidSource;
type DrawOptions = raqote::DrawOptions;
type CompositionOp = raqote::BlendMode;
type DrawTarget = raqote::DrawTarget; type DrawTarget = raqote::DrawTarget;
type SourceSurface = Vec<u8>; // TODO: See if we can avoid the alloc (probably?) type SourceSurface = Vec<u8>; // TODO: See if we can avoid the alloc (probably?)
type GradientStop = raqote::GradientStop;
type GradientStops = Vec<raqote::GradientStop>;
fn get_composition_op(&self, opts: &Self::DrawOptions) -> Self::CompositionOp {
opts.blend_mode
}
fn need_to_draw_shadow(&self, color: &Self::Color) -> bool {
color.a != 0
}
fn set_shadow_color(&mut self, color: AbsoluteColor, state: &mut CanvasPaintState<'_, Self>) {
state.shadow_color = color.to_raqote_style();
}
fn set_fill_style(
&mut self,
style: FillOrStrokeStyle,
state: &mut CanvasPaintState<'_, Self>,
_drawtarget: &Self::DrawTarget,
) {
if let Some(pattern) = style.to_raqote_pattern() {
state.fill_style = pattern;
}
}
fn set_stroke_style(
&mut self,
style: FillOrStrokeStyle,
state: &mut CanvasPaintState<'_, Self>,
_drawtarget: &Self::DrawTarget,
) {
if let Some(pattern) = style.to_raqote_pattern() {
state.stroke_style = pattern;
}
}
fn set_global_composition(
&mut self,
op: CompositionOrBlending,
state: &mut CanvasPaintState<'_, Self>,
) {
state.draw_options.blend_mode = op.to_raqote_style();
}
fn create_drawtarget(&self, size: Size2D<u64>) -> Self::DrawTarget { fn create_drawtarget(&self, size: Size2D<u64>) -> Self::DrawTarget {
raqote::DrawTarget::new(size.width as i32, size.height as i32) raqote::DrawTarget::new(size.width as i32, size.height as i32)
} }
fn new_paint_state<'a>(&self) -> CanvasPaintState<'a, Self> {
let pattern = Pattern::Color(255, 0, 0, 0);
CanvasPaintState {
draw_options: raqote::DrawOptions::new(),
fill_style: pattern.clone(),
stroke_style: pattern,
stroke_opts: Default::default(),
transform: Transform2D::identity(),
shadow_offset_x: 0.0,
shadow_offset_y: 0.0,
shadow_blur: 0.0,
shadow_color: raqote::SolidSource::from_unpremultiplied_argb(0, 0, 0, 0),
font_style: None,
text_align: TextAlign::default(),
text_baseline: TextBaseline::default(),
_backend: std::marker::PhantomData,
}
}
} }
#[derive(Clone)] #[derive(Clone)]
@ -170,7 +100,6 @@ pub struct SurfacePattern {
image: Snapshot, image: Snapshot,
filter: raqote::FilterMode, filter: raqote::FilterMode,
extend: raqote::ExtendMode, extend: raqote::ExtendMode,
repeat: Repetition,
transform: Transform2D<f32>, transform: Transform2D<f32>,
} }
@ -191,14 +120,9 @@ impl SurfacePattern {
image, image,
filter, filter,
extend, extend,
repeat,
transform, transform,
} }
} }
pub fn repetition(&self) -> &Repetition {
&self.repeat
}
} }
#[derive(Clone, Copy, Debug)] #[derive(Clone, Copy, Debug)]
@ -265,73 +189,6 @@ pub fn source(pattern: &Pattern) -> raqote::Source {
} }
} }
impl PatternHelpers for Pattern {
fn is_zero_size_gradient(&self) -> bool {
match self {
Pattern::RadialGradient(pattern) => {
let centers_equal = pattern.center1 == pattern.center2;
let radii_equal = pattern.radius1 == pattern.radius2;
(centers_equal && radii_equal) || pattern.gradient.stops.is_empty()
},
Pattern::LinearGradient(pattern) => {
(pattern.start == pattern.end) || pattern.gradient.stops.is_empty()
},
Pattern::Color(..) | Pattern::Surface(..) => false,
}
}
fn x_bound(&self) -> Option<u32> {
match self {
Pattern::Surface(pattern) => match pattern.repetition() {
Repetition::RepeatX | Repetition::Repeat => None, // x is not bounded
Repetition::RepeatY | Repetition::NoRepeat => Some(pattern.image.size().width),
},
Pattern::Color(..) | Pattern::LinearGradient(..) | Pattern::RadialGradient(..) => None,
}
}
fn y_bound(&self) -> Option<u32> {
match self {
Pattern::Surface(pattern) => match pattern.repetition() {
Repetition::RepeatY | Repetition::Repeat => None, // y is not bounded
Repetition::RepeatX | Repetition::NoRepeat => Some(pattern.image.size().height),
},
Pattern::Color(..) | Pattern::LinearGradient(..) | Pattern::RadialGradient(..) => None,
}
}
}
impl StrokeOptionsHelpers for raqote::StrokeStyle {
fn set_line_width(&mut self, _val: f32) {
self.width = _val;
}
fn set_miter_limit(&mut self, _val: f32) {
self.miter_limit = _val;
}
fn set_line_join(&mut self, val: LineJoinStyle) {
self.join = val.to_raqote_style();
}
fn set_line_cap(&mut self, val: LineCapStyle) {
self.cap = val.to_raqote_style();
}
fn set_line_dash(&mut self, items: Vec<f32>) {
self.dash_array = items;
}
fn set_line_dash_offset(&mut self, offset: f32) {
self.dash_offset = offset;
}
}
impl DrawOptionsHelpers for raqote::DrawOptions {
fn set_alpha(&mut self, val: f32) {
self.alpha = val;
}
fn is_clear(&self) -> bool {
matches!(self.blend_mode, raqote::BlendMode::Clear)
}
}
fn create_gradient_stops(gradient_stops: Vec<CanvasGradientStop>) -> Vec<raqote::GradientStop> { fn create_gradient_stops(gradient_stops: Vec<CanvasGradientStop>) -> Vec<raqote::GradientStop> {
let mut stops = gradient_stops let mut stops = gradient_stops
.into_iter() .into_iter()
@ -343,19 +200,17 @@ fn create_gradient_stops(gradient_stops: Vec<CanvasGradientStop>) -> Vec<raqote:
} }
impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget { impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
fn clear_rect(&mut self, rect: &Rect<f32>) { fn clear_rect(&mut self, rect: &Rect<f32>, transform: Transform2D<f32>) {
let rect = rect.cast(); <Self as GenericDrawTarget<RaqoteBackend>>::fill_rect(
let mut pb = canvas_traits::canvas::Path::new(); self,
pb.rect( rect,
rect.origin.x, FillOrStrokeStyle::Color(AbsoluteColor::TRANSPARENT_BLACK),
rect.origin.y, CompositionOptions {
rect.size.width, alpha: 1.0,
rect.size.height, composition_operation: CompositionOrBlending::Composition(CompositionStyle::Clear),
},
transform,
); );
let mut options = raqote::DrawOptions::new();
options.blend_mode = raqote::BlendMode::Clear;
let pattern = Pattern::Color(0, 0, 0, 0);
<Self as GenericDrawTarget<RaqoteBackend>>::fill(self, &pb, &pattern, &options);
} }
#[allow(unsafe_code)] #[allow(unsafe_code)]
fn copy_surface( fn copy_surface(
@ -396,12 +251,13 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
&mut self, &mut self,
surface: <RaqoteBackend as Backend>::SourceSurface, surface: <RaqoteBackend as Backend>::SourceSurface,
dest: Rect<f64>, dest: Rect<f64>,
source: Rect<f64>, src: Rect<f64>,
filter: Filter, filter: Filter,
draw_options: &<RaqoteBackend as Backend>::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
let image = Snapshot::from_vec( let image = Snapshot::from_vec(
source.size.cast(), src.size.cast(),
SnapshotPixelFormat::BGRA, SnapshotPixelFormat::BGRA,
SnapshotAlphaMode::Transparent { SnapshotAlphaMode::Transparent {
premultiplied: true, premultiplied: true,
@ -409,83 +265,70 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
surface, surface,
); );
let transform = let paint_transform =
raqote::Transform::translation(-dest.origin.x as f32, -dest.origin.y as f32) raqote::Transform::translation(-dest.origin.x as f32, -dest.origin.y as f32)
.then_scale( .then_scale(
source.size.width as f32 / dest.size.width as f32, src.size.width as f32 / dest.size.width as f32,
source.size.height as f32 / dest.size.height as f32, src.size.height as f32 / dest.size.height as f32,
); );
let pattern = Pattern::Surface(SurfacePattern::new( let pattern = Pattern::Surface(SurfacePattern::new(
image, image,
filter.to_raqote(), filter.to_raqote(),
Repetition::NoRepeat, Repetition::NoRepeat,
transform, paint_transform,
)); ));
let mut pb = canvas_traits::canvas::Path::new(); self.set_transform(&transform);
let dest = dest.cast();
let mut pb = raqote::PathBuilder::new();
pb.rect( pb.rect(
dest.origin.x, dest.origin.x,
dest.origin.y, dest.origin.y,
dest.size.width, dest.size.width,
dest.size.height, dest.size.height,
); );
fill_draw_target(
<Self as GenericDrawTarget<RaqoteBackend>>::fill(self, &pb, &pattern, draw_options); self,
draw_options(composition_options),
pattern,
pb.finish(),
);
} }
fn draw_surface_with_shadow( fn draw_surface_with_shadow(
&self, &self,
_surface: <RaqoteBackend as Backend>::SourceSurface, _surface: <RaqoteBackend as Backend>::SourceSurface,
_dest: &Point2D<f32>, _dest: &Point2D<f32>,
_color: &<RaqoteBackend as Backend>::Color, _shadow_options: ShadowOptions,
_offset: &Vector2D<f32>, _composition_options: CompositionOptions,
_sigma: f32,
_operator: <RaqoteBackend as Backend>::CompositionOp,
) { ) {
warn!("no support for drawing shadows"); warn!("no support for drawing shadows");
} }
fn fill( fn fill(
&mut self, &mut self,
path: &canvas_traits::canvas::Path, path: &canvas_traits::canvas::Path,
pattern: &Pattern, style: FillOrStrokeStyle,
draw_options: &<RaqoteBackend as Backend>::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
self.set_transform(&transform);
let draw_options = draw_options(composition_options);
let pattern = style.to_raqote_pattern();
let path = to_path(path); let path = to_path(path);
match draw_options.blend_mode { fill_draw_target(self, draw_options, pattern, path);
raqote::BlendMode::Src => {
self.clear(raqote::SolidSource::from_unpremultiplied_argb(0, 0, 0, 0));
self.fill(&path, &source(pattern), draw_options);
},
raqote::BlendMode::Clear |
raqote::BlendMode::SrcAtop |
raqote::BlendMode::DstOut |
raqote::BlendMode::Add |
raqote::BlendMode::Xor |
raqote::BlendMode::DstOver |
raqote::BlendMode::SrcOver => {
self.fill(&path, &source(pattern), draw_options);
},
raqote::BlendMode::SrcIn |
raqote::BlendMode::SrcOut |
raqote::BlendMode::DstIn |
raqote::BlendMode::DstAtop => {
let mut options = *draw_options;
self.push_layer_with_blend(1., options.blend_mode);
options.blend_mode = raqote::BlendMode::SrcOver;
self.fill(&path, &source(pattern), &options);
self.pop_layer();
},
_ => warn!("unrecognized blend mode: {:?}", draw_options.blend_mode),
}
} }
fn fill_text( fn fill_text(
&mut self, &mut self,
text_runs: Vec<TextRun>, text_runs: Vec<TextRun>,
start: Point2D<f32>, start: Point2D<f32>,
pattern: &Pattern, style: FillOrStrokeStyle,
draw_options: &<RaqoteBackend as Backend>::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
self.set_transform(&transform);
let draw_options = draw_options(composition_options);
let pattern = style.to_raqote_pattern();
let mut advance = 0.; let mut advance = 0.;
for run in text_runs.iter() { for run in text_runs.iter() {
let mut positions = Vec::new(); let mut positions = Vec::new();
@ -532,8 +375,8 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
run.font.descriptor.pt_size.to_f32_px(), run.font.descriptor.pt_size.to_f32_px(),
&ids, &ids,
&positions, &positions,
&source(pattern), &source(&pattern),
draw_options, &draw_options,
); );
}) })
} }
@ -542,8 +385,9 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
fn fill_rect( fn fill_rect(
&mut self, &mut self,
rect: &Rect<f32>, rect: &Rect<f32>,
pattern: &<RaqoteBackend as Backend>::Pattern<'_>, style: FillOrStrokeStyle,
draw_options: &<RaqoteBackend as Backend>::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
let rect = rect.cast(); let rect = rect.cast();
let mut pb = canvas_traits::canvas::Path::new(); let mut pb = canvas_traits::canvas::Path::new();
@ -554,50 +398,59 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
rect.size.height, rect.size.height,
); );
<Self as GenericDrawTarget<RaqoteBackend>>::fill(self, &pb, pattern, draw_options); <Self as GenericDrawTarget<RaqoteBackend>>::fill(
self,
&pb,
style,
composition_options,
transform,
);
} }
fn get_size(&self) -> Size2D<i32> { fn get_size(&self) -> Size2D<i32> {
Size2D::new(self.width(), self.height()) Size2D::new(self.width(), self.height())
} }
fn get_transform(&self) -> Transform2D<f32> {
*self.get_transform()
}
fn pop_clip(&mut self) { fn pop_clip(&mut self) {
self.pop_clip(); self.pop_clip();
} }
fn push_clip(&mut self, path: &canvas_traits::canvas::Path) { fn push_clip(&mut self, path: &canvas_traits::canvas::Path, transform: Transform2D<f32>) {
self.set_transform(&transform);
self.push_clip(&to_path(path)); self.push_clip(&to_path(path));
} }
fn push_clip_rect(&mut self, rect: &Rect<i32>) { fn push_clip_rect(&mut self, rect: &Rect<i32>) {
self.push_clip_rect(rect.to_box2d()); self.push_clip_rect(rect.to_box2d());
} }
fn set_transform(&mut self, matrix: &Transform2D<f32>) {
self.set_transform(matrix);
}
fn surface(&self) -> <RaqoteBackend as Backend>::SourceSurface { fn surface(&self) -> <RaqoteBackend as Backend>::SourceSurface {
self.get_data_u8().to_vec() self.get_data_u8().to_vec()
} }
fn stroke( fn stroke(
&mut self, &mut self,
path: &canvas_traits::canvas::Path, path: &canvas_traits::canvas::Path,
pattern: &Pattern, style: FillOrStrokeStyle,
stroke_options: &<RaqoteBackend as Backend>::StrokeOptions, line_options: LineOptions,
draw_options: &<RaqoteBackend as Backend>::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
let pattern = style.to_raqote_pattern();
let options = draw_options(composition_options);
self.set_transform(&transform);
self.stroke( self.stroke(
&to_path(path), &to_path(path),
&source(pattern), &source(&pattern),
stroke_options, &line_options.to_raqote_style(),
draw_options, &options,
); );
} }
fn stroke_rect( fn stroke_rect(
&mut self, &mut self,
rect: &Rect<f32>, rect: &Rect<f32>,
pattern: &<RaqoteBackend as Backend>::Pattern<'_>, style: FillOrStrokeStyle,
stroke_options: &<RaqoteBackend as Backend>::StrokeOptions, line_options: LineOptions,
draw_options: &<RaqoteBackend as Backend>::DrawOptions, composition_options: CompositionOptions,
transform: Transform2D<f32>,
) { ) {
self.set_transform(&transform);
let pattern = style.to_raqote_pattern();
let options = draw_options(composition_options);
let mut pb = raqote::PathBuilder::new(); let mut pb = raqote::PathBuilder::new();
pb.rect( pb.rect(
rect.origin.x, rect.origin.x,
@ -606,7 +459,12 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
rect.size.height, rect.size.height,
); );
self.stroke(&pb.finish(), &source(pattern), stroke_options, draw_options); self.stroke(
&pb.finish(),
&source(&pattern),
&line_options.to_raqote_style(),
&options,
);
} }
fn image_descriptor_and_serializable_data( fn image_descriptor_and_serializable_data(
@ -638,6 +496,40 @@ impl GenericDrawTarget<RaqoteBackend> for raqote::DrawTarget {
} }
} }
fn fill_draw_target(
draw_target: &mut raqote::DrawTarget,
draw_options: DrawOptions,
pattern: Pattern,
path: raqote::Path,
) {
match draw_options.blend_mode {
raqote::BlendMode::Src => {
draw_target.clear(raqote::SolidSource::from_unpremultiplied_argb(0, 0, 0, 0));
draw_target.fill(&path, &source(&pattern), &draw_options);
},
raqote::BlendMode::Clear |
raqote::BlendMode::SrcAtop |
raqote::BlendMode::DstOut |
raqote::BlendMode::Add |
raqote::BlendMode::Xor |
raqote::BlendMode::DstOver |
raqote::BlendMode::SrcOver => {
draw_target.fill(&path, &source(&pattern), &draw_options);
},
raqote::BlendMode::SrcIn |
raqote::BlendMode::SrcOut |
raqote::BlendMode::DstIn |
raqote::BlendMode::DstAtop => {
let mut options = draw_options;
draw_target.push_layer_with_blend(1., options.blend_mode);
options.blend_mode = raqote::BlendMode::SrcOver;
draw_target.fill(&path, &source(&pattern), &options);
draw_target.pop_layer();
},
_ => warn!("unrecognized blend mode: {:?}", draw_options.blend_mode),
}
}
impl Filter { impl Filter {
fn to_raqote(self) -> raqote::FilterMode { fn to_raqote(self) -> raqote::FilterMode {
match self { match self {
@ -676,6 +568,29 @@ pub trait ToRaqoteStyle {
fn to_raqote_style(self) -> Self::Target; fn to_raqote_style(self) -> Self::Target;
} }
impl ToRaqoteStyle for LineOptions {
type Target = StrokeStyle;
fn to_raqote_style(self) -> Self::Target {
let LineOptions {
width,
cap_style,
join_style,
miter_limit,
dash,
dash_offset,
} = self;
StrokeStyle {
width: width as f32,
cap: cap_style.to_raqote_style(),
join: join_style.to_raqote_style(),
miter_limit: miter_limit as f32,
dash_array: dash,
dash_offset: dash_offset as f32,
}
}
}
impl ToRaqoteStyle for LineJoinStyle { impl ToRaqoteStyle for LineJoinStyle {
type Target = raqote::LineJoin; type Target = raqote::LineJoin;
@ -701,7 +616,7 @@ impl ToRaqoteStyle for LineCapStyle {
} }
pub trait ToRaqotePattern { pub trait ToRaqotePattern {
fn to_raqote_pattern(self) -> Option<Pattern>; fn to_raqote_pattern(self) -> Pattern;
} }
pub trait ToRaqoteGradientStop { pub trait ToRaqoteGradientStop {
@ -724,38 +639,36 @@ impl ToRaqoteGradientStop for CanvasGradientStop {
impl ToRaqotePattern for FillOrStrokeStyle { impl ToRaqotePattern for FillOrStrokeStyle {
#[allow(unsafe_code)] #[allow(unsafe_code)]
fn to_raqote_pattern(self) -> Option<Pattern> { fn to_raqote_pattern(self) -> Pattern {
use canvas_traits::canvas::FillOrStrokeStyle::*; use canvas_traits::canvas::FillOrStrokeStyle::*;
match self { match self {
Color(color) => { Color(color) => {
let srgb = color.into_srgb_legacy(); let srgb = color.into_srgb_legacy();
Some(Pattern::Color( Pattern::Color(
clamp_unit_f32(srgb.alpha), clamp_unit_f32(srgb.alpha),
clamp_unit_f32(srgb.components.0), clamp_unit_f32(srgb.components.0),
clamp_unit_f32(srgb.components.1), clamp_unit_f32(srgb.components.1),
clamp_unit_f32(srgb.components.2), clamp_unit_f32(srgb.components.2),
)) )
}, },
LinearGradient(style) => { LinearGradient(style) => {
let start = Point2D::new(style.x0 as f32, style.y0 as f32); let start = Point2D::new(style.x0 as f32, style.y0 as f32);
let end = Point2D::new(style.x1 as f32, style.y1 as f32); let end = Point2D::new(style.x1 as f32, style.y1 as f32);
let stops = create_gradient_stops(style.stops); let stops = create_gradient_stops(style.stops);
Some(Pattern::LinearGradient(LinearGradientPattern::new( Pattern::LinearGradient(LinearGradientPattern::new(start, end, stops))
start, end, stops,
)))
}, },
RadialGradient(style) => { RadialGradient(style) => {
let center1 = Point2D::new(style.x0 as f32, style.y0 as f32); let center1 = Point2D::new(style.x0 as f32, style.y0 as f32);
let center2 = Point2D::new(style.x1 as f32, style.y1 as f32); let center2 = Point2D::new(style.x1 as f32, style.y1 as f32);
let stops = create_gradient_stops(style.stops); let stops = create_gradient_stops(style.stops);
Some(Pattern::RadialGradient(RadialGradientPattern::new( Pattern::RadialGradient(RadialGradientPattern::new(
center1, center1,
style.r0 as f32, style.r0 as f32,
center2, center2,
style.r1 as f32, style.r1 as f32,
stops, stops,
))) ))
}, },
Surface(style) => { Surface(style) => {
let repeat = Repetition::from_xy(style.repeat_x, style.repeat_y); let repeat = Repetition::from_xy(style.repeat_x, style.repeat_y);
@ -766,12 +679,12 @@ impl ToRaqotePattern for FillOrStrokeStyle {
}, },
SnapshotPixelFormat::BGRA, SnapshotPixelFormat::BGRA,
); );
Some(Pattern::Surface(SurfacePattern::new( Pattern::Surface(SurfacePattern::new(
snapshot, snapshot,
raqote::FilterMode::Nearest, raqote::FilterMode::Nearest,
repeat, repeat,
style.transform, style.transform,
))) ))
}, },
} }
} }
@ -869,3 +782,11 @@ fn to_path(path: &canvas_traits::canvas::Path) -> raqote::Path {
} }
pb.finish() pb.finish()
} }
fn draw_options(composition_options: CompositionOptions) -> DrawOptions {
DrawOptions {
blend_mode: composition_options.composition_operation.to_raqote_style(),
alpha: composition_options.alpha as f32,
..Default::default()
}
}

View file

@ -150,7 +150,10 @@ impl CanvasContextState {
fn text_options(&self) -> TextOptions { fn text_options(&self) -> TextOptions {
TextOptions { TextOptions {
font: self.font_style.clone(), font: self
.font_style
.as_ref()
.map(|font| servo_arc::Arc::new(font.clone())),
align: self.text_align, align: self.text_align,
baseline: self.text_baseline, baseline: self.text_baseline,
} }
@ -1344,7 +1347,6 @@ impl CanvasState {
self.saved_states self.saved_states
.borrow_mut() .borrow_mut()
.push(self.state.borrow().clone()); .push(self.state.borrow().clone());
self.send_canvas_2d_msg(Canvas2dMsg::SaveContext);
} }
#[cfg_attr(crown, allow(crown::unrooted_must_root))] #[cfg_attr(crown, allow(crown::unrooted_must_root))]
@ -1353,7 +1355,7 @@ impl CanvasState {
let mut saved_states = self.saved_states.borrow_mut(); let mut saved_states = self.saved_states.borrow_mut();
if let Some(state) = saved_states.pop() { if let Some(state) = saved_states.pop() {
self.state.borrow_mut().clone_from(&state); self.state.borrow_mut().clone_from(&state);
self.send_canvas_2d_msg(Canvas2dMsg::RestoreContext); self.send_canvas_2d_msg(Canvas2dMsg::PopClip);
} }
} }

View file

@ -17,6 +17,7 @@ use serde::{Deserialize, Serialize};
use strum::{Display, EnumString}; use strum::{Display, EnumString};
use style::color::AbsoluteColor; use style::color::AbsoluteColor;
use style::properties::style_structs::Font as FontStyleStruct; use style::properties::style_structs::Font as FontStyleStruct;
use style::servo_arc::Arc as ServoArc;
#[derive(Clone, Debug, Default, Deserialize, Serialize)] #[derive(Clone, Debug, Default, Deserialize, Serialize)]
pub struct Path(pub BezPath); pub struct Path(pub BezPath);
@ -400,7 +401,7 @@ pub enum FillRule {
#[derive(Clone, Copy, Debug, Deserialize, Eq, Hash, MallocSizeOf, PartialEq, Serialize)] #[derive(Clone, Copy, Debug, Deserialize, Eq, Hash, MallocSizeOf, PartialEq, Serialize)]
pub struct CanvasId(pub u64); pub struct CanvasId(pub u64);
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)] #[derive(Clone, Copy, Debug, Deserialize, MallocSizeOf, Serialize)]
pub struct CompositionOptions { pub struct CompositionOptions {
pub alpha: f64, pub alpha: f64,
pub composition_operation: CompositionOrBlending, pub composition_operation: CompositionOrBlending,
@ -414,6 +415,18 @@ pub struct ShadowOptions {
pub color: AbsoluteColor, pub color: AbsoluteColor,
} }
impl ShadowOptions {
/// <https://html.spec.whatwg.org/multipage/#when-shadows-are-drawn>
pub fn need_to_draw_shadow(&self) -> bool {
// Shadows are only drawn if the opacity component of the alpha component of the shadow color is nonzero
self.color.alpha != 0.0 &&
// and either the shadowBlur is nonzero, or the shadowOffsetX is nonzero, or the shadowOffsetY is nonzero.
(self.offset_x != 0.0 ||
self.offset_y != 0.0 ||
self.blur != 0.0)
}
}
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)] #[derive(Debug, Deserialize, MallocSizeOf, Serialize)]
pub struct LineOptions { pub struct LineOptions {
pub width: f64, pub width: f64,
@ -426,7 +439,8 @@ pub struct LineOptions {
#[derive(Debug, Deserialize, MallocSizeOf, Serialize)] #[derive(Debug, Deserialize, MallocSizeOf, Serialize)]
pub struct TextOptions { pub struct TextOptions {
pub font: Option<FontStyleStruct>, #[ignore_malloc_size_of = "Arc"]
pub font: Option<ServoArc<FontStyleStruct>>,
pub align: TextAlign, pub align: TextAlign,
pub baseline: TextBaseline, pub baseline: TextBaseline,
} }
@ -471,6 +485,7 @@ pub enum Canvas2dMsg {
), ),
ClearRect(Rect<f32>, Transform2D<f32>), ClearRect(Rect<f32>, Transform2D<f32>),
ClipPath(Path, Transform2D<f32>), ClipPath(Path, Transform2D<f32>),
PopClip,
FillPath( FillPath(
FillOrStrokeStyle, FillOrStrokeStyle,
Path, Path,
@ -500,8 +515,6 @@ pub enum Canvas2dMsg {
GetImageData(Rect<u32>, Size2D<u32>, IpcSender<IpcSnapshot>), GetImageData(Rect<u32>, Size2D<u32>, IpcSender<IpcSnapshot>),
MeasureText(String, IpcSender<TextMetrics>, TextOptions), MeasureText(String, IpcSender<TextMetrics>, TextOptions),
PutImageData(Rect<u32>, IpcSnapshot), PutImageData(Rect<u32>, IpcSnapshot),
RestoreContext,
SaveContext,
StrokeRect( StrokeRect(
Rect<f32>, Rect<f32>,
FillOrStrokeStyle, FillOrStrokeStyle,
@ -627,6 +640,48 @@ pub enum FillOrStrokeStyle {
Surface(SurfaceStyle), Surface(SurfaceStyle),
} }
impl FillOrStrokeStyle {
pub fn is_zero_size_gradient(&self) -> bool {
match self {
Self::RadialGradient(pattern) => {
let centers_equal = (pattern.x0, pattern.y0) == (pattern.x1, pattern.y1);
let radii_equal = pattern.r0 == pattern.r1;
(centers_equal && radii_equal) || pattern.stops.is_empty()
},
Self::LinearGradient(pattern) => {
(pattern.x0, pattern.y0) == (pattern.x1, pattern.y1) || pattern.stops.is_empty()
},
Self::Color(..) | Self::Surface(..) => false,
}
}
pub fn x_bound(&self) -> Option<u32> {
match self {
Self::Surface(pattern) => {
if pattern.repeat_x {
None
} else {
Some(pattern.surface_size.width)
}
},
Self::Color(..) | Self::LinearGradient(..) | Self::RadialGradient(..) => None,
}
}
pub fn y_bound(&self) -> Option<u32> {
match self {
Self::Surface(pattern) => {
if pattern.repeat_y {
None
} else {
Some(pattern.surface_size.height)
}
},
Self::Color(..) | Self::LinearGradient(..) | Self::RadialGradient(..) => None,
}
}
}
#[derive( #[derive(
Clone, Copy, Debug, Display, Deserialize, EnumString, MallocSizeOf, PartialEq, Serialize, Clone, Copy, Debug, Display, Deserialize, EnumString, MallocSizeOf, PartialEq, Serialize,
)] )]