From d47b769cf7734b20cc36e6b310359e25d43e0b3d Mon Sep 17 00:00:00 2001 From: Jeena Lee Date: Thu, 7 Jul 2016 11:00:56 -0700 Subject: [PATCH] Add test for Profiler::get_statistics, and remove empty space around Profiler::get_statistics. Profiler::get_statistics calculates mean, median, min, and max for a given vector of data. This commit adds a test for the calculated statistics. --- components/profile/time.rs | 4 +--- tests/unit/profile/time.rs | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/components/profile/time.rs b/components/profile/time.rs index f9a70d04b13..4659178b506 100644 --- a/components/profile/time.rs +++ b/components/profile/time.rs @@ -327,8 +327,7 @@ impl Profiler { true } - - fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) { + pub fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) { let data_len = data.len(); let (mean, median, min, max) = (data.iter().sum::() / (data_len as f64), @@ -338,7 +337,6 @@ impl Profiler { (mean, median, min, max) } - fn print_buckets(&mut self) { match self.output { Some(OutputOptions::FileName(ref filename)) => { diff --git a/tests/unit/profile/time.rs b/tests/unit/profile/time.rs index 70daaf2cb73..114959dad23 100644 --- a/tests/unit/profile/time.rs +++ b/tests/unit/profile/time.rs @@ -15,3 +15,24 @@ fn time_profiler_smoke_test() { chan.send(ProfilerMsg::Exit(ipcchan)); assert!(true, "Can tell the profiler thread to exit"); } + +#[test] +fn time_profilers_stats_test() { + let even_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345, \ + 9.2345, 10.2342345, 13.2599, 15.0]; + let (even_mean, even_median, even_min, even_max) = time::Profiler::get_statistics(&even_data); + + assert_eq!(7.34230845, even_mean); + assert_eq!(7.345, even_median); + assert_eq!(1.234, even_min); + assert_eq!(15.0, even_max); + + let odd_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345, \ + 9.2345, 10.2342345, 13.2599]; + let (odd_mean, odd_median, odd_min, odd_max) = time::Profiler::get_statistics(&odd_data); + + assert_eq!(6.491453833333334, odd_mean); + assert_eq!(5.324, odd_median); + assert_eq!(1.234, odd_min); + assert_eq!(13.2599, odd_max); +}