Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Update to treat view transforms as native-relative

Browse source
This commit is contained in:
Manish Goregaokar 2020-05-16 21:49:44 -07:00
parent a97dcd9ad6
commit d627476893
6 changed files with 74 additions and 85 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/script/dom/xrview.rs
View file

@ -9,9 +9,10 @@ use crate::dom::bindings::root::{Dom, DomRoot};
use crate::dom::bindings::utils::create_typed_array;
use crate::dom::globalscope::GlobalScope;
use crate::dom::xrrigidtransform::XRRigidTransform;
use crate::dom::xrsession::{cast_transform, ApiViewerPose, XRSession};
use crate::dom::xrsession::{cast_transform, BaseSpace, BaseTransform, XRSession};
use crate::script_runtime::JSContext;
use dom_struct::dom_struct;
use euclid::RigidTransform3D;
use js::jsapi::{Heap, JSObject};
use std::ptr::NonNull;
use webxr_api::{ApiSpace, View};
@ -54,15 +55,9 @@ impl XRView {
view: &View<V>,
eye: XREye,
viewport_index: usize,
pose: &ApiViewerPose,
to_base: &BaseTransform,
) -> DomRoot<XRView> {
// XXXManishearth compute and cache projection matrices on the Display
// this transform is the pose of the viewer in the eye space, i.e. it is the transform
// from the viewer space to the eye space. We invert it to get the pose of the eye in the viewer space.
let offset = view.transform.inverse();
let transform = pose.pre_transform(&offset);
let transform: RigidTransform3D<f32, V, BaseSpace> = to_base.pre_transform(&view.transform);
let transform = XRRigidTransform::new(global, cast_transform(transform));
reflect_dom_object(