Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #23530 - gatoWololo:omar_update_CustomElementConstructor_type, r=cybai,jdm

Browse source 
Use TypeError instead of InvalidState for exception.

<!-- Please describe your changes on the following line: -->
Use TypeError instead of InvalidState as per https://github.com/whatwg/html/pull/4525 for making CustomElementConstructor exceptions more consistent.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23202  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes: Tests that expected failure now expect passing with correct result.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23530)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-06-08 08:15:12 -04:00 • committed by GitHub
commit d72cd4df20
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/wpt/metadata/custom-elements/upgrading/Node-cloneNode.html.ini
View file

@ -1,13 +1,3 @@
[Node-cloneNode.html]
[Node.prototype.cloneNode(false) must be able to clone as a customized built-in element when it has an inconsistent "is" attribute]
expected: FAIL
[HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself before super() call]
expected: FAIL
[Upgrading a custom element must throw TypeError when the custom element's constructor returns another element]
expected: FAIL
[HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself after super() call]
expected: FAIL

16
tests/wpt/metadata/custom-elements/upgrading/upgrading-parser-created-element.html.ini
View file

@ -1,16 +0,0 @@
[upgrading-parser-created-element.html]
[Upgrading a custom element whose constructor returns a Text node must throw]
expected: FAIL
[HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself after super() call]
expected: FAIL
[Upgrading a custom element whose constructor returns an Element must throw]
expected: FAIL
[Upgrading a custom element must throw an TypeError when the returned element is not SameValue as the upgraded element]
expected: FAIL
[HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself before super() call]
expected: FAIL