Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-25 08:10:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

implement window alert with no params

Browse source
This commit is contained in:
Abelardo E. Mendoza 2016-05-26 11:38:53 -06:00
parent 116faa7617
commit d72dbb6198
4 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/webidls/Window.webidl
View file

@ -48,8 +48,8 @@
//readonly attribute ApplicationCache applicationCache; //readonly attribute ApplicationCache applicationCache;
// user prompts // user prompts
//void alert();
void alert(DOMString message); void alert(DOMString message);
void alert();
//boolean confirm(optional DOMString message = ""); //boolean confirm(optional DOMString message = "");
//DOMString? prompt(optional DOMString message = "", optional DOMString default = ""); //DOMString? prompt(optional DOMString message = "", optional DOMString default = "");
//void print(); //void print();

5
components/script/dom/window.rs
View file

@ -430,6 +430,11 @@ pub fn base64_atob(input: DOMString) -> Fallible<DOMString> {
} }
impl WindowMethods for Window { impl WindowMethods for Window {
// https://html.spec.whatwg.org/multipage/#dom-alert
fn Alert_(&self) {
self.Alert(DOMString::new());
}
// https://html.spec.whatwg.org/multipage/#dom-alert // https://html.spec.whatwg.org/multipage/#dom-alert
fn Alert(&self, s: DOMString) { fn Alert(&self, s: DOMString) {
// Right now, just print to the console // Right now, just print to the console

12
tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsershowmodalprompt_event.html
View file

@ -28,4 +28,16 @@
})); }));
document.body.appendChild(iframe); document.body.appendChild(iframe);
}, "mozbrowsershowmodalprompt event from nested iframes triggering an alert"); }, "mozbrowsershowmodalprompt event from nested iframes triggering an alert");
async_test(function(t) {
var iframe = document.createElement("iframe");
iframe.mozbrowser = "true";
iframe.src = "mozbrowsershowmodalprompt_event_no_params_alert.html";
iframe.addEventListener("mozbrowsershowmodalprompt", t.step_func(e => {
assert_equals(e.detail.promptType, "alert");
assert_equals(e.detail.message, "");
t.done();
}));
document.body.appendChild(iframe);
}, "Dispatch mozbrowsershowmodalprompt event for alert with no parameters");
</script> </script>

6
tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsershowmodalprompt_event_no_params_alert.html Normal file
View file

@ -0,0 +1,6 @@
<html>
<body></body>
<script>
window.alert();
</script>
</html>