auto merge of #1859 : kmcallister/servo/move, r=jdm

And update `CONTRIBUTING.md`.
2025-08-04 13:10:20 +01:00 · 2014-03-07 19:19:24 -05:00 · 2014-03-07 19:19:24 -05:00 · d79c8a10cf
commit d79c8a10cf
parent 2238d81b53 07df9ba114
60 changed files with 4 additions and 3 deletions
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -26,8 +26,9 @@ follow this format, even those from core contributors.
  it, you can @-reply a reviewer asking for a review in the pull request or a
  comment, or you can ask for a review in `#servo` on `irc.mozilla.org`.
- When changing code related to the DOM, add a test to `src/test/html/content`,
+- Add tests relevant to the fixed bug or new feature.  For a DOM change this
-  either by adding it to an existing test file or creating a new one.
+  will usually be a content test; for layout, a reftest.  See our [testing
  guide](https://github.com/mozilla/servo/wiki/Testing) for more information.
 For specific git instructions, see [GitHub & Critic PR handling 101](https://github.com/mozilla/servo/wiki/Github-&-Critic-PR-handling-101).
--- a/mk/check.mk
+++ b/mk/check.mk
@ -89,7 +89,7 @@ check-ref: reftest
 .PHONY: check-content
 check-content: contenttest
 	@$(call E, check: contenttests)
-	$(Q)./contenttest --source-dir=$(S)src/test/html/content $(TESTNAME)
+	$(Q)./contenttest --source-dir=$(S)src/test/content $(TESTNAME)
 .PHONY: tidy
 tidy:
--- a/src/test/html/content/harness.js
+++ b/src/test/html/content/harness.js
--- a/src/test/html/content/test.jpg
+++ b/src/test/html/content/test.jpg
--- a/src/test/html/content/test.png
+++ b/src/test/html/content/test.png
--- a/src/test/html/content/test_DOMParser.html
+++ b/src/test/html/content/test_DOMParser.html
--- a/src/test/html/content/test_Event.html
+++ b/src/test/html/content/test_Event.html
--- a/src/test/html/content/test_MouseEvent.html
+++ b/src/test/html/content/test_MouseEvent.html
--- a/src/test/html/content/test_childnodes.html
+++ b/src/test/html/content/test_childnodes.html
--- a/src/test/html/content/test_collections.html
+++ b/src/test/html/content/test_collections.html
--- a/src/test/html/content/test_create_element.html
+++ b/src/test/html/content/test_create_element.html
--- a/src/test/html/content/test_documentElement.html
+++ b/src/test/html/content/test_documentElement.html
--- a/src/test/html/content/test_document_body.html
+++ b/src/test/html/content/test_document_body.html
--- a/src/test/html/content/test_document_characterSet.html
+++ b/src/test/html/content/test_document_characterSet.html
--- a/src/test/html/content/test_document_characterSet_default.html
+++ b/src/test/html/content/test_document_characterSet_default.html
--- a/src/test/html/content/test_document_characterSet_invalid.html
+++ b/src/test/html/content/test_document_characterSet_invalid.html
--- a/src/test/html/content/test_document_characterSet_long.html
+++ b/src/test/html/content/test_document_characterSet_long.html
--- a/src/test/html/content/test_document_characterSet_short.html
+++ b/src/test/html/content/test_document_characterSet_short.html
--- a/src/test/html/content/test_document_compatMode.html
+++ b/src/test/html/content/test_document_compatMode.html
--- a/src/test/html/content/test_document_compatMode_loose.html
+++ b/src/test/html/content/test_document_compatMode_loose.html
--- a/src/test/html/content/test_document_compatMode_strict.html
+++ b/src/test/html/content/test_document_compatMode_strict.html
--- a/src/test/html/content/test_document_contenttype.html
+++ b/src/test/html/content/test_document_contenttype.html
--- a/src/test/html/content/test_document_createProcessingInstruction.html
+++ b/src/test/html/content/test_document_createProcessingInstruction.html
--- a/src/test/html/content/test_document_doctype.html
+++ b/src/test/html/content/test_document_doctype.html
--- a/src/test/html/content/test_document_getElementById.html
+++ b/src/test/html/content/test_document_getElementById.html
--- a/src/test/html/content/test_document_getElementsByName.html
+++ b/src/test/html/content/test_document_getElementsByName.html
--- a/src/test/html/content/test_document_head.html
+++ b/src/test/html/content/test_document_head.html
--- a/src/test/html/content/test_document_implementation.html
+++ b/src/test/html/content/test_document_implementation.html
--- a/src/test/html/content/test_document_set_node_value.html
+++ b/src/test/html/content/test_document_set_node_value.html
--- a/src/test/html/content/test_document_title_nontextchildren.html
+++ b/src/test/html/content/test_document_title_nontextchildren.html
--- a/src/test/html/content/test_document_url.html
+++ b/src/test/html/content/test_document_url.html
--- a/src/test/html/content/test_element_attribute.html
+++ b/src/test/html/content/test_element_attribute.html
--- a/src/test/html/content/test_element_attributes.html
+++ b/src/test/html/content/test_element_attributes.html
--- a/src/test/html/content/test_empty_clientrect.html
+++ b/src/test/html/content/test_empty_clientrect.html
--- a/src/test/html/content/test_event_dispatch.html
+++ b/src/test/html/content/test_event_dispatch.html
--- a/src/test/html/content/test_event_dispatch_dynamic.html
+++ b/src/test/html/content/test_event_dispatch_dynamic.html
--- a/src/test/html/content/test_event_dispatch_order.html
+++ b/src/test/html/content/test_event_dispatch_order.html
--- a/src/test/html/content/test_event_listener.html
+++ b/src/test/html/content/test_event_listener.html
--- a/src/test/html/content/test_exception.html
+++ b/src/test/html/content/test_exception.html
--- a/src/test/html/content/test_getBoundingClientRect.html
+++ b/src/test/html/content/test_getBoundingClientRect.html
--- a/src/test/html/content/test_getElementsByTagName.html
+++ b/src/test/html/content/test_getElementsByTagName.html
--- a/src/test/html/content/test_global.html
+++ b/src/test/html/content/test_global.html
--- a/src/test/html/content/test_htmlcollection.html
+++ b/src/test/html/content/test_htmlcollection.html
--- a/src/test/html/content/test_img_width_height.html
+++ b/src/test/html/content/test_img_width_height.html
--- a/src/test/html/content/test_innerHTML.html
+++ b/src/test/html/content/test_innerHTML.html
--- a/src/test/html/content/test_load_event.html
+++ b/src/test/html/content/test_load_event.html
--- a/src/test/html/content/test_mainelement.html
+++ b/src/test/html/content/test_mainelement.html
--- a/src/test/html/content/test_navigator.html
+++ b/src/test/html/content/test_navigator.html
--- a/src/test/html/content/test_node_contains.html
+++ b/src/test/html/content/test_node_contains.html
--- a/src/test/html/content/test_node_insertBefore.html
+++ b/src/test/html/content/test_node_insertBefore.html
--- a/src/test/html/content/test_node_isEqualNode.html
+++ b/src/test/html/content/test_node_isEqualNode.html
--- a/src/test/html/content/test_node_replaceChild.html
+++ b/src/test/html/content/test_node_replaceChild.html
--- a/src/test/html/content/test_parentnodes.html
+++ b/src/test/html/content/test_parentnodes.html
--- a/src/test/html/content/test_prototypes.html
+++ b/src/test/html/content/test_prototypes.html
--- a/src/test/html/content/test_proxy_setter.html
+++ b/src/test/html/content/test_proxy_setter.html
--- a/src/test/html/content/test_script_src_attribute.html
+++ b/src/test/html/content/test_script_src_attribute.html
--- a/src/test/html/content/test_textcontent.html
+++ b/src/test/html/content/test_textcontent.html
--- a/src/test/html/content/test_title.html
+++ b/src/test/html/content/test_title.html
--- a/src/test/html/content/test_union.html
+++ b/src/test/html/content/test_union.html
--- a/src/test/html/content/test_window.html
+++ b/src/test/html/content/test_window.html