From d7e121961fa0b497d97545728ea3eaa73970ee00 Mon Sep 17 00:00:00 2001 From: Bobby Holley Date: Sat, 22 Apr 2017 13:12:55 -0700 Subject: [PATCH] Disable the style sharing cache on opt builds to avoid regressing Talos by matching too many revalidation selectors. MozReview-Commit-ID: 10qSho1gXjw --- components/style/context.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components/style/context.rs b/components/style/context.rs index bf12841f8a4..01043637a0d 100644 --- a/components/style/context.rs +++ b/components/style/context.rs @@ -94,7 +94,11 @@ impl Default for StyleSystemOptions { #[cfg(feature = "gecko")] fn default() -> Self { StyleSystemOptions { - disable_style_sharing_cache: get_env("DISABLE_STYLE_SHARING_CACHE"), + disable_style_sharing_cache: + // Disable the style sharing cache on opt builds until + // bug 1358693 is fixed, but keep it on debug builds to make + // sure we don't introduce correctness bugs. + if cfg!(debug_assertions) { get_env("DISABLE_STYLE_SHARING_CACHE") } else { true }, dump_style_statistics: get_env("DUMP_STYLE_STATISTICS"), } }