Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #21064 - tigercosmos:yyy, r=jdm

Browse source 
Let the popstate and hashchange events not bubble

<!-- Please describe your changes on the following line: -->
fix #21063

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21064)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-06-18 10:41:18 -04:00 • committed by GitHub
commit d843a66300
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/history.rs
View file

@ -129,7 +129,7 @@ impl History {
let event = HashChangeEvent::new( let event = HashChangeEvent::new(
&self.window, &self.window,
atom!("hashchange"), atom!("hashchange"),
true, false,
false, false,
old_url.into_string(), old_url.into_string(),
url.into_string()); url.into_string());

2
components/script/dom/popstateevent.rs
View file

@ -71,7 +71,7 @@ impl PopStateEvent {
pub fn dispatch_jsval(target: &EventTarget, pub fn dispatch_jsval(target: &EventTarget,
window: &Window, window: &Window,
state: HandleValue) { state: HandleValue) {
let event = PopStateEvent::new(window, atom!("popstate"), true, false, state); let event = PopStateEvent::new(window, atom!("popstate"), false, false, state);
event.upcast::<Event>().fire(target); event.upcast::<Event>().fire(target);
} }
} }

4
tests/wpt/metadata/html/browsers/browsing-the-web/history-traversal/popstate_event.html.ini
View file

@ -1,4 +0,0 @@
[popstate_event.html]
[Queue a task to fire popstate event]
expected: FAIL