mirror of
https://github.com/servo/servo.git
synced 2025-06-08 08:33:26 +00:00
Remove deprecated 'creator' WebIDL attribute
According to @Ms2ger, the 'creator' attribute was merged into 'setter'
This commit is contained in:
parent
6c6c6663ab
commit
d8da5c20f6
9 changed files with 5 additions and 22 deletions
|
@ -4156,8 +4156,6 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
|
||||||
|
|
||||||
indexedSetter = self.descriptor.operations['IndexedSetter']
|
indexedSetter = self.descriptor.operations['IndexedSetter']
|
||||||
if indexedSetter:
|
if indexedSetter:
|
||||||
if self.descriptor.operations['IndexedCreator'] != indexedSetter:
|
|
||||||
raise TypeError("Can't handle creator that's different from the setter")
|
|
||||||
set += ("let index = get_array_index_from_id(cx, id);\n" +
|
set += ("let index = get_array_index_from_id(cx, id);\n" +
|
||||||
"if let Some(index) = index {\n" +
|
"if let Some(index) = index {\n" +
|
||||||
" let this = UnwrapProxy(proxy);\n" +
|
" let this = UnwrapProxy(proxy);\n" +
|
||||||
|
@ -4173,8 +4171,6 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod):
|
||||||
|
|
||||||
namedSetter = self.descriptor.operations['NamedSetter']
|
namedSetter = self.descriptor.operations['NamedSetter']
|
||||||
if namedSetter:
|
if namedSetter:
|
||||||
if self.descriptor.operations['NamedCreator'] != namedSetter:
|
|
||||||
raise TypeError("Can't handle creator that's different from the setter")
|
|
||||||
set += ("if RUST_JSID_IS_STRING(id) != 0 {\n" +
|
set += ("if RUST_JSID_IS_STRING(id) != 0 {\n" +
|
||||||
CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +
|
CGIndenter(CGProxyNamedSetter(self.descriptor)).define() +
|
||||||
" (*opresult).code_ = 0; /* SpecialCodes::OkCode */\n" +
|
" (*opresult).code_ = 0; /* SpecialCodes::OkCode */\n" +
|
||||||
|
|
|
@ -179,11 +179,9 @@ class Descriptor(DescriptorProvider):
|
||||||
self.operations = {
|
self.operations = {
|
||||||
'IndexedGetter': None,
|
'IndexedGetter': None,
|
||||||
'IndexedSetter': None,
|
'IndexedSetter': None,
|
||||||
'IndexedCreator': None,
|
|
||||||
'IndexedDeleter': None,
|
'IndexedDeleter': None,
|
||||||
'NamedGetter': None,
|
'NamedGetter': None,
|
||||||
'NamedSetter': None,
|
'NamedSetter': None,
|
||||||
'NamedCreator': None,
|
|
||||||
'NamedDeleter': None,
|
'NamedDeleter': None,
|
||||||
'Stringifier': None,
|
'Stringifier': None,
|
||||||
}
|
}
|
||||||
|
|
|
@ -35,11 +35,6 @@ impl DOMStringMap {
|
||||||
|
|
||||||
// https://html.spec.whatwg.org/#domstringmap
|
// https://html.spec.whatwg.org/#domstringmap
|
||||||
impl DOMStringMapMethods for DOMStringMap {
|
impl DOMStringMapMethods for DOMStringMap {
|
||||||
// https://html.spec.whatwg.org/multipage/#dom-domstringmap-additem
|
|
||||||
fn NamedCreator(&self, name: DOMString, value: DOMString) -> ErrorResult {
|
|
||||||
self.NamedSetter(name, value)
|
|
||||||
}
|
|
||||||
|
|
||||||
// https://html.spec.whatwg.org/multipage/#dom-domstringmap-removeitem
|
// https://html.spec.whatwg.org/multipage/#dom-domstringmap-removeitem
|
||||||
fn NamedDeleter(&self, name: DOMString) {
|
fn NamedDeleter(&self, name: DOMString) {
|
||||||
let element = self.element.root();
|
let element = self.element.root();
|
||||||
|
|
|
@ -131,10 +131,6 @@ impl StorageMethods for Storage {
|
||||||
self.SetItem(name, value);
|
self.SetItem(name, value);
|
||||||
}
|
}
|
||||||
|
|
||||||
fn NamedCreator(&self, name: DOMString, value: DOMString) {
|
|
||||||
self.SetItem(name, value);
|
|
||||||
}
|
|
||||||
|
|
||||||
fn NamedDeleter(&self, name: DOMString) {
|
fn NamedDeleter(&self, name: DOMString) {
|
||||||
self.RemoveItem(name);
|
self.RemoveItem(name);
|
||||||
}
|
}
|
||||||
|
|
|
@ -23,12 +23,10 @@ impl TestBindingProxyMethods for TestBindingProxy {
|
||||||
fn SetItem(&self, _: u32, _: DOMString) -> () {}
|
fn SetItem(&self, _: u32, _: DOMString) -> () {}
|
||||||
fn RemoveItem(&self, _: DOMString) -> () {}
|
fn RemoveItem(&self, _: DOMString) -> () {}
|
||||||
fn Stringifier(&self) -> DOMString { "".to_owned() }
|
fn Stringifier(&self) -> DOMString { "".to_owned() }
|
||||||
fn NamedCreator(&self, _: DOMString, _: DOMString) -> () {}
|
|
||||||
fn IndexedGetter(&self, _: u32, _: &mut bool) -> DOMString { "".to_owned() }
|
fn IndexedGetter(&self, _: u32, _: &mut bool) -> DOMString { "".to_owned() }
|
||||||
fn NamedDeleter(&self, _: DOMString) -> () {}
|
fn NamedDeleter(&self, _: DOMString) -> () {}
|
||||||
fn IndexedSetter(&self, _: u32, _: DOMString) -> () {}
|
fn IndexedSetter(&self, _: u32, _: DOMString) -> () {}
|
||||||
fn NamedSetter(&self, _: DOMString, _: DOMString) -> () {}
|
fn NamedSetter(&self, _: DOMString, _: DOMString) -> () {}
|
||||||
fn IndexedCreator(&self, _: u32, _: DOMString) -> () {}
|
|
||||||
fn NamedGetter(&self, _: DOMString, _: &mut bool) -> DOMString { "".to_owned() }
|
fn NamedGetter(&self, _: DOMString, _: &mut bool) -> DOMString { "".to_owned() }
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -8,6 +8,6 @@
|
||||||
interface DOMStringMap {
|
interface DOMStringMap {
|
||||||
getter DOMString (DOMString name);
|
getter DOMString (DOMString name);
|
||||||
[Throws]
|
[Throws]
|
||||||
setter creator void (DOMString name, DOMString value);
|
setter void (DOMString name, DOMString value);
|
||||||
deleter void (DOMString name);
|
deleter void (DOMString name);
|
||||||
};
|
};
|
||||||
|
|
|
@ -23,7 +23,7 @@ interface HTMLSelectElement : HTMLElement {
|
||||||
void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
|
void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
|
||||||
//void remove(); // ChildNode overload
|
//void remove(); // ChildNode overload
|
||||||
//void remove(long index);
|
//void remove(long index);
|
||||||
//setter creator void (unsigned long index, HTMLOptionElement? option);
|
//setter void (unsigned long index, HTMLOptionElement? option);
|
||||||
|
|
||||||
//readonly attribute HTMLCollection selectedOptions;
|
//readonly attribute HTMLCollection selectedOptions;
|
||||||
// attribute long selectedIndex;
|
// attribute long selectedIndex;
|
||||||
|
|
|
@ -16,7 +16,7 @@ interface Storage {
|
||||||
|
|
||||||
getter DOMString? getItem(DOMString name);
|
getter DOMString? getItem(DOMString name);
|
||||||
|
|
||||||
setter creator void setItem(DOMString name, DOMString value);
|
setter void setItem(DOMString name, DOMString value);
|
||||||
|
|
||||||
deleter void removeItem(DOMString name);
|
deleter void removeItem(DOMString name);
|
||||||
|
|
||||||
|
|
|
@ -17,11 +17,11 @@ interface TestBindingProxy : TestBinding {
|
||||||
|
|
||||||
getter DOMString getNamedItem(DOMString item_name);
|
getter DOMString getNamedItem(DOMString item_name);
|
||||||
|
|
||||||
setter creator void setNamedItem(DOMString item_name, DOMString value);
|
setter void setNamedItem(DOMString item_name, DOMString value);
|
||||||
|
|
||||||
getter DOMString getItem(unsigned long index);
|
getter DOMString getItem(unsigned long index);
|
||||||
|
|
||||||
setter creator void setItem(unsigned long index, DOMString value);
|
setter void setItem(unsigned long index, DOMString value);
|
||||||
|
|
||||||
deleter void removeItem(DOMString name);
|
deleter void removeItem(DOMString name);
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue