Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Fix serialization of @namespace rule.

Browse source 
This code comes from:

https://hg.mozilla.org/mozilla-central/rev/2418cfba72c33c5623f6fb4c243c5203819c8240

I audited other callers of write_str, they seem ok.

Differential Revision: https://phabricator.services.mozilla.com/D54601
This commit is contained in:
Emilio Cobos Álvarez 2019-11-25 23:21:20 +00:00
parent 7cd59da2a0
commit d954f516e9
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/style/stylesheets/namespace_rule.rs
View file

@ -7,8 +7,9 @@
use crate::shared_lock::{SharedRwLockReadGuard, ToCssWithGuard}; use crate::shared_lock::{SharedRwLockReadGuard, ToCssWithGuard};
use crate::str::CssStringWriter; use crate::str::CssStringWriter;
use crate::{Namespace, Prefix}; use crate::{Namespace, Prefix};
use cssparser::SourceLocation; use cssparser::{self, SourceLocation};
use std::fmt::{self, Write}; use std::fmt::{self, Write};
use style_traits::{CssWriter, ToCss};
/// A `@namespace` rule. /// A `@namespace` rule.
#[derive(Clone, Debug, PartialEq, ToShmem)] #[derive(Clone, Debug, PartialEq, ToShmem)]
@ -27,13 +28,12 @@ impl ToCssWithGuard for NamespaceRule {
fn to_css(&self, _guard: &SharedRwLockReadGuard, dest: &mut CssStringWriter) -> fmt::Result { fn to_css(&self, _guard: &SharedRwLockReadGuard, dest: &mut CssStringWriter) -> fmt::Result {
dest.write_str("@namespace ")?; dest.write_str("@namespace ")?;
if let Some(ref prefix) = self.prefix { if let Some(ref prefix) = self.prefix {
dest.write_str(&*prefix.to_string())?; let prefix = prefix.to_string();
cssparser::serialize_identifier(&prefix, dest)?;
dest.write_str(" ")?; dest.write_str(" ")?;
} }
dest.write_str("url(")?;
// FIXME(emilio): Pretty sure this needs some escaping, or something? self.url.to_string().to_css(&mut CssWriter::new(dest))?;
dest.write_str("url(\"")?; dest.write_str(");")
dest.write_str(&*self.url.to_string())?;
dest.write_str("\");")
} }
} }