From da609076c32abcc3d3267cb663dbae861b2dfba7 Mon Sep 17 00:00:00 2001 From: Samson <16504129+sagudev@users.noreply.github.com> Date: Tue, 12 Mar 2024 14:45:36 +0100 Subject: [PATCH] Add wpt-report output & continue if filtering failed (#31616) * Add wpt-report artifact * Merge logs (filtered) are last so we still get other logs merged * fixup * it's wptreport.json * wptreport in full artifact * Apply suggestions from code review Co-authored-by: Martin Robinson --------- Co-authored-by: Martin Robinson --- .github/workflows/linux-wpt.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/linux-wpt.yml b/.github/workflows/linux-wpt.yml index 85b8a39ad96..1142f357962 100644 --- a/.github/workflows/linux-wpt.yml +++ b/.github/workflows/linux-wpt.yml @@ -70,7 +70,8 @@ jobs: ${{ inputs.wpt-tests-to-run }} \ --${{ inputs.profile }} --processes $(nproc) --timeout-multiplier 2 \ --total-chunks ${{ env.max_chunk_id }} --this-chunk ${{ matrix.chunk_id }} \ - --log-raw wpt-full-logs/linux-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.log \ + --log-raw wpt-full-logs/linux-${{ inputs.wpt-layout }}/raw/${{ matrix.chunk_id }}.log \ + --log-wptreport wpt-full-logs/linux-${{ inputs.wpt-layout }}/wptreport/${{ matrix.chunk_id }}.json \ --log-raw-unexpected wpt-filtered-logs/linux-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.log \ --filter-intermittents wpt-filtered-logs/linux-${{ inputs.wpt-layout }}/${{ matrix.chunk_id }}.json env: @@ -94,18 +95,19 @@ jobs: if: ${{ always() }} needs: linux-wpt steps: - - name: Merge logs (filtered) - uses: actions/upload-artifact/merge@v4 - with: - name: wpt-filtered-logs-linux-${{ inputs.wpt-layout }} - pattern: wpt-filtered-logs-linux-${{ inputs.wpt-layout }}-* - delete-merged: true - name: Merge logs (full) uses: actions/upload-artifact/merge@v4 with: name: wpt-full-logs-linux-${{ inputs.wpt-layout }} pattern: wpt-full-logs-linux-${{ inputs.wpt-layout }}-* delete-merged: true + # This job needs to be last. If no filtered results were uploaded, it will fail, but we want to merge other archives in that case. + - name: Merge logs (filtered) + uses: actions/upload-artifact/merge@v4 + with: + name: wpt-filtered-logs-linux-${{ inputs.wpt-layout }} + pattern: wpt-filtered-logs-linux-${{ inputs.wpt-layout }}-* + delete-merged: true - uses: actions/checkout@v4 if: ${{ !cancelled() && !inputs.wpt-sync-from-upstream }} - uses: actions/download-artifact@v4