Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-09 15:35:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

Avoid endless testrunner restart loops.

Browse source 
If the first test selected by a testrunner thread had a CRASH expectation,
the testrunner believed that it needed to restart and would never actually
get around to running the test.
This commit is contained in:
Josh Matthews 2017-10-02 18:12:33 +02:00 • committed by Ms2ger
parent c1c60beda1
commit da8677221e
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py
View file

@ -154,6 +154,7 @@ class BrowserManager(object):
self.browser = browser self.browser = browser
self.no_timeout = no_timeout self.no_timeout = no_timeout
self.browser_settings = None self.browser_settings = None
self.last_test = None
self.started = False self.started = False
@ -163,8 +164,9 @@ class BrowserManager(object):
browser_settings = self.browser.settings(test) browser_settings = self.browser.settings(test)
restart_required = ((self.browser_settings is not None and restart_required = ((self.browser_settings is not None and
self.browser_settings != browser_settings) or self.browser_settings != browser_settings) or
test.expected() == "CRASH") (self.last_test != test and test.expected() == "CRASH"))
self.browser_settings = browser_settings self.browser_settings = browser_settings
self.last_test = test
return restart_required return restart_required
def init(self): def init(self):