Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-01 00:59:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement shadow dom slots (#35013)

Browse source 
* Implement slot-related algorithms

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Hook up slot elements to DOM creation logic

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Set a slot assignment mode for servo-internal shadow roots

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Assign slots when a slottable's slot attribute changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Properly compute slot name

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* ./mach test-tidy

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update <slot> name when name attribute changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Implement fast path for Node::assign_slottables_for_a_tree

assign_slottables_for_a_tree traverses all descendants of the node
and is potentially very expensive. If the node is not a shadow root
then assigning slottables to it won't have any effect, so we
take a fast path out.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Move slottable data into ElementRareData

This shrinks all element descendants back to their
original size.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Address review comments

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-01-19 15:05:05 +01:00 • committed by GitHub
parent 8bb50fa3c9
commit dabe162d44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
31 changed files with 758 additions and 355 deletions
Download patch file Download diff file Expand all files Collapse all files

57
tests/wpt/meta/html/dom/idlharness.https.html.ini vendored
View file

@ -7858,63 +7858,6 @@
[HTMLTemplateElement interface: document.createElement("template") must inherit property "shadowRootSerializable" with the proper type]
expected: FAIL
[HTMLSlotElement interface: existence and properties of interface object]
expected: FAIL
[HTMLSlotElement interface object length]
expected: FAIL
[HTMLSlotElement interface object name]
expected: FAIL
[HTMLSlotElement interface: existence and properties of interface prototype object]
expected: FAIL
[HTMLSlotElement interface: existence and properties of interface prototype object's "constructor" property]
expected: FAIL
[HTMLSlotElement interface: existence and properties of interface prototype object's @@unscopables property]
expected: FAIL
[HTMLSlotElement interface: attribute name]
expected: FAIL
[HTMLSlotElement interface: operation assignedNodes(optional AssignedNodesOptions)]
expected: FAIL
[HTMLSlotElement interface: operation assignedElements(optional AssignedNodesOptions)]
expected: FAIL
[HTMLSlotElement interface: operation assign((Element or Text)...)]
expected: FAIL
[HTMLSlotElement must be primary interface of document.createElement("slot")]
expected: FAIL
[Stringification of document.createElement("slot")]
expected: FAIL
[HTMLSlotElement interface: document.createElement("slot") must inherit property "name" with the proper type]
expected: FAIL
[HTMLSlotElement interface: document.createElement("slot") must inherit property "assignedNodes(optional AssignedNodesOptions)" with the proper type]
expected: FAIL
[HTMLSlotElement interface: calling assignedNodes(optional AssignedNodesOptions) on document.createElement("slot") with too few arguments must throw TypeError]
expected: FAIL
[HTMLSlotElement interface: document.createElement("slot") must inherit property "assignedElements(optional AssignedNodesOptions)" with the proper type]
expected: FAIL
[HTMLSlotElement interface: calling assignedElements(optional AssignedNodesOptions) on document.createElement("slot") with too few arguments must throw TypeError]
expected: FAIL
[HTMLSlotElement interface: document.createElement("slot") must inherit property "assign((Element or Text)...)" with the proper type]
expected: FAIL
[HTMLSlotElement interface: calling assign((Element or Text)...) on document.createElement("slot") with too few arguments must throw TypeError]
expected: FAIL
[HTMLMarqueeElement interface: existence and properties of interface object]
expected: FAIL