Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement shadow dom slots (#35013)

Browse source 
* Implement slot-related algorithms

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Hook up slot elements to DOM creation logic

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Set a slot assignment mode for servo-internal shadow roots

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Assign slots when a slottable's slot attribute changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Properly compute slot name

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* ./mach test-tidy

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update <slot> name when name attribute changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Implement fast path for Node::assign_slottables_for_a_tree

assign_slottables_for_a_tree traverses all descendants of the node
and is potentially very expensive. If the node is not a shadow root
then assigning slottables to it won't have any effect, so we
take a fast path out.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Move slottable data into ElementRareData

This shrinks all element descendants back to their
original size.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Address review comments

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-01-19 15:05:05 +01:00 • committed by GitHub
parent 8bb50fa3c9
commit dabe162d44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
31 changed files with 758 additions and 355 deletions
Download patch file Download diff file Expand all files Collapse all files

114
tests/wpt/meta/html/dom/reflection-misc.html.ini vendored
View file

@ -1073,120 +1073,6 @@
[slot.tabIndex: IDL set to -2147483648]
expected: FAIL
[slot.name: typeof IDL attribute]
expected: FAIL
[slot.name: IDL get with DOM attribute unset]
expected: FAIL
[slot.name: setAttribute() to ""]
expected: FAIL
[slot.name: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo "]
expected: FAIL
[slot.name: setAttribute() to undefined]
expected: FAIL
[slot.name: setAttribute() to 7]
expected: FAIL
[slot.name: setAttribute() to 1.5]
expected: FAIL
[slot.name: setAttribute() to "5%"]
expected: FAIL
[slot.name: setAttribute() to "+100"]
expected: FAIL
[slot.name: setAttribute() to ".5"]
expected: FAIL
[slot.name: setAttribute() to true]
expected: FAIL
[slot.name: setAttribute() to false]
expected: FAIL
[slot.name: setAttribute() to object "[object Object\]"]
expected: FAIL
[slot.name: setAttribute() to NaN]
expected: FAIL
[slot.name: setAttribute() to Infinity]
expected: FAIL
[slot.name: setAttribute() to -Infinity]
expected: FAIL
[slot.name: setAttribute() to "\\0"]
expected: FAIL
[slot.name: setAttribute() to null]
expected: FAIL
[slot.name: setAttribute() to object "test-toString"]
expected: FAIL
[slot.name: setAttribute() to object "test-valueOf"]
expected: FAIL
[slot.name: IDL set to ""]
expected: FAIL
[slot.name: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo "]
expected: FAIL
[slot.name: IDL set to undefined]
expected: FAIL
[slot.name: IDL set to 7]
expected: FAIL
[slot.name: IDL set to 1.5]
expected: FAIL
[slot.name: IDL set to "5%"]
expected: FAIL
[slot.name: IDL set to "+100"]
expected: FAIL
[slot.name: IDL set to ".5"]
expected: FAIL
[slot.name: IDL set to true]
expected: FAIL
[slot.name: IDL set to false]
expected: FAIL
[slot.name: IDL set to object "[object Object\]"]
expected: FAIL
[slot.name: IDL set to NaN]
expected: FAIL
[slot.name: IDL set to Infinity]
expected: FAIL
[slot.name: IDL set to -Infinity]
expected: FAIL
[slot.name: IDL set to "\\0"]
expected: FAIL
[slot.name: IDL set to null]
expected: FAIL
[slot.name: IDL set to object "test-toString"]
expected: FAIL
[slot.name: IDL set to object "test-valueOf"]
expected: FAIL
[ins.accessKey: typeof IDL attribute]
expected: FAIL