Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-01 09:09:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement shadow dom slots (#35013)

Browse source 
* Implement slot-related algorithms

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Hook up slot elements to DOM creation logic

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Set a slot assignment mode for servo-internal shadow roots

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Assign slots when a slottable's slot attribute changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Properly compute slot name

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* ./mach test-tidy

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update <slot> name when name attribute changes

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Implement fast path for Node::assign_slottables_for_a_tree

assign_slottables_for_a_tree traverses all descendants of the node
and is potentially very expensive. If the node is not a shadow root
then assigning slottables to it won't have any effect, so we
take a fast path out.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Move slottable data into ElementRareData

This shrinks all element descendants back to their
original size.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Address review comments

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-01-19 15:05:05 +01:00 • committed by GitHub
parent 8bb50fa3c9
commit dabe162d44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
31 changed files with 758 additions and 355 deletions
Download patch file Download diff file Expand all files Collapse all files

27
tests/wpt/meta/shadow-dom/imperative-slot-api.html.ini vendored
View file

@ -1,22 +1,4 @@
[imperative-slot-api.html]
[attachShadow can take slotAssignment parameter.]
expected: FAIL
[slot.attach() should take variadic not sequence.]
expected: FAIL
[Imperative slot API can assign nodes in manual slot assignment.]
expected: FAIL
[Order of slottables is preserved in manual slot assignment.]
expected: FAIL
[Previously assigned slottable is moved to new slot when it's reassigned.]
expected: FAIL
[Order and assignment of nodes are preserved during multiple assignment in a row.]
expected: FAIL
[Assigning invalid nodes should be allowed.]
expected: FAIL
@ -29,15 +11,6 @@
[Appending slottable to different host, it loses slot assignment. It can be re-assigned within a new host.]
expected: FAIL
[Previously assigned node should not be assigned if slot moved to a new shadow root. The node is re-assigned when moved back.]
expected: FAIL
[Assignment with the same node in parameters should be ignored, first one wins.]
expected: FAIL
[Removing a slot from DOM resets its slottable's slot assignment.]
expected: FAIL
[Nodes can be assigned even if slots or nodes aren't in the same tree.]
expected: FAIL