From dacd21ac5240bd8f63b0487185bd06fdf1085d9f Mon Sep 17 00:00:00 2001 From: Med0paW Date: Fri, 5 Dec 2014 10:34:25 -0800 Subject: [PATCH] Issue 4253 - Setting timeout on a sync XHR should throw InvalidAccessErr --- components/script/dom/xmlhttprequest.rs | 2 +- tests/wpt/metadata/XMLHttpRequest/timeout-sync.htm.ini | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 tests/wpt/metadata/XMLHttpRequest/timeout-sync.htm.ini diff --git a/components/script/dom/xmlhttprequest.rs b/components/script/dom/xmlhttprequest.rs index 7d2d31efebb..530b262a75f 100644 --- a/components/script/dom/xmlhttprequest.rs +++ b/components/script/dom/xmlhttprequest.rs @@ -460,7 +460,7 @@ impl<'a> XMLHttpRequestMethods for JSRef<'a, XMLHttpRequest> { fn SetTimeout(self, timeout: u32) -> ErrorResult { if self.sync.get() { // FIXME: Not valid for a worker environment - Err(InvalidState) + Err(InvalidAccess) } else { self.timeout.set(timeout); if self.send_flag.get() { diff --git a/tests/wpt/metadata/XMLHttpRequest/timeout-sync.htm.ini b/tests/wpt/metadata/XMLHttpRequest/timeout-sync.htm.ini deleted file mode 100644 index 24f620e2069..00000000000 --- a/tests/wpt/metadata/XMLHttpRequest/timeout-sync.htm.ini +++ /dev/null @@ -1,5 +0,0 @@ -[timeout-sync.htm] - type: testharness - [setting timeout attribute on sync request] - expected: FAIL -