diff --git a/components/style/attr.rs b/components/style/attr.rs index 16173d64057..926d52cd5f8 100644 --- a/components/style/attr.rs +++ b/components/style/attr.rs @@ -543,7 +543,7 @@ pub fn parse_legacy_color(mut input: &str) -> Result { /// Parses a [dimension value][dim]. If unparseable, `Auto` is returned. /// /// [dim]: https://html.spec.whatwg.org/multipage/#rules-for-parsing-dimension-values -// TODO: this function can be rewritten to return Result +// TODO: this function can be rewritten to return Result pub fn parse_length(mut value: &str) -> LengthOrPercentageOrAuto { // Steps 1 & 2 are not relevant diff --git a/components/style/gecko/conversions.rs b/components/style/gecko/conversions.rs index 08d0557f896..7e896b37569 100644 --- a/components/style/gecko/conversions.rs +++ b/components/style/gecko/conversions.rs @@ -21,8 +21,8 @@ use crate::values::computed::image::LineDirection; use crate::values::computed::transform::Matrix3D; use crate::values::computed::url::ComputedImageUrl; use crate::values::computed::{Angle, Gradient, Image}; -use crate::values::computed::{Integer, LengthOrPercentage}; -use crate::values::computed::{LengthOrPercentageOrAuto, NonNegativeLengthOrPercentageOrAuto}; +use crate::values::computed::{Integer, LengthPercentage}; +use crate::values::computed::{LengthPercentageOrAuto, NonNegativeLengthPercentageOrAuto}; use crate::values::computed::{Percentage, TextAlign}; use crate::values::generics::box_::VerticalAlign; use crate::values::generics::grid::{TrackListValue, TrackSize}; @@ -33,8 +33,8 @@ use app_units::Au; use std::f32::consts::PI; use style_traits::values::specified::AllowedNumericType; -impl From for nsStyleCoord_CalcValue { - fn from(other: LengthOrPercentage) -> nsStyleCoord_CalcValue { +impl From for nsStyleCoord_CalcValue { + fn from(other: LengthPercentage) -> nsStyleCoord_CalcValue { let has_percentage = other.percentage.is_some(); nsStyleCoord_CalcValue { mLength: other.unclamped_length().to_i32_au(), @@ -44,8 +44,8 @@ impl From for nsStyleCoord_CalcValue { } } -impl From for LengthOrPercentage { - fn from(other: nsStyleCoord_CalcValue) -> LengthOrPercentage { +impl From for LengthPercentage { + fn from(other: nsStyleCoord_CalcValue) -> LengthPercentage { let percentage = if other.mHasPercent { Some(Percentage(other.mPercent)) } else { @@ -60,28 +60,28 @@ impl From for LengthOrPercentage { } } -impl LengthOrPercentageOrAuto { +impl LengthPercentageOrAuto { /// Convert this value in an appropriate `nsStyleCoord::CalcValue`. pub fn to_calc_value(&self) -> Option { match *self { - LengthOrPercentageOrAuto::LengthOrPercentage(len) => Some(From::from(len)), - LengthOrPercentageOrAuto::Auto => None, + LengthPercentageOrAuto::LengthPercentage(len) => Some(From::from(len)), + LengthPercentageOrAuto::Auto => None, } } } -impl From for LengthOrPercentageOrAuto { - fn from(other: nsStyleCoord_CalcValue) -> LengthOrPercentageOrAuto { - LengthOrPercentageOrAuto::LengthOrPercentage(LengthOrPercentage::from(other)) +impl From for LengthPercentageOrAuto { + fn from(other: nsStyleCoord_CalcValue) -> LengthPercentageOrAuto { + LengthPercentageOrAuto::LengthPercentage(LengthPercentage::from(other)) } } // FIXME(emilio): A lot of these impl From should probably become explicit or // disappear as we move more stuff to cbindgen. -impl From for NonNegativeLengthOrPercentageOrAuto { +impl From for NonNegativeLengthPercentageOrAuto { fn from(other: nsStyleCoord_CalcValue) -> Self { NonNegative( - LengthOrPercentageOrAuto::LengthOrPercentage(LengthOrPercentage::with_clamping_mode( + LengthPercentageOrAuto::LengthPercentage(LengthPercentage::with_clamping_mode( Au(other.mLength).into(), if other.mHasPercent { Some(Percentage(other.mPercent)) @@ -101,7 +101,7 @@ impl From for CoordDataValue { } } -fn line_direction(horizontal: LengthOrPercentage, vertical: LengthOrPercentage) -> LineDirection { +fn line_direction(horizontal: LengthPercentage, vertical: LengthPercentage) -> LineDirection { use crate::values::computed::position::Position; use crate::values::specified::position::{X, Y}; @@ -467,8 +467,8 @@ impl nsStyleImage { .as_ref() .unwrap(); let angle = Angle::from_gecko_style_coord(&gecko_gradient.mAngle); - let horizontal_style = LengthOrPercentage::from_gecko_style_coord(&gecko_gradient.mBgPosX); - let vertical_style = LengthOrPercentage::from_gecko_style_coord(&gecko_gradient.mBgPosY); + let horizontal_style = LengthPercentage::from_gecko_style_coord(&gecko_gradient.mBgPosX); + let vertical_style = LengthPercentage::from_gecko_style_coord(&gecko_gradient.mBgPosY); let kind = match gecko_gradient.mShape as u32 { structs::NS_STYLE_GRADIENT_SHAPE_LINEAR => { @@ -529,20 +529,20 @@ impl nsStyleImage { structs::NS_STYLE_GRADIENT_SHAPE_ELLIPTICAL => { let length_percentage_keyword = match gecko_gradient.mSize as u32 { structs::NS_STYLE_GRADIENT_SIZE_EXPLICIT_SIZE => match ( - LengthOrPercentage::from_gecko_style_coord( + LengthPercentage::from_gecko_style_coord( &gecko_gradient.mRadiusX, ), - LengthOrPercentage::from_gecko_style_coord( + LengthPercentage::from_gecko_style_coord( &gecko_gradient.mRadiusY, ), ) { (Some(x), Some(y)) => Ellipse::Radii(x, y), _ => { debug_assert!(false, - "mRadiusX, mRadiusY could not convert to LengthOrPercentage"); + "mRadiusX, mRadiusY could not convert to LengthPercentage"); Ellipse::Radii( - LengthOrPercentage::zero(), - LengthOrPercentage::zero(), + LengthPercentage::zero(), + LengthPercentage::zero(), ) }, }, @@ -561,11 +561,11 @@ impl nsStyleImage { _ => { debug_assert!( false, - "mRadiusX, mRadiusY could not convert to LengthOrPercentage" + "mRadiusX, mRadiusY could not convert to LengthPercentage" ); Position { - horizontal: LengthOrPercentage::zero(), - vertical: LengthOrPercentage::zero(), + horizontal: LengthPercentage::zero(), + vertical: LengthPercentage::zero(), } }, }; @@ -580,13 +580,13 @@ impl nsStyleImage { .map(|ref stop| { if stop.mIsInterpolationHint { GradientItem::InterpolationHint( - LengthOrPercentage::from_gecko_style_coord(&stop.mLocation) - .expect("mLocation could not convert to LengthOrPercentage"), + LengthPercentage::from_gecko_style_coord(&stop.mLocation) + .expect("mLocation could not convert to LengthPercentage"), ) } else { GradientItem::ColorStop(ColorStop { color: stop.mColor.into(), - position: LengthOrPercentage::from_gecko_style_coord(&stop.mLocation), + position: LengthPercentage::from_gecko_style_coord(&stop.mLocation), }) } }) @@ -625,7 +625,7 @@ pub mod basic_shape { BasicShape, ClippingShape, FloatAreaShape, ShapeRadius, }; use crate::values::computed::border::{BorderCornerRadius, BorderRadius}; - use crate::values::computed::length::LengthOrPercentage; + use crate::values::computed::length::LengthPercentage; use crate::values::computed::motion::OffsetPath; use crate::values::computed::position; use crate::values::computed::url::ComputedUrl; @@ -742,10 +742,10 @@ pub mod basic_shape { fn from(other: &'a StyleBasicShape) -> Self { match other.mType { StyleBasicShapeType::Inset => { - let t = LengthOrPercentage::from_gecko_style_coord(&other.mCoordinates[0]); - let r = LengthOrPercentage::from_gecko_style_coord(&other.mCoordinates[1]); - let b = LengthOrPercentage::from_gecko_style_coord(&other.mCoordinates[2]); - let l = LengthOrPercentage::from_gecko_style_coord(&other.mCoordinates[3]); + let t = LengthPercentage::from_gecko_style_coord(&other.mCoordinates[0]); + let r = LengthPercentage::from_gecko_style_coord(&other.mCoordinates[1]); + let b = LengthPercentage::from_gecko_style_coord(&other.mCoordinates[2]); + let l = LengthPercentage::from_gecko_style_coord(&other.mCoordinates[3]); let round: BorderRadius = (&other.mRadius).into(); let round = if round.all_zero() { None } else { Some(round) }; let rect = Rect::new( @@ -771,12 +771,12 @@ pub mod basic_shape { let x = 2 * i; let y = x + 1; coords.push(PolygonCoord( - LengthOrPercentage::from_gecko_style_coord(&other.mCoordinates[x]) + LengthPercentage::from_gecko_style_coord(&other.mCoordinates[x]) .expect( "polygon() coordinate should be a length, percentage, \ or calc value", ), - LengthOrPercentage::from_gecko_style_coord(&other.mCoordinates[y]) + LengthPercentage::from_gecko_style_coord(&other.mCoordinates[y]) .expect( "polygon() coordinate should be a length, percentage, \ or calc value", @@ -797,12 +797,12 @@ pub mod basic_shape { let get_corner = |index| { BorderCornerRadius::new( NonNegative( - LengthOrPercentage::from_gecko_style_coord(&other.data_at(index)).expect( + LengthPercentage::from_gecko_style_coord(&other.data_at(index)).expect( " should be a length, percentage, or calc value", ), ), NonNegative( - LengthOrPercentage::from_gecko_style_coord(&other.data_at(index + 1)) + LengthPercentage::from_gecko_style_coord(&other.data_at(index + 1)) .expect( " should be a length, percentage, or calc value", ), @@ -958,11 +958,11 @@ impl From for SheetType { } } -impl TrackSize { +impl TrackSize { /// Return TrackSize from given two nsStyleCoord pub fn from_gecko_style_coords(gecko_min: &T, gecko_max: &T) -> Self { use crate::gecko_bindings::structs::root::nsStyleUnit; - use crate::values::computed::length::LengthOrPercentage; + use crate::values::computed::length::LengthPercentage; use crate::values::generics::grid::{TrackBreadth, TrackSize}; if gecko_min.unit() == nsStyleUnit::eStyleUnit_None { @@ -972,8 +972,8 @@ impl TrackSize { gecko_max.unit() == nsStyleUnit::eStyleUnit_Calc ); return TrackSize::FitContent( - LengthOrPercentage::from_gecko_style_coord(gecko_max) - .expect("gecko_max could not convert to LengthOrPercentage"), + LengthPercentage::from_gecko_style_coord(gecko_max) + .expect("gecko_max could not convert to LengthPercentage"), ); } @@ -1013,7 +1013,7 @@ impl TrackSize { } } -impl TrackListValue { +impl TrackListValue { /// Return TrackSize from given two nsStyleCoord pub fn from_gecko_style_coords(gecko_min: &T, gecko_max: &T) -> Self { TrackListValue::TrackSize(TrackSize::from_gecko_style_coords(gecko_min, gecko_max)) diff --git a/components/style/gecko/values.rs b/components/style/gecko/values.rs index 3c11d11e311..b4c26bc7dd8 100644 --- a/components/style/gecko/values.rs +++ b/components/style/gecko/values.rs @@ -13,9 +13,9 @@ use crate::gecko_bindings::sugar::ns_style_coord::{CoordData, CoordDataMut, Coor use crate::media_queries::Device; use crate::values::computed::basic_shape::ShapeRadius as ComputedShapeRadius; use crate::values::computed::FlexBasis as ComputedFlexBasis; -use crate::values::computed::{Angle, ExtremumLength, Length, LengthOrPercentage}; -use crate::values::computed::{LengthOrPercentageOrAuto, Percentage}; -use crate::values::computed::{LengthOrPercentageOrNone, Number, NumberOrPercentage}; +use crate::values::computed::{Angle, ExtremumLength, Length, LengthPercentage}; +use crate::values::computed::{LengthPercentageOrAuto, Percentage}; +use crate::values::computed::{LengthPercentageOrNone, Number, NumberOrPercentage}; use crate::values::computed::{MaxLength as ComputedMaxLength, MozLength as ComputedMozLength}; use crate::values::generics::basic_shape::ShapeRadius; use crate::values::generics::box_::Perspective; @@ -146,7 +146,7 @@ impl GeckoStyleCoordConvertible for NumberOrPercentage { } } -impl GeckoStyleCoordConvertible for LengthOrPercentage { +impl GeckoStyleCoordConvertible for LengthPercentage { fn to_gecko_style_coord(&self, coord: &mut T) { if self.was_calc { return coord.set_value(CoordDataValue::Calc((*self).into())) @@ -160,8 +160,8 @@ impl GeckoStyleCoordConvertible for LengthOrPercentage { fn from_gecko_style_coord(coord: &T) -> Option { match coord.as_value() { - CoordDataValue::Coord(coord) => Some(LengthOrPercentage::new(Au(coord).into(), None)), - CoordDataValue::Percent(p) => Some(LengthOrPercentage::new(Au(0).into(), Some(Percentage(p)))), + CoordDataValue::Coord(coord) => Some(LengthPercentage::new(Au(coord).into(), None)), + CoordDataValue::Percent(p) => Some(LengthPercentage::new(Au(0).into(), Some(Percentage(p)))), CoordDataValue::Calc(calc) => Some(calc.into()), _ => None, } @@ -181,34 +181,34 @@ impl GeckoStyleCoordConvertible for Length { } } -impl GeckoStyleCoordConvertible for LengthOrPercentageOrAuto { +impl GeckoStyleCoordConvertible for LengthPercentageOrAuto { fn to_gecko_style_coord(&self, coord: &mut T) { match *self { - LengthOrPercentageOrAuto::Auto => coord.set_value(CoordDataValue::Auto), - LengthOrPercentageOrAuto::LengthOrPercentage(ref lop) => lop.to_gecko_style_coord(coord), + LengthPercentageOrAuto::Auto => coord.set_value(CoordDataValue::Auto), + LengthPercentageOrAuto::LengthPercentage(ref lop) => lop.to_gecko_style_coord(coord), } } fn from_gecko_style_coord(coord: &T) -> Option { match coord.as_value() { - CoordDataValue::Auto => Some(LengthOrPercentageOrAuto::Auto), - _ => LengthOrPercentage::from_gecko_style_coord(coord).map(LengthOrPercentageOrAuto::LengthOrPercentage), + CoordDataValue::Auto => Some(LengthPercentageOrAuto::Auto), + _ => LengthPercentage::from_gecko_style_coord(coord).map(LengthPercentageOrAuto::LengthPercentage), } } } -impl GeckoStyleCoordConvertible for LengthOrPercentageOrNone { +impl GeckoStyleCoordConvertible for LengthPercentageOrNone { fn to_gecko_style_coord(&self, coord: &mut T) { match *self { - LengthOrPercentageOrNone::None => coord.set_value(CoordDataValue::None), - LengthOrPercentageOrNone::LengthOrPercentage(ref lop) => lop.to_gecko_style_coord(coord), + LengthPercentageOrNone::None => coord.set_value(CoordDataValue::None), + LengthPercentageOrNone::LengthPercentage(ref lop) => lop.to_gecko_style_coord(coord), } } fn from_gecko_style_coord(coord: &T) -> Option { match coord.as_value() { - CoordDataValue::None => Some(LengthOrPercentageOrNone::None), - _ => LengthOrPercentage::from_gecko_style_coord(coord).map(LengthOrPercentageOrNone::LengthOrPercentage), + CoordDataValue::None => Some(LengthPercentageOrNone::None), + _ => LengthPercentage::from_gecko_style_coord(coord).map(LengthPercentageOrNone::LengthPercentage), } } } @@ -363,14 +363,14 @@ impl GeckoStyleCoordConvertible for ExtremumLength { impl GeckoStyleCoordConvertible for ComputedMozLength { fn to_gecko_style_coord(&self, coord: &mut T) { match *self { - MozLength::LengthOrPercentageOrAuto(ref lopoa) => lopoa.to_gecko_style_coord(coord), + MozLength::LengthPercentageOrAuto(ref lopoa) => lopoa.to_gecko_style_coord(coord), MozLength::ExtremumLength(ref e) => e.to_gecko_style_coord(coord), } } fn from_gecko_style_coord(coord: &T) -> Option { - LengthOrPercentageOrAuto::from_gecko_style_coord(coord) - .map(MozLength::LengthOrPercentageOrAuto) + LengthPercentageOrAuto::from_gecko_style_coord(coord) + .map(MozLength::LengthPercentageOrAuto) .or_else(|| { ExtremumLength::from_gecko_style_coord(coord).map(MozLength::ExtremumLength) }) @@ -380,21 +380,21 @@ impl GeckoStyleCoordConvertible for ComputedMozLength { impl GeckoStyleCoordConvertible for ComputedMaxLength { fn to_gecko_style_coord(&self, coord: &mut T) { match *self { - MaxLength::LengthOrPercentageOrNone(ref lopon) => lopon.to_gecko_style_coord(coord), + MaxLength::LengthPercentageOrNone(ref lopon) => lopon.to_gecko_style_coord(coord), MaxLength::ExtremumLength(ref e) => e.to_gecko_style_coord(coord), } } fn from_gecko_style_coord(coord: &T) -> Option { - LengthOrPercentageOrNone::from_gecko_style_coord(coord) - .map(MaxLength::LengthOrPercentageOrNone) + LengthPercentageOrNone::from_gecko_style_coord(coord) + .map(MaxLength::LengthPercentageOrNone) .or_else(|| { ExtremumLength::from_gecko_style_coord(coord).map(MaxLength::ExtremumLength) }) } } -impl GeckoStyleCoordConvertible for ScrollSnapPoint { +impl GeckoStyleCoordConvertible for ScrollSnapPoint { fn to_gecko_style_coord(&self, coord: &mut T) { match self.repeated() { None => coord.set_value(CoordDataValue::None), @@ -409,8 +409,8 @@ impl GeckoStyleCoordConvertible for ScrollSnapPoint { Some(match coord.unit() { nsStyleUnit::eStyleUnit_None => ScrollSnapPoint::None, _ => ScrollSnapPoint::Repeat( - LengthOrPercentage::from_gecko_style_coord(coord) - .expect("coord could not convert to LengthOrPercentage"), + LengthPercentage::from_gecko_style_coord(coord) + .expect("coord could not convert to LengthPercentage"), ), }) } diff --git a/components/style/gecko_bindings/sugar/ns_css_value.rs b/components/style/gecko_bindings/sugar/ns_css_value.rs index f9ed43f7a3d..b3fb82f041f 100644 --- a/components/style/gecko_bindings/sugar/ns_css_value.rs +++ b/components/style/gecko_bindings/sugar/ns_css_value.rs @@ -9,7 +9,7 @@ use crate::gecko_bindings::structs; use crate::gecko_bindings::structs::{nsCSSUnit, nsCSSValue}; use crate::gecko_bindings::structs::{nsCSSValueList, nsCSSValue_Array}; use crate::gecko_string_cache::Atom; -use crate::values::computed::{Angle, Length, LengthOrPercentage, Percentage}; +use crate::values::computed::{Angle, Length, LengthPercentage, Percentage}; use std::marker::PhantomData; use std::mem; use std::ops::{Index, IndexMut}; @@ -67,8 +67,8 @@ impl nsCSSValue { &*array } - /// Sets LengthOrPercentage value to this nsCSSValue. - pub unsafe fn set_lop(&mut self, lop: LengthOrPercentage) { + /// Sets LengthPercentage value to this nsCSSValue. + pub unsafe fn set_lop(&mut self, lop: LengthPercentage) { if lop.was_calc { return bindings::Gecko_CSSValue_SetCalc(self, lop.into()) } @@ -89,16 +89,16 @@ impl nsCSSValue { bindings::Gecko_CSSValue_SetPercentage(self, unit_value) } - /// Returns LengthOrPercentage value. - pub unsafe fn get_lop(&self) -> LengthOrPercentage { + /// Returns LengthPercentage value. + pub unsafe fn get_lop(&self) -> LengthPercentage { match self.mUnit { nsCSSUnit::eCSSUnit_Pixel => { - LengthOrPercentage::new( + LengthPercentage::new( Length::new(bindings::Gecko_CSSValue_GetNumber(self)), None, ) }, - nsCSSUnit::eCSSUnit_Percent => LengthOrPercentage::new_percent(Percentage( + nsCSSUnit::eCSSUnit_Percent => LengthPercentage::new_percent(Percentage( bindings::Gecko_CSSValue_GetPercentage(self), )), nsCSSUnit::eCSSUnit_Calc => { diff --git a/components/style/properties/gecko.mako.rs b/components/style/properties/gecko.mako.rs index 036653d218e..673de55681f 100644 --- a/components/style/properties/gecko.mako.rs +++ b/components/style/properties/gecko.mako.rs @@ -510,7 +510,7 @@ def set_gecko_property(ffi_name, expr): // set on mContextFlags, and the length field is set to the initial value. pub fn set_${ident}(&mut self, v: longhands::${ident}::computed_value::T) { - use crate::values::generics::svg::{SVGLength, SvgLengthOrPercentageOrNumber}; + use crate::values::generics::svg::{SVGLength, SvgLengthPercentageOrNumber}; use crate::gecko_bindings::structs::nsStyleSVG_${ident.upper()}_CONTEXT as CONTEXT_VALUE; let length = match v { SVGLength::Length(length) => { @@ -526,9 +526,9 @@ def set_gecko_property(ffi_name, expr): } }; match length { - SvgLengthOrPercentageOrNumber::LengthOrPercentage(lop) => + SvgLengthPercentageOrNumber::LengthPercentage(lop) => self.gecko.${gecko_ffi_name}.set(lop), - SvgLengthOrPercentageOrNumber::Number(num) => + SvgLengthPercentageOrNumber::Number(num) => self.gecko.${gecko_ffi_name}.set_value(CoordDataValue::Factor(num.into())), } } @@ -546,28 +546,28 @@ def set_gecko_property(ffi_name, expr): } pub fn clone_${ident}(&self) -> longhands::${ident}::computed_value::T { - use crate::values::generics::svg::{SVGLength, SvgLengthOrPercentageOrNumber}; - use crate::values::computed::LengthOrPercentage; + use crate::values::generics::svg::{SVGLength, SvgLengthPercentageOrNumber}; + use crate::values::computed::LengthPercentage; use crate::gecko_bindings::structs::nsStyleSVG_${ident.upper()}_CONTEXT as CONTEXT_VALUE; if (self.gecko.mContextFlags & CONTEXT_VALUE) != 0 { return SVGLength::ContextValue; } let length = match self.gecko.${gecko_ffi_name}.as_value() { CoordDataValue::Factor(number) => { - SvgLengthOrPercentageOrNumber::Number(number) + SvgLengthPercentageOrNumber::Number(number) }, CoordDataValue::Coord(coord) => { - SvgLengthOrPercentageOrNumber::LengthOrPercentage( - LengthOrPercentage::new(Au(coord).into(), None) + SvgLengthPercentageOrNumber::LengthPercentage( + LengthPercentage::new(Au(coord).into(), None) ) }, CoordDataValue::Percent(p) => { - SvgLengthOrPercentageOrNumber::LengthOrPercentage( - LengthOrPercentage::new(Au(0).into(), Some(Percentage(p))) + SvgLengthPercentageOrNumber::LengthPercentage( + LengthPercentage::new(Au(0).into(), Some(Percentage(p))) ) }, CoordDataValue::Calc(calc) => { - SvgLengthOrPercentageOrNumber::LengthOrPercentage(calc.into()) + SvgLengthPercentageOrNumber::LengthPercentage(calc.into()) }, _ => unreachable!("Unexpected coordinate in ${ident}"), }; @@ -1269,12 +1269,12 @@ pub fn clone_transform_from_list( #[allow(non_snake_case)] pub fn clone_${ident}(&self) -> values::computed::TransformOrigin { - use crate::values::computed::{Length, LengthOrPercentage, TransformOrigin}; + use crate::values::computed::{Length, LengthPercentage, TransformOrigin}; TransformOrigin { - horizontal: LengthOrPercentage::from_gecko_style_coord(&self.gecko.${gecko_ffi_name}[0]) - .expect("clone for LengthOrPercentage failed"), - vertical: LengthOrPercentage::from_gecko_style_coord(&self.gecko.${gecko_ffi_name}[1]) - .expect("clone for LengthOrPercentage failed"), + horizontal: LengthPercentage::from_gecko_style_coord(&self.gecko.${gecko_ffi_name}[0]) + .expect("clone for LengthPercentage failed"), + vertical: LengthPercentage::from_gecko_style_coord(&self.gecko.${gecko_ffi_name}[1]) + .expect("clone for LengthPercentage failed"), depth: if let Some(third) = self.gecko.${gecko_ffi_name}.get(2) { Length::from_gecko_style_coord(third) .expect("clone for Length failed") @@ -1402,19 +1402,19 @@ impl Clone for ${style_struct.gecko_struct_name} { "length::LengthOrAuto": impl_style_coord, "length::LengthOrNormal": impl_style_coord, "length::NonNegativeLengthOrAuto": impl_style_coord, - "length::NonNegativeLengthOrPercentageOrNormal": impl_style_coord, + "length::NonNegativeLengthPercentageOrNormal": impl_style_coord, "FillRule": impl_simple, "FlexBasis": impl_style_coord, "Length": impl_absolute_length, "LengthOrNormal": impl_style_coord, - "LengthOrPercentage": impl_style_coord, - "LengthOrPercentageOrAuto": impl_style_coord, - "LengthOrPercentageOrNone": impl_style_coord, + "LengthPercentage": impl_style_coord, + "LengthPercentageOrAuto": impl_style_coord, + "LengthPercentageOrNone": impl_style_coord, "MaxLength": impl_style_coord, "MozLength": impl_style_coord, "MozScriptMinSize": impl_absolute_length, "MozScriptSizeMultiplier": impl_simple, - "NonNegativeLengthOrPercentage": impl_style_coord, + "NonNegativeLengthPercentage": impl_style_coord, "NonNegativeNumber": impl_simple, "Number": impl_simple, "Opacity": impl_simple, @@ -3084,7 +3084,7 @@ fn static_assert() { } pub fn clone_vertical_align(&self) -> longhands::vertical_align::computed_value::T { - use crate::values::computed::LengthOrPercentage; + use crate::values::computed::LengthPercentage; use crate::values::generics::box_::VerticalAlign; let gecko = &self.gecko.mVerticalAlign; @@ -3092,7 +3092,7 @@ fn static_assert() { CoordDataValue::Enumerated(value) => VerticalAlign::from_gecko_keyword(value), _ => { VerticalAlign::Length( - LengthOrPercentage::from_gecko_style_coord(gecko).expect( + LengthPercentage::from_gecko_style_coord(gecko).expect( "expected for vertical-align", ), ) @@ -3386,11 +3386,11 @@ fn static_assert() { pub fn clone_perspective_origin(&self) -> longhands::perspective_origin::computed_value::T { use crate::properties::longhands::perspective_origin::computed_value::T; - use crate::values::computed::LengthOrPercentage; + use crate::values::computed::LengthPercentage; T { - horizontal: LengthOrPercentage::from_gecko_style_coord(&self.gecko.mPerspectiveOrigin[0]) + horizontal: LengthPercentage::from_gecko_style_coord(&self.gecko.mPerspectiveOrigin[0]) .expect("Expected length or percentage for horizontal value of perspective-origin"), - vertical: LengthOrPercentage::from_gecko_style_coord(&self.gecko.mPerspectiveOrigin[1]) + vertical: LengthPercentage::from_gecko_style_coord(&self.gecko.mPerspectiveOrigin[1]) .expect("Expected length or percentage for vertical value of perspective-origin"), } } @@ -3879,12 +3879,12 @@ fn static_assert() { pub fn clone_${shorthand}_size(&self) -> longhands::${shorthand}_size::computed_value::T { use crate::gecko_bindings::structs::nsStyleCoord_CalcValue as CalcValue; use crate::gecko_bindings::structs::nsStyleImageLayers_Size_DimensionType as DimensionType; - use crate::values::computed::NonNegativeLengthOrPercentageOrAuto; + use crate::values::computed::NonNegativeLengthPercentageOrAuto; use crate::values::generics::background::BackgroundSize; - fn to_servo(value: CalcValue, ty: u8) -> NonNegativeLengthOrPercentageOrAuto { + fn to_servo(value: CalcValue, ty: u8) -> NonNegativeLengthPercentageOrAuto { if ty == DimensionType::eAuto as u8 { - NonNegativeLengthOrPercentageOrAuto::auto() + NonNegativeLengthPercentageOrAuto::auto() } else { debug_assert_eq!(ty, DimensionType::eLengthPercentage as u8); value.into() @@ -4575,7 +4575,7 @@ fn static_assert() { } pub fn clone_word_spacing(&self) -> longhands::word_spacing::computed_value::T { - use crate::values::computed::LengthOrPercentage; + use crate::values::computed::LengthPercentage; use crate::values::generics::text::Spacing; debug_assert!( matches!(self.gecko.mWordSpacing.as_value(), @@ -4584,7 +4584,7 @@ fn static_assert() { CoordDataValue::Percent(_) | CoordDataValue::Calc(_)), "Unexpected computed value for word-spacing"); - LengthOrPercentage::from_gecko_style_coord(&self.gecko.mWordSpacing).map_or(Spacing::Normal, Spacing::Value) + LengthPercentage::from_gecko_style_coord(&self.gecko.mWordSpacing).map_or(Spacing::Normal, Spacing::Value) } <%call expr="impl_coord_copy('word_spacing', 'mWordSpacing')"> @@ -5016,7 +5016,7 @@ clip-path pub fn set_stroke_dasharray(&mut self, v: longhands::stroke_dasharray::computed_value::T) { use crate::gecko_bindings::structs::nsStyleSVG_STROKE_DASHARRAY_CONTEXT as CONTEXT_VALUE; - use crate::values::generics::svg::{SVGStrokeDashArray, SvgLengthOrPercentageOrNumber}; + use crate::values::generics::svg::{SVGStrokeDashArray, SvgLengthPercentageOrNumber}; match v { SVGStrokeDashArray::Values(v) => { @@ -5027,9 +5027,9 @@ clip-path } for (gecko, servo) in self.gecko.mStrokeDasharray.iter_mut().zip(v) { match servo { - SvgLengthOrPercentageOrNumber::LengthOrPercentage(lop) => + SvgLengthPercentageOrNumber::LengthPercentage(lop) => gecko.set(lop), - SvgLengthOrPercentageOrNumber::Number(num) => + SvgLengthPercentageOrNumber::Number(num) => gecko.set_value(CoordDataValue::Factor(num.into())), } } @@ -5059,9 +5059,9 @@ clip-path pub fn clone_stroke_dasharray(&self) -> longhands::stroke_dasharray::computed_value::T { use crate::gecko_bindings::structs::nsStyleSVG_STROKE_DASHARRAY_CONTEXT as CONTEXT_VALUE; - use crate::values::computed::LengthOrPercentage; + use crate::values::computed::LengthPercentage; use crate::values::generics::NonNegative; - use crate::values::generics::svg::{SVGStrokeDashArray, SvgLengthOrPercentageOrNumber}; + use crate::values::generics::svg::{SVGStrokeDashArray, SvgLengthPercentageOrNumber}; if self.gecko.mContextFlags & CONTEXT_VALUE != 0 { debug_assert_eq!(self.gecko.mStrokeDasharray.len(), 0); @@ -5071,16 +5071,16 @@ clip-path for gecko in self.gecko.mStrokeDasharray.iter() { match gecko.as_value() { CoordDataValue::Factor(number) => - vec.push(SvgLengthOrPercentageOrNumber::Number(number.into())), + vec.push(SvgLengthPercentageOrNumber::Number(number.into())), CoordDataValue::Coord(coord) => - vec.push(SvgLengthOrPercentageOrNumber::LengthOrPercentage( - NonNegative(LengthOrPercentage::new(Au(coord).into(), None).into()))), + vec.push(SvgLengthPercentageOrNumber::LengthPercentage( + NonNegative(LengthPercentage::new(Au(coord).into(), None).into()))), CoordDataValue::Percent(p) => - vec.push(SvgLengthOrPercentageOrNumber::LengthOrPercentage( - NonNegative(LengthOrPercentage::new_percent(Percentage(p)).into()))), + vec.push(SvgLengthPercentageOrNumber::LengthPercentage( + NonNegative(LengthPercentage::new_percent(Percentage(p)).into()))), CoordDataValue::Calc(calc) => - vec.push(SvgLengthOrPercentageOrNumber::LengthOrPercentage( - NonNegative(LengthOrPercentage::from(calc).clamp_to_non_negative()))), + vec.push(SvgLengthPercentageOrNumber::LengthPercentage( + NonNegative(LengthPercentage::from(calc).clamp_to_non_negative()))), _ => unreachable!(), } } diff --git a/components/style/properties/longhands/background.mako.rs b/components/style/properties/longhands/background.mako.rs index b97545898c2..c6a25be53c1 100644 --- a/components/style/properties/longhands/background.mako.rs +++ b/components/style/properties/longhands/background.mako.rs @@ -35,7 +35,7 @@ ${helpers.predefined_type( ${helpers.predefined_type( "background-position-" + axis, "position::" + direction + "Position", - initial_value="computed::LengthOrPercentage::zero()", + initial_value="computed::LengthPercentage::zero()", initial_specified_value="SpecifiedValue::initial_specified_value()", spec="https://drafts.csswg.org/css-backgrounds-4/#propdef-background-position-" + axis, animation_value_type="ComputedValue", diff --git a/components/style/properties/longhands/border.mako.rs b/components/style/properties/longhands/border.mako.rs index 3fcf73bf2f4..79df20d7812 100644 --- a/components/style/properties/longhands/border.mako.rs +++ b/components/style/properties/longhands/border.mako.rs @@ -69,7 +69,7 @@ ${helpers.gecko_keyword_conversion( type="crate::values::specified::BorderStyle", )} -// FIXME(#4126): when gfx supports painting it, make this Size2D +// FIXME(#4126): when gfx supports painting it, make this Size2D % for corner in ["top-left", "top-right", "bottom-right", "bottom-left"]: ${helpers.predefined_type( "border-" + corner + "-radius", @@ -189,7 +189,7 @@ impl crate::values::computed::BorderImageWidth { use crate::gecko_bindings::structs::nsStyleUnit::{eStyleUnit_Factor, eStyleUnit_Auto}; use crate::gecko_bindings::sugar::ns_style_coord::CoordData; use crate::gecko::values::GeckoStyleCoordConvertible; - use crate::values::computed::{LengthOrPercentage, Number}; + use crate::values::computed::{LengthPercentage, Number}; use crate::values::generics::border::BorderImageSideWidth; use crate::values::generics::NonNegative; @@ -207,8 +207,8 @@ impl crate::values::computed::BorderImageWidth { }, _ => { BorderImageSideWidth::Length( - NonNegative(LengthOrPercentage::from_gecko_style_coord(&sides.data_at(${i})) - .expect("sides[${i}] could not convert to LengthOrPercentage"))) + NonNegative(LengthPercentage::from_gecko_style_coord(&sides.data_at(${i})) + .expect("sides[${i}] could not convert to LengthPercentage"))) }, }, % endfor diff --git a/components/style/properties/longhands/box.mako.rs b/components/style/properties/longhands/box.mako.rs index 48b83271d9b..1818179a442 100644 --- a/components/style/properties/longhands/box.mako.rs +++ b/components/style/properties/longhands/box.mako.rs @@ -611,10 +611,10 @@ ${helpers.predefined_type( ${helpers.predefined_type( "shape-margin", - "NonNegativeLengthOrPercentage", - "computed::NonNegativeLengthOrPercentage::zero()", + "NonNegativeLengthPercentage", + "computed::NonNegativeLengthPercentage::zero()", products="gecko", - animation_value_type="NonNegativeLengthOrPercentage", + animation_value_type="NonNegativeLengthPercentage", flags="APPLIES_TO_FIRST_LETTER", spec="https://drafts.csswg.org/css-shapes/#shape-margin-property", )} diff --git a/components/style/properties/longhands/inherited_text.mako.rs b/components/style/properties/longhands/inherited_text.mako.rs index 3eded4ea7ac..b1ed79379ca 100644 --- a/components/style/properties/longhands/inherited_text.mako.rs +++ b/components/style/properties/longhands/inherited_text.mako.rs @@ -53,8 +53,8 @@ ${helpers.single_keyword( ${helpers.predefined_type( "text-indent", - "LengthOrPercentage", - "computed::LengthOrPercentage::zero()", + "LengthPercentage", + "computed::LengthPercentage::zero()", animation_value_type="ComputedValue", spec="https://drafts.csswg.org/css-text/#propdef-text-indent", allow_quirks=True, diff --git a/components/style/properties/longhands/margin.mako.rs b/components/style/properties/longhands/margin.mako.rs index 7762be1a23a..e5eac633c96 100644 --- a/components/style/properties/longhands/margin.mako.rs +++ b/components/style/properties/longhands/margin.mako.rs @@ -14,8 +14,8 @@ %> ${helpers.predefined_type( "margin-%s" % side[0], - "LengthOrPercentageOrAuto", - "computed::LengthOrPercentageOrAuto::zero()", + "LengthPercentageOrAuto", + "computed::LengthPercentageOrAuto::zero()", alias=maybe_moz_logical_alias(product, side, "-moz-margin-%s"), allow_quirks=not side[1], animation_value_type="ComputedValue", diff --git a/components/style/properties/longhands/padding.mako.rs b/components/style/properties/longhands/padding.mako.rs index edfc37d31e6..5fa51863629 100644 --- a/components/style/properties/longhands/padding.mako.rs +++ b/components/style/properties/longhands/padding.mako.rs @@ -16,10 +16,10 @@ %> ${helpers.predefined_type( "padding-%s" % side[0], - "NonNegativeLengthOrPercentage", - "computed::NonNegativeLengthOrPercentage::zero()", + "NonNegativeLengthPercentage", + "computed::NonNegativeLengthPercentage::zero()", alias=maybe_moz_logical_alias(product, side, "-moz-padding-%s"), - animation_value_type="NonNegativeLengthOrPercentage", + animation_value_type="NonNegativeLengthPercentage", logical=side[1], logical_group="padding", spec=spec, diff --git a/components/style/properties/longhands/position.mako.rs b/components/style/properties/longhands/position.mako.rs index ddba7255008..a7a6910f954 100644 --- a/components/style/properties/longhands/position.mako.rs +++ b/components/style/properties/longhands/position.mako.rs @@ -12,8 +12,8 @@ % for side in PHYSICAL_SIDES: ${helpers.predefined_type( side, - "LengthOrPercentageOrAuto", - "computed::LengthOrPercentageOrAuto::Auto", + "LengthPercentageOrAuto", + "computed::LengthPercentageOrAuto::Auto", spec="https://www.w3.org/TR/CSS2/visuren.html#propdef-%s" % side, flags="GETCS_NEEDS_LAYOUT_FLUSH", animation_value_type="ComputedValue", @@ -26,8 +26,8 @@ % for side in LOGICAL_SIDES: ${helpers.predefined_type( "inset-%s" % side, - "LengthOrPercentageOrAuto", - "computed::LengthOrPercentageOrAuto::Auto", + "LengthPercentageOrAuto", + "computed::LengthPercentageOrAuto::Auto", spec="https://drafts.csswg.org/css-logical-props/#propdef-inset-%s" % side, flags="GETCS_NEEDS_LAYOUT_FLUSH", alias="offset-%s:layout.css.offset-logical-properties.enabled" % side, @@ -285,8 +285,8 @@ ${helpers.predefined_type( // servo versions (no keyword support) ${helpers.predefined_type( size, - "LengthOrPercentageOrAuto", - "computed::LengthOrPercentageOrAuto::Auto", + "LengthPercentageOrAuto", + "computed::LengthPercentageOrAuto::Auto", "parse_non_negative", spec=spec % size, logical_group="size", @@ -296,8 +296,8 @@ ${helpers.predefined_type( )} ${helpers.predefined_type( "min-%s" % size, - "LengthOrPercentage", - "computed::LengthOrPercentage::zero()", + "LengthPercentage", + "computed::LengthPercentage::zero()", "parse_non_negative", spec=spec % ("min-%s" % size), logical_group="min-size", @@ -308,8 +308,8 @@ ${helpers.predefined_type( )} ${helpers.predefined_type( "max-%s" % size, - "LengthOrPercentageOrNone", - "computed::LengthOrPercentageOrNone::None", + "LengthPercentageOrNone", + "computed::LengthPercentageOrNone::None", "parse_non_negative", spec=spec % ("max-%s" % size), logical_group="max-size", @@ -408,24 +408,24 @@ ${helpers.predefined_type( ${helpers.predefined_type( "column-gap", - "length::NonNegativeLengthOrPercentageOrNormal", + "length::NonNegativeLengthPercentageOrNormal", "Either::Second(Normal)", alias="grid-column-gap" if product == "gecko" else "", extra_prefixes="moz", servo_pref="layout.columns.enabled", spec="https://drafts.csswg.org/css-align-3/#propdef-column-gap", - animation_value_type="NonNegativeLengthOrPercentageOrNormal", + animation_value_type="NonNegativeLengthPercentageOrNormal", servo_restyle_damage="reflow", )} // no need for -moz- prefixed alias for this property ${helpers.predefined_type( "row-gap", - "length::NonNegativeLengthOrPercentageOrNormal", + "length::NonNegativeLengthPercentageOrNormal", "Either::Second(Normal)", alias="grid-row-gap", products="gecko", spec="https://drafts.csswg.org/css-align-3/#propdef-row-gap", - animation_value_type="NonNegativeLengthOrPercentageOrNormal", + animation_value_type="NonNegativeLengthPercentageOrNormal", servo_restyle_damage="reflow", )} diff --git a/components/style/properties/longhands/svg.mako.rs b/components/style/properties/longhands/svg.mako.rs index 43a8952d86e..f003fa5222e 100644 --- a/components/style/properties/longhands/svg.mako.rs +++ b/components/style/properties/longhands/svg.mako.rs @@ -118,7 +118,7 @@ ${helpers.predefined_type( ${helpers.predefined_type( "mask-position-" + axis, "position::" + direction + "Position", - "computed::LengthOrPercentage::zero()", + "computed::LengthPercentage::zero()", products="gecko", extra_prefixes="webkit", initial_specified_value="specified::PositionComponent::Center", diff --git a/components/style/properties/properties.mako.rs b/components/style/properties/properties.mako.rs index 494bdc7706d..2d91273be15 100644 --- a/components/style/properties/properties.mako.rs +++ b/components/style/properties/properties.mako.rs @@ -3017,7 +3017,7 @@ impl ComputedValuesInner { /// Get the logical computed inline size. #[inline] - pub fn content_inline_size(&self) -> computed::LengthOrPercentageOrAuto { + pub fn content_inline_size(&self) -> computed::LengthPercentageOrAuto { let position_style = self.get_position(); if self.writing_mode.is_vertical() { position_style.height @@ -3028,42 +3028,42 @@ impl ComputedValuesInner { /// Get the logical computed block size. #[inline] - pub fn content_block_size(&self) -> computed::LengthOrPercentageOrAuto { + pub fn content_block_size(&self) -> computed::LengthPercentageOrAuto { let position_style = self.get_position(); if self.writing_mode.is_vertical() { position_style.width } else { position_style.height } } /// Get the logical computed min inline size. #[inline] - pub fn min_inline_size(&self) -> computed::LengthOrPercentage { + pub fn min_inline_size(&self) -> computed::LengthPercentage { let position_style = self.get_position(); if self.writing_mode.is_vertical() { position_style.min_height } else { position_style.min_width } } /// Get the logical computed min block size. #[inline] - pub fn min_block_size(&self) -> computed::LengthOrPercentage { + pub fn min_block_size(&self) -> computed::LengthPercentage { let position_style = self.get_position(); if self.writing_mode.is_vertical() { position_style.min_width } else { position_style.min_height } } /// Get the logical computed max inline size. #[inline] - pub fn max_inline_size(&self) -> computed::LengthOrPercentageOrNone { + pub fn max_inline_size(&self) -> computed::LengthPercentageOrNone { let position_style = self.get_position(); if self.writing_mode.is_vertical() { position_style.max_height } else { position_style.max_width } } /// Get the logical computed max block size. #[inline] - pub fn max_block_size(&self) -> computed::LengthOrPercentageOrNone { + pub fn max_block_size(&self) -> computed::LengthPercentageOrNone { let position_style = self.get_position(); if self.writing_mode.is_vertical() { position_style.max_width } else { position_style.max_height } } /// Get the logical computed padding for this writing mode. #[inline] - pub fn logical_padding(&self) -> LogicalMargin { + pub fn logical_padding(&self) -> LogicalMargin { let padding_style = self.get_padding(); LogicalMargin::from_physical(self.writing_mode, SideOffsets2D::new( padding_style.padding_top.0, @@ -3093,7 +3093,7 @@ impl ComputedValuesInner { /// Gets the logical computed margin from this style. #[inline] - pub fn logical_margin(&self) -> LogicalMargin { + pub fn logical_margin(&self) -> LogicalMargin { let margin_style = self.get_margin(); LogicalMargin::from_physical(self.writing_mode, SideOffsets2D::new( margin_style.margin_top, @@ -3105,7 +3105,7 @@ impl ComputedValuesInner { /// Gets the logical position from this style. #[inline] - pub fn logical_position(&self) -> LogicalMargin { + pub fn logical_position(&self) -> LogicalMargin { // FIXME(SimonSapin): should be the writing mode of the containing block, maybe? let position_style = self.get_position(); LogicalMargin::from_physical(self.writing_mode, SideOffsets2D::new( diff --git a/components/style/properties/shorthands/margin.mako.rs b/components/style/properties/shorthands/margin.mako.rs index 944d4a3e6a1..86e3b56a226 100644 --- a/components/style/properties/shorthands/margin.mako.rs +++ b/components/style/properties/shorthands/margin.mako.rs @@ -4,7 +4,7 @@ <%namespace name="helpers" file="/helpers.mako.rs" /> -${helpers.four_sides_shorthand("margin", "margin-%s", "specified::LengthOrPercentageOrAuto::parse", +${helpers.four_sides_shorthand("margin", "margin-%s", "specified::LengthPercentageOrAuto::parse", spec="https://drafts.csswg.org/css-box/#propdef-margin", allowed_in_page_rule=True, allow_quirks=True)} diff --git a/components/style/properties/shorthands/padding.mako.rs b/components/style/properties/shorthands/padding.mako.rs index 41db5d3a0fe..0314a46938d 100644 --- a/components/style/properties/shorthands/padding.mako.rs +++ b/components/style/properties/shorthands/padding.mako.rs @@ -4,6 +4,6 @@ <%namespace name="helpers" file="/helpers.mako.rs" /> -${helpers.four_sides_shorthand("padding", "padding-%s", "specified::NonNegativeLengthOrPercentage::parse", +${helpers.four_sides_shorthand("padding", "padding-%s", "specified::NonNegativeLengthPercentage::parse", spec="https://drafts.csswg.org/css-box-3/#propdef-padding", allow_quirks=True)} diff --git a/components/style/stylesheets/viewport_rule.rs b/components/style/stylesheets/viewport_rule.rs index 209243228df..ce63ffbfc47 100644 --- a/components/style/stylesheets/viewport_rule.rs +++ b/components/style/stylesheets/viewport_rule.rs @@ -18,7 +18,7 @@ use crate::shared_lock::{SharedRwLockReadGuard, StylesheetGuards, ToCssWithGuard use crate::str::CssStringWriter; use crate::stylesheets::{Origin, StylesheetInDocument}; use crate::values::computed::{Context, ToComputedValue}; -use crate::values::specified::{self, LengthOrPercentageOrAuto, NoCalcLength, ViewportPercentageLength}; +use crate::values::specified::{self, LengthPercentageOrAuto, NoCalcLength, ViewportPercentageLength}; use app_units::Au; use cssparser::CowRcStr; use cssparser::{parse_important, AtRuleParser, DeclarationListParser, DeclarationParser, Parser}; @@ -149,7 +149,7 @@ trait FromMeta: Sized { #[cfg_attr(feature = "servo", derive(MallocSizeOf))] #[derive(Clone, Debug, PartialEq, ToCss)] pub enum ViewportLength { - Specified(LengthOrPercentageOrAuto), + Specified(LengthPercentageOrAuto), ExtendToZoom, } @@ -157,8 +157,8 @@ impl FromMeta for ViewportLength { fn from_meta(value: &str) -> Option { macro_rules! specified { ($value:expr) => { - ViewportLength::Specified(LengthOrPercentageOrAuto::LengthOrPercentage( - specified::LengthOrPercentage::Length($value) + ViewportLength::Specified(LengthPercentageOrAuto::LengthPercentage( + specified::LengthPercentage::Length($value) )) }; } @@ -186,7 +186,7 @@ impl ViewportLength { ) -> Result> { // we explicitly do not accept 'extend-to-zoom', since it is a UA // internal value for viewport translation - LengthOrPercentageOrAuto::parse_non_negative(context, input).map(ViewportLength::Specified) + LengthPercentageOrAuto::parse_non_negative(context, input).map(ViewportLength::Specified) } } @@ -468,10 +468,10 @@ impl ViewportRule { if !has_width && has_zoom { if has_height { push_descriptor!(MinWidth(ViewportLength::Specified( - LengthOrPercentageOrAuto::Auto + LengthPercentageOrAuto::Auto ))); push_descriptor!(MaxWidth(ViewportLength::Specified( - LengthOrPercentageOrAuto::Auto + LengthPercentageOrAuto::Auto ))); } else { push_descriptor!(MinWidth(ViewportLength::ExtendToZoom)); @@ -754,8 +754,8 @@ impl MaybeNew for ViewportConstraints { if let Some($value) = $value { match *$value { ViewportLength::Specified(ref length) => match *length { - LengthOrPercentageOrAuto::Auto => None, - LengthOrPercentageOrAuto::LengthOrPercentage(ref lop) => Some(lop + LengthPercentageOrAuto::Auto => None, + LengthPercentageOrAuto::LengthPercentage(ref lop) => Some(lop .to_computed_value(&context) .to_used_value(initial_viewport.$dimension)), }, diff --git a/components/style/values/animated/length.rs b/components/style/values/animated/length.rs index b0d717b0e49..f3d002b4fd0 100644 --- a/components/style/values/animated/length.rs +++ b/components/style/values/animated/length.rs @@ -5,13 +5,13 @@ //! Animation implementation for various length-related types. use super::{Animate, Procedure, ToAnimatedValue}; -use crate::values::computed::length::LengthOrPercentage; +use crate::values::computed::length::LengthPercentage; use crate::values::computed::MaxLength as ComputedMaxLength; use crate::values::computed::MozLength as ComputedMozLength; use crate::values::computed::Percentage; /// -impl Animate for LengthOrPercentage { +impl Animate for LengthPercentage { #[inline] fn animate(&self, other: &Self, procedure: Procedure) -> Result { let animate_percentage_half = |this: Option, other: Option| { @@ -48,17 +48,17 @@ impl ToAnimatedValue for ComputedMaxLength { #[inline] fn from_animated_value(animated: Self::AnimatedValue) -> Self { - use crate::values::computed::LengthOrPercentageOrNone; + use crate::values::computed::LengthPercentageOrNone; use crate::values::generics::length::MaxLength as GenericMaxLength; match animated { - GenericMaxLength::LengthOrPercentageOrNone(lopn) => { + GenericMaxLength::LengthPercentageOrNone(lopn) => { let result = match lopn { - LengthOrPercentageOrNone::LengthOrPercentage(len) => { - LengthOrPercentageOrNone::LengthOrPercentage(len.clamp_to_non_negative()) + LengthPercentageOrNone::LengthPercentage(len) => { + LengthPercentageOrNone::LengthPercentage(len.clamp_to_non_negative()) }, - LengthOrPercentageOrNone::None => lopn, + LengthPercentageOrNone::None => lopn, }; - GenericMaxLength::LengthOrPercentageOrNone(result) + GenericMaxLength::LengthPercentageOrNone(result) }, _ => animated, } @@ -77,8 +77,8 @@ impl ToAnimatedValue for ComputedMozLength { fn from_animated_value(animated: Self::AnimatedValue) -> Self { use crate::values::generics::length::MozLength as GenericMozLength; match animated { - GenericMozLength::LengthOrPercentageOrAuto(lopa) => { - GenericMozLength::LengthOrPercentageOrAuto(lopa.clamp_to_non_negative()) + GenericMozLength::LengthPercentageOrAuto(lopa) => { + GenericMozLength::LengthPercentageOrAuto(lopa.clamp_to_non_negative()) }, _ => animated, } diff --git a/components/style/values/animated/mod.rs b/components/style/values/animated/mod.rs index 1655f2eaa26..a4e79074ef6 100644 --- a/components/style/values/animated/mod.rs +++ b/components/style/values/animated/mod.rs @@ -9,7 +9,7 @@ //! module's raison d'ĂȘtre is to ultimately contain all these types. use crate::properties::PropertyId; -use crate::values::computed::length::LengthOrPercentage; +use crate::values::computed::length::LengthPercentage; use crate::values::computed::url::ComputedUrl; use crate::values::computed::Angle as ComputedAngle; use crate::values::computed::Image; @@ -335,7 +335,7 @@ macro_rules! trivial_to_animated_value { } trivial_to_animated_value!(Au); -trivial_to_animated_value!(LengthOrPercentage); +trivial_to_animated_value!(LengthPercentage); trivial_to_animated_value!(ComputedAngle); trivial_to_animated_value!(ComputedUrl); trivial_to_animated_value!(bool); diff --git a/components/style/values/animated/svg.rs b/components/style/values/animated/svg.rs index 7123542aef8..4f181981d91 100644 --- a/components/style/values/animated/svg.rs +++ b/components/style/values/animated/svg.rs @@ -8,9 +8,9 @@ use super::{Animate, Procedure, ToAnimatedZero}; use crate::properties::animated_properties::ListAnimation; use crate::values::animated::color::Color as AnimatedColor; use crate::values::computed::url::ComputedUrl; -use crate::values::computed::{LengthOrPercentage, Number, NumberOrPercentage}; +use crate::values::computed::{LengthPercentage, Number, NumberOrPercentage}; use crate::values::distance::{ComputeSquaredDistance, SquaredDistance}; -use crate::values::generics::svg::{SVGLength, SVGPaint, SvgLengthOrPercentageOrNumber}; +use crate::values::generics::svg::{SVGLength, SVGPaint, SvgLengthPercentageOrNumber}; use crate::values::generics::svg::{SVGOpacity, SVGStrokeDashArray}; /// Animated SVGPaint. @@ -29,10 +29,10 @@ impl ToAnimatedZero for IntermediateSVGPaint { // FIXME: We need to handle calc here properly, see // https://bugzilla.mozilla.org/show_bug.cgi?id=1386967 fn to_number_or_percentage( - value: &SvgLengthOrPercentageOrNumber, + value: &SvgLengthPercentageOrNumber, ) -> Result { Ok(match *value { - SvgLengthOrPercentageOrNumber::LengthOrPercentage(ref l) => { + SvgLengthPercentageOrNumber::LengthPercentage(ref l) => { match l.percentage { Some(p) => { if l.unclamped_length().px() != 0. { @@ -43,11 +43,11 @@ fn to_number_or_percentage( None => NumberOrPercentage::Number(l.length().px()) } }, - SvgLengthOrPercentageOrNumber::Number(ref n) => NumberOrPercentage::Number(*n), + SvgLengthPercentageOrNumber::Number(ref n) => NumberOrPercentage::Number(*n), }) } -impl Animate for SvgLengthOrPercentageOrNumber { +impl Animate for SvgLengthPercentageOrNumber { #[inline] fn animate(&self, other: &Self, procedure: Procedure) -> Result { let this = to_number_or_percentage(self)?; @@ -55,20 +55,20 @@ impl Animate for SvgLengthOrPercentageOrNumber { match (this, other) { (NumberOrPercentage::Number(ref this), NumberOrPercentage::Number(ref other)) => Ok( - SvgLengthOrPercentageOrNumber::Number(this.animate(other, procedure)?), + SvgLengthPercentageOrNumber::Number(this.animate(other, procedure)?), ), ( NumberOrPercentage::Percentage(ref this), NumberOrPercentage::Percentage(ref other), - ) => Ok(SvgLengthOrPercentageOrNumber::LengthOrPercentage( - LengthOrPercentage::new_percent(this.animate(other, procedure)?), + ) => Ok(SvgLengthPercentageOrNumber::LengthPercentage( + LengthPercentage::new_percent(this.animate(other, procedure)?), )), _ => Err(()), } } } -impl ComputeSquaredDistance for SvgLengthOrPercentageOrNumber { +impl ComputeSquaredDistance for SvgLengthPercentageOrNumber { fn compute_squared_distance(&self, other: &Self) -> Result { to_number_or_percentage(self)?.compute_squared_distance(&to_number_or_percentage(other)?) } diff --git a/components/style/values/animated/transform.rs b/components/style/values/animated/transform.rs index 2804f4c0890..c341ca770ed 100644 --- a/components/style/values/animated/transform.rs +++ b/components/style/values/animated/transform.rs @@ -16,7 +16,7 @@ use crate::values::computed::transform::TransformOperation as ComputedTransformO use crate::values::computed::transform::Translate as ComputedTranslate; use crate::values::computed::transform::{DirectionVector, Matrix, Matrix3D}; use crate::values::computed::Angle; -use crate::values::computed::{Length, LengthOrPercentage}; +use crate::values::computed::{Length, LengthPercentage}; use crate::values::computed::{Number, Percentage}; use crate::values::distance::{ComputeSquaredDistance, SquaredDistance}; use crate::values::generics::transform::{self, Transform, TransformOperation}; @@ -1043,8 +1043,8 @@ impl Animate for ComputedTransformOperation { ) => Ok(TransformOperation::Translate( fx.animate(tx, procedure)?, Some( - fy.unwrap_or(LengthOrPercentage::zero()) - .animate(&ty.unwrap_or(LengthOrPercentage::zero()), procedure)?, + fy.unwrap_or(LengthPercentage::zero()) + .animate(&ty.unwrap_or(LengthPercentage::zero()), procedure)?, ), )), (&TransformOperation::TranslateX(ref f), &TransformOperation::TranslateX(ref t)) => { @@ -1383,15 +1383,15 @@ impl ComputeSquaredDistance for ComputedRotate { /// impl ComputedTranslate { - fn resolve(&self) -> (LengthOrPercentage, LengthOrPercentage, Length) { + fn resolve(&self) -> (LengthPercentage, LengthPercentage, Length) { // According to the spec: // https://drafts.csswg.org/css-transforms-2/#individual-transforms // // Unspecified translations default to 0px match *self { Translate::None => ( - LengthOrPercentage::zero(), - LengthOrPercentage::zero(), + LengthPercentage::zero(), + LengthPercentage::zero(), Length::zero(), ), Translate::Translate3D(tx, ty, tz) => (tx, ty, tz), diff --git a/components/style/values/computed/background.rs b/components/style/values/computed/background.rs index 82db7e0fdeb..08f10c9c1ec 100644 --- a/components/style/values/computed/background.rs +++ b/components/style/values/computed/background.rs @@ -4,20 +4,20 @@ //! Computed types for CSS values related to backgrounds. -use crate::values::computed::length::NonNegativeLengthOrPercentageOrAuto; +use crate::values::computed::length::NonNegativeLengthPercentageOrAuto; use crate::values::generics::background::BackgroundSize as GenericBackgroundSize; pub use crate::values::specified::background::BackgroundRepeat; /// A computed value for the `background-size` property. -pub type BackgroundSize = GenericBackgroundSize; +pub type BackgroundSize = GenericBackgroundSize; impl BackgroundSize { /// Returns `auto auto`. pub fn auto() -> Self { GenericBackgroundSize::Explicit { - width: NonNegativeLengthOrPercentageOrAuto::auto(), - height: NonNegativeLengthOrPercentageOrAuto::auto(), + width: NonNegativeLengthPercentageOrAuto::auto(), + height: NonNegativeLengthPercentageOrAuto::auto(), } } } diff --git a/components/style/values/computed/basic_shape.rs b/components/style/values/computed/basic_shape.rs index f808e0bf9f5..9b4be538854 100644 --- a/components/style/values/computed/basic_shape.rs +++ b/components/style/values/computed/basic_shape.rs @@ -8,7 +8,7 @@ //! [basic-shape]: https://drafts.csswg.org/css-shapes/#typedef-basic-shape use crate::values::computed::url::ComputedUrl; -use crate::values::computed::{Image, LengthOrPercentage, NonNegativeLengthOrPercentage}; +use crate::values::computed::{Image, LengthPercentage, NonNegativeLengthPercentage}; use crate::values::generics::basic_shape as generic; use std::fmt::{self, Write}; use style_traits::{CssWriter, ToCss}; @@ -24,25 +24,25 @@ pub type FloatAreaShape = generic::FloatAreaShape; /// A computed basic shape. pub type BasicShape = generic::BasicShape< - LengthOrPercentage, - LengthOrPercentage, - LengthOrPercentage, - NonNegativeLengthOrPercentage, + LengthPercentage, + LengthPercentage, + LengthPercentage, + NonNegativeLengthPercentage, >; /// The computed value of `inset()` -pub type InsetRect = generic::InsetRect; +pub type InsetRect = generic::InsetRect; /// A computed circle. pub type Circle = - generic::Circle; + generic::Circle; /// A computed ellipse. pub type Ellipse = - generic::Ellipse; + generic::Ellipse; /// The computed value of `ShapeRadius` -pub type ShapeRadius = generic::ShapeRadius; +pub type ShapeRadius = generic::ShapeRadius; impl ToCss for Circle { fn to_css(&self, dest: &mut CssWriter) -> fmt::Result diff --git a/components/style/values/computed/border.rs b/components/style/values/computed/border.rs index c6ab4abc5a5..e85b5a3e5d6 100644 --- a/components/style/values/computed/border.rs +++ b/components/style/values/computed/border.rs @@ -4,7 +4,7 @@ //! Computed types for CSS values related to borders. -use crate::values::computed::length::{NonNegativeLength, NonNegativeLengthOrPercentage}; +use crate::values::computed::length::{NonNegativeLength, NonNegativeLengthPercentage}; use crate::values::computed::{NonNegativeNumber, NonNegativeNumberOrPercentage}; use crate::values::generics::border::BorderCornerRadius as GenericBorderCornerRadius; use crate::values::generics::border::BorderImageSideWidth as GenericBorderImageSideWidth; @@ -23,16 +23,16 @@ pub type BorderImageWidth = Rect; /// A computed value for a single side of a `border-image-width` property. pub type BorderImageSideWidth = - GenericBorderImageSideWidth; + GenericBorderImageSideWidth; /// A computed value for the `border-image-slice` property. pub type BorderImageSlice = GenericBorderImageSlice; /// A computed value for the `border-radius` property. -pub type BorderRadius = GenericBorderRadius; +pub type BorderRadius = GenericBorderRadius; /// A computed value for the `border-*-radius` longhand properties. -pub type BorderCornerRadius = GenericBorderCornerRadius; +pub type BorderCornerRadius = GenericBorderCornerRadius; /// A computed value for the `border-spacing` longhand property. pub type BorderSpacing = GenericBorderSpacing; @@ -80,8 +80,8 @@ impl BorderCornerRadius { /// Returns `0 0`. pub fn zero() -> Self { GenericBorderCornerRadius(Size::new( - NonNegativeLengthOrPercentage::zero(), - NonNegativeLengthOrPercentage::zero(), + NonNegativeLengthPercentage::zero(), + NonNegativeLengthPercentage::zero(), )) } } @@ -90,8 +90,8 @@ impl BorderRadius { /// Returns whether all the values are `0px`. pub fn all_zero(&self) -> bool { fn all(corner: &BorderCornerRadius) -> bool { - fn is_zero(l: &NonNegativeLengthOrPercentage) -> bool { - *l == NonNegativeLengthOrPercentage::zero() + fn is_zero(l: &NonNegativeLengthPercentage) -> bool { + *l == NonNegativeLengthPercentage::zero() } is_zero(corner.0.width()) && is_zero(corner.0.height()) } diff --git a/components/style/values/computed/box.rs b/components/style/values/computed/box.rs index 32ac16fb574..381ae7b364e 100644 --- a/components/style/values/computed/box.rs +++ b/components/style/values/computed/box.rs @@ -4,7 +4,7 @@ //! Computed types for box properties. -use crate::values::computed::length::{LengthOrPercentage, NonNegativeLength}; +use crate::values::computed::length::{LengthPercentage, NonNegativeLength}; use crate::values::computed::{Context, Number, ToComputedValue}; use crate::values::generics::box_::AnimationIterationCount as GenericAnimationIterationCount; use crate::values::generics::box_::Perspective as GenericPerspective; @@ -18,7 +18,7 @@ pub use crate::values::specified::box_::{OverscrollBehavior, ScrollSnapType}; pub use crate::values::specified::box_::{TouchAction, TransitionProperty, WillChange}; /// A computed value for the `vertical-align` property. -pub type VerticalAlign = GenericVerticalAlign; +pub type VerticalAlign = GenericVerticalAlign; /// A computed value for the `animation-iteration-count` property. pub type AnimationIterationCount = GenericAnimationIterationCount; diff --git a/components/style/values/computed/flex.rs b/components/style/values/computed/flex.rs index fb65aaeae87..a48d7800752 100644 --- a/components/style/values/computed/flex.rs +++ b/components/style/values/computed/flex.rs @@ -8,7 +8,7 @@ use crate::values::generics::flex::FlexBasis as GenericFlexBasis; /// The `width` value type. #[cfg(feature = "servo")] -pub type Width = crate::values::computed::NonNegativeLengthOrPercentageOrAuto; +pub type Width = crate::values::computed::NonNegativeLengthPercentageOrAuto; /// The `width` value type. #[cfg(feature = "gecko")] diff --git a/components/style/values/computed/gecko.rs b/components/style/values/computed/gecko.rs index bf0e24f67ae..cbe0802eab8 100644 --- a/components/style/values/computed/gecko.rs +++ b/components/style/values/computed/gecko.rs @@ -4,8 +4,8 @@ //! Computed types for legacy Gecko-only properties. -use crate::values::computed::length::LengthOrPercentage; +use crate::values::computed::length::LengthPercentage; use crate::values::generics::gecko::ScrollSnapPoint as GenericScrollSnapPoint; /// A computed type for scroll snap points. -pub type ScrollSnapPoint = GenericScrollSnapPoint; +pub type ScrollSnapPoint = GenericScrollSnapPoint; diff --git a/components/style/values/computed/image.rs b/components/style/values/computed/image.rs index 1c573ac3a2b..749c2e44e3a 100644 --- a/components/style/values/computed/image.rs +++ b/components/style/values/computed/image.rs @@ -10,7 +10,7 @@ use crate::values::computed::position::Position; use crate::values::computed::url::ComputedImageUrl; use crate::values::computed::{Angle, Color, Context}; -use crate::values::computed::{Length, LengthOrPercentage, NumberOrPercentage, ToComputedValue}; +use crate::values::computed::{Length, LengthPercentage, NumberOrPercentage, ToComputedValue}; use crate::values::generics::image::{self as generic, CompatMode}; use crate::values::specified::image::LineDirection as SpecifiedLineDirection; use crate::values::specified::position::{X, Y}; @@ -29,11 +29,11 @@ pub type Image = generic::Image; /// Computed values for a CSS gradient. /// pub type Gradient = - generic::Gradient; + generic::Gradient; /// A computed gradient kind. pub type GradientKind = - generic::GradientKind; + generic::GradientKind; /// A computed gradient line direction. #[derive(Clone, Copy, Debug, MallocSizeOf, PartialEq)] @@ -52,13 +52,13 @@ pub enum LineDirection { } /// A computed radial gradient ending shape. -pub type EndingShape = generic::EndingShape; +pub type EndingShape = generic::EndingShape; /// A computed gradient item. -pub type GradientItem = generic::GradientItem; +pub type GradientItem = generic::GradientItem; /// A computed color stop. -pub type ColorStop = generic::ColorStop; +pub type ColorStop = generic::ColorStop; /// Computed values for `-moz-image-rect(...)`. pub type MozImageRect = generic::MozImageRect; diff --git a/components/style/values/computed/length.rs b/components/style/values/computed/length.rs index 8a9425ee631..3030efa825d 100644 --- a/components/style/values/computed/length.rs +++ b/components/style/values/computed/length.rs @@ -67,9 +67,13 @@ impl ToComputedValue for specified::Length { } } +/// A `` value. This can be either a ``, a +/// ``, or a combination of both via `calc()`. +/// +/// https://drafts.csswg.org/css-values-4/#typedef-length-percentage #[allow(missing_docs)] #[derive(Clone, Copy, Debug, MallocSizeOf, ToAnimatedZero)] -pub struct LengthOrPercentage { +pub struct LengthPercentage { #[animation(constant)] pub clamping_mode: AllowedNumericType, length: Length, @@ -87,19 +91,19 @@ pub struct LengthOrPercentage { } // FIXME(emilio): This is a bit of a hack that can disappear as soon as we share -// representation of LengthOrPercentage with Gecko. The issue here is that Gecko +// representation of LengthPercentage with Gecko. The issue here is that Gecko // uses CalcValue to represent position components, so they always come back as // was_calc == true, and we mess up in the transitions code. // // This was a pre-existing bug, though arguably so only in pretty obscure cases // like calc(0px + 5%) and such. -impl PartialEq for LengthOrPercentage { +impl PartialEq for LengthPercentage { fn eq(&self, other: &Self) -> bool { self.length == other.length && self.percentage == other.percentage } } -impl ComputeSquaredDistance for LengthOrPercentage { +impl ComputeSquaredDistance for LengthPercentage { #[inline] fn compute_squared_distance(&self, other: &Self) -> Result { // FIXME(nox): This looks incorrect to me, to add a distance between lengths @@ -112,8 +116,8 @@ impl ComputeSquaredDistance for LengthOrPercentage { } } -impl LengthOrPercentage { - /// Returns a new `LengthOrPercentage`. +impl LengthPercentage { + /// Returns a new `LengthPercentage`. #[inline] pub fn new(length: Length, percentage: Option) -> Self { Self::with_clamping_mode( @@ -124,12 +128,12 @@ impl LengthOrPercentage { ) } - /// Returns a new `LengthOrPercentage` with zero length and some percentage. + /// Returns a new `LengthPercentage` with zero length and some percentage. pub fn new_percent(percentage: Percentage) -> Self { Self::new(Length::zero(), Some(percentage)) } - /// Returns a new `LengthOrPercentage` with a specific clamping mode. + /// Returns a new `LengthPercentage` with a specific clamping mode. #[inline] pub fn with_clamping_mode( length: Length, @@ -209,23 +213,23 @@ impl LengthOrPercentage { } } -impl ToCss for LengthOrPercentage { +impl ToCss for LengthPercentage { fn to_css(&self, dest: &mut CssWriter) -> fmt::Result where W: Write, { - specified::LengthOrPercentage::from_computed_value(self).to_css(dest) + specified::LengthPercentage::from_computed_value(self).to_css(dest) } } -impl specified::CalcLengthOrPercentage { +impl specified::CalcLengthPercentage { /// Compute the value, zooming any absolute units by the zoom function. fn to_computed_value_with_zoom( &self, context: &Context, zoom_fn: F, base_size: FontBaseSize, - ) -> LengthOrPercentage + ) -> LengthPercentage where F: Fn(Length) -> Length, { @@ -259,7 +263,7 @@ impl specified::CalcLengthOrPercentage { } } - LengthOrPercentage { + LengthPercentage { clamping_mode: self.clamping_mode, length: Length::new(length.min(f32::MAX).max(f32::MIN)), percentage: self.percentage, @@ -272,7 +276,7 @@ impl specified::CalcLengthOrPercentage { &self, context: &Context, base_size: FontBaseSize, - ) -> LengthOrPercentage { + ) -> LengthPercentage { self.to_computed_value_with_zoom( context, |abs| context.maybe_zoom_text(abs.into()).0, @@ -306,17 +310,17 @@ impl specified::CalcLengthOrPercentage { } } -impl ToComputedValue for specified::CalcLengthOrPercentage { - type ComputedValue = LengthOrPercentage; +impl ToComputedValue for specified::CalcLengthPercentage { + type ComputedValue = LengthPercentage; - fn to_computed_value(&self, context: &Context) -> LengthOrPercentage { + fn to_computed_value(&self, context: &Context) -> LengthPercentage { // normal properties don't zoom, and compute em units against the current style's font-size self.to_computed_value_with_zoom(context, |abs| abs, FontBaseSize::CurrentStyle) } #[inline] - fn from_computed_value(computed: &LengthOrPercentage) -> Self { - specified::CalcLengthOrPercentage { + fn from_computed_value(computed: &LengthPercentage) -> Self { + specified::CalcLengthPercentage { clamping_mode: computed.clamping_mode, absolute: Some(AbsoluteLength::from_computed_value(&computed.length)), percentage: computed.percentage, @@ -325,17 +329,17 @@ impl ToComputedValue for specified::CalcLengthOrPercentage { } } -impl LengthOrPercentage { +impl LengthPercentage { #[inline] #[allow(missing_docs)] - pub fn zero() -> LengthOrPercentage { - LengthOrPercentage::new(Length::new(0.), None) + pub fn zero() -> LengthPercentage { + LengthPercentage::new(Length::new(0.), None) } /// 1px length value for SVG defaults #[inline] - pub fn one() -> LengthOrPercentage { - LengthOrPercentage::new(Length::new(1.), None) + pub fn one() -> LengthPercentage { + LengthPercentage::new(Length::new(1.), None) } /// Returns true if the computed value is absolute 0 or 0%. @@ -398,44 +402,44 @@ impl LengthOrPercentage { } } -impl ToComputedValue for specified::LengthOrPercentage { - type ComputedValue = LengthOrPercentage; +impl ToComputedValue for specified::LengthPercentage { + type ComputedValue = LengthPercentage; - fn to_computed_value(&self, context: &Context) -> LengthOrPercentage { + fn to_computed_value(&self, context: &Context) -> LengthPercentage { match *self { - specified::LengthOrPercentage::Length(ref value) => { - LengthOrPercentage::new(value.to_computed_value(context), None) + specified::LengthPercentage::Length(ref value) => { + LengthPercentage::new(value.to_computed_value(context), None) }, - specified::LengthOrPercentage::Percentage(value) => { - LengthOrPercentage::new_percent(value) + specified::LengthPercentage::Percentage(value) => { + LengthPercentage::new_percent(value) }, - specified::LengthOrPercentage::Calc(ref calc) => { + specified::LengthPercentage::Calc(ref calc) => { (**calc).to_computed_value(context) }, } } - fn from_computed_value(computed: &LengthOrPercentage) -> Self { + fn from_computed_value(computed: &LengthPercentage) -> Self { let length = computed.unclamped_length(); if let Some(p) = computed.as_percentage() { - return specified::LengthOrPercentage::Percentage(p) + return specified::LengthPercentage::Percentage(p) } let percentage = computed.percentage; if percentage.is_none() && computed.clamping_mode.clamp(length.px()) == length.px() { - return specified::LengthOrPercentage::Length( + return specified::LengthPercentage::Length( ToComputedValue::from_computed_value(&length) ) } - specified::LengthOrPercentage::Calc(Box::new( + specified::LengthPercentage::Calc(Box::new( ToComputedValue::from_computed_value(computed), )) } } -impl IsZeroLength for LengthOrPercentage { +impl IsZeroLength for LengthPercentage { #[inline] fn is_zero_length(&self) -> bool { self.is_definitely_zero() @@ -445,39 +449,39 @@ impl IsZeroLength for LengthOrPercentage { #[allow(missing_docs)] #[css(derive_debug)] #[derive(Animate, Clone, ComputeSquaredDistance, Copy, MallocSizeOf, PartialEq, ToAnimatedZero, ToCss)] -pub enum LengthOrPercentageOrAuto { - LengthOrPercentage(LengthOrPercentage), +pub enum LengthPercentageOrAuto { + LengthPercentage(LengthPercentage), Auto, } -impl LengthOrPercentageOrAuto { +impl LengthPercentageOrAuto { /// Returns the `0` value. #[inline] pub fn zero() -> Self { - LengthOrPercentageOrAuto::LengthOrPercentage(LengthOrPercentage::zero()) + LengthPercentageOrAuto::LengthPercentage(LengthPercentage::zero()) } } -/// A wrapper of LengthOrPercentageOrAuto, whose value must be >= 0. -pub type NonNegativeLengthOrPercentageOrAuto = NonNegative; +/// A wrapper of LengthPercentageOrAuto, whose value must be >= 0. +pub type NonNegativeLengthPercentageOrAuto = NonNegative; -impl IsAuto for NonNegativeLengthOrPercentageOrAuto { +impl IsAuto for NonNegativeLengthPercentageOrAuto { #[inline] fn is_auto(&self) -> bool { *self == Self::auto() } } -impl NonNegativeLengthOrPercentageOrAuto { +impl NonNegativeLengthPercentageOrAuto { /// `auto` #[inline] pub fn auto() -> Self { - NonNegative(LengthOrPercentageOrAuto::Auto) + NonNegative(LengthPercentageOrAuto::Auto) } } -impl ToAnimatedValue for NonNegativeLengthOrPercentageOrAuto { - type AnimatedValue = LengthOrPercentageOrAuto; +impl ToAnimatedValue for NonNegativeLengthPercentageOrAuto { + type AnimatedValue = LengthPercentageOrAuto; #[inline] fn to_animated_value(self) -> Self::AnimatedValue { @@ -490,48 +494,48 @@ impl ToAnimatedValue for NonNegativeLengthOrPercentageOrAuto { } } -impl LengthOrPercentageOrAuto { +impl LengthPercentageOrAuto { /// Returns true if the computed value is absolute 0 or 0%. #[inline] pub fn is_definitely_zero(&self) -> bool { - use self::LengthOrPercentageOrAuto::*; + use self::LengthPercentageOrAuto::*; match *self { - LengthOrPercentage(ref l) => l.is_definitely_zero(), + LengthPercentage(ref l) => l.is_definitely_zero(), Auto => false, } } /// Clamps the value to a non-negative value. pub fn clamp_to_non_negative(self) -> Self { - use self::LengthOrPercentageOrAuto::*; + use self::LengthPercentageOrAuto::*; match self { - LengthOrPercentage(l) => LengthOrPercentage(l.clamp_to_non_negative()), + LengthPercentage(l) => LengthPercentage(l.clamp_to_non_negative()), Auto => Auto, } } } -impl ToComputedValue for specified::LengthOrPercentageOrAuto { - type ComputedValue = LengthOrPercentageOrAuto; +impl ToComputedValue for specified::LengthPercentageOrAuto { + type ComputedValue = LengthPercentageOrAuto; #[inline] - fn to_computed_value(&self, context: &Context) -> LengthOrPercentageOrAuto { + fn to_computed_value(&self, context: &Context) -> LengthPercentageOrAuto { match *self { - specified::LengthOrPercentageOrAuto::LengthOrPercentage(ref value) => { - LengthOrPercentageOrAuto::LengthOrPercentage( + specified::LengthPercentageOrAuto::LengthPercentage(ref value) => { + LengthPercentageOrAuto::LengthPercentage( value.to_computed_value(context), ) }, - specified::LengthOrPercentageOrAuto::Auto => LengthOrPercentageOrAuto::Auto, + specified::LengthPercentageOrAuto::Auto => LengthPercentageOrAuto::Auto, } } #[inline] - fn from_computed_value(computed: &LengthOrPercentageOrAuto) -> Self { + fn from_computed_value(computed: &LengthPercentageOrAuto) -> Self { match *computed { - LengthOrPercentageOrAuto::Auto => specified::LengthOrPercentageOrAuto::Auto, - LengthOrPercentageOrAuto::LengthOrPercentage(ref value) => { - specified::LengthOrPercentageOrAuto::LengthOrPercentage( + LengthPercentageOrAuto::Auto => specified::LengthPercentageOrAuto::Auto, + LengthPercentageOrAuto::LengthPercentage(ref value) => { + specified::LengthPercentageOrAuto::LengthPercentage( ToComputedValue::from_computed_value(value), ) }, @@ -542,17 +546,17 @@ impl ToComputedValue for specified::LengthOrPercentageOrAuto { #[allow(missing_docs)] #[css(derive_debug)] #[derive(Animate, Clone, ComputeSquaredDistance, Copy, MallocSizeOf, PartialEq, ToAnimatedZero, ToCss)] -pub enum LengthOrPercentageOrNone { - LengthOrPercentage(LengthOrPercentage), +pub enum LengthPercentageOrNone { + LengthPercentage(LengthPercentage), None, } -impl LengthOrPercentageOrNone { +impl LengthPercentageOrNone { /// Returns the used value. pub fn to_used_value(&self, containing_length: Au) -> Option { match *self { - LengthOrPercentageOrNone::None => None, - LengthOrPercentageOrNone::LengthOrPercentage(ref lop) => { + LengthPercentageOrNone::None => None, + LengthPercentageOrNone::LengthPercentage(ref lop) => { Some(lop.to_used_value(containing_length)) }, } @@ -560,25 +564,25 @@ impl LengthOrPercentageOrNone { } // FIXME(emilio): Derive this. -impl ToComputedValue for specified::LengthOrPercentageOrNone { - type ComputedValue = LengthOrPercentageOrNone; +impl ToComputedValue for specified::LengthPercentageOrNone { + type ComputedValue = LengthPercentageOrNone; #[inline] - fn to_computed_value(&self, context: &Context) -> LengthOrPercentageOrNone { + fn to_computed_value(&self, context: &Context) -> LengthPercentageOrNone { match *self { - specified::LengthOrPercentageOrNone::LengthOrPercentage(ref value) => { - LengthOrPercentageOrNone::LengthOrPercentage(value.to_computed_value(context)) + specified::LengthPercentageOrNone::LengthPercentage(ref value) => { + LengthPercentageOrNone::LengthPercentage(value.to_computed_value(context)) }, - specified::LengthOrPercentageOrNone::None => LengthOrPercentageOrNone::None, + specified::LengthPercentageOrNone::None => LengthPercentageOrNone::None, } } #[inline] - fn from_computed_value(computed: &LengthOrPercentageOrNone) -> Self { + fn from_computed_value(computed: &LengthPercentageOrNone) -> Self { match *computed { - LengthOrPercentageOrNone::None => specified::LengthOrPercentageOrNone::None, - LengthOrPercentageOrNone::LengthOrPercentage(value) => { - specified::LengthOrPercentageOrNone::LengthOrPercentage( + LengthPercentageOrNone::None => specified::LengthPercentageOrNone::None, + LengthPercentageOrNone::LengthPercentage(value) => { + specified::LengthPercentageOrNone::LengthPercentage( ToComputedValue::from_computed_value(&value), ) }, @@ -586,11 +590,11 @@ impl ToComputedValue for specified::LengthOrPercentageOrNone { } } -/// A wrapper of LengthOrPercentage, whose value must be >= 0. -pub type NonNegativeLengthOrPercentage = NonNegative; +/// A wrapper of LengthPercentage, whose value must be >= 0. +pub type NonNegativeLengthPercentage = NonNegative; -impl ToAnimatedValue for NonNegativeLengthOrPercentage { - type AnimatedValue = LengthOrPercentage; +impl ToAnimatedValue for NonNegativeLengthPercentage { + type AnimatedValue = LengthPercentage; #[inline] fn to_animated_value(self) -> Self::AnimatedValue { @@ -603,41 +607,41 @@ impl ToAnimatedValue for NonNegativeLengthOrPercentage { } } -impl From for NonNegativeLengthOrPercentage { +impl From for NonNegativeLengthPercentage { #[inline] fn from(length: NonNegativeLength) -> Self { - LengthOrPercentage::new(length.0, None).into() + LengthPercentage::new(length.0, None).into() } } -impl From for NonNegativeLengthOrPercentage { +impl From for NonNegativeLengthPercentage { #[inline] - fn from(lop: LengthOrPercentage) -> Self { - NonNegative::(lop) + fn from(lop: LengthPercentage) -> Self { + NonNegative::(lop) } } -impl From for LengthOrPercentage { +impl From for LengthPercentage { #[inline] - fn from(lop: NonNegativeLengthOrPercentage) -> LengthOrPercentage { + fn from(lop: NonNegativeLengthPercentage) -> LengthPercentage { lop.0 } } // TODO(emilio): This is a really generic impl which is only needed to implement // Animated and co for Spacing<>. Get rid of this, probably? -impl From for LengthOrPercentage { +impl From for LengthPercentage { #[inline] fn from(length: Au) -> Self { - LengthOrPercentage::new(length.into(), None) + LengthPercentage::new(length.into(), None) } } -impl NonNegativeLengthOrPercentage { +impl NonNegativeLengthPercentage { /// Get zero value. #[inline] pub fn zero() -> Self { - NonNegative::(LengthOrPercentage::zero()) + NonNegative::(LengthPercentage::zero()) } /// Returns true if the computed value is absolute 0 or 0%. @@ -850,8 +854,8 @@ pub type NonNegativeLengthOrAuto = Either; /// Either a computed NonNegativeLength or the `normal` keyword. pub type NonNegativeLengthOrNormal = Either; -/// Either a computed NonNegativeLengthOrPercentage or the `normal` keyword. -pub type NonNegativeLengthOrPercentageOrNormal = Either; +/// Either a computed NonNegativeLengthPercentage or the `normal` keyword. +pub type NonNegativeLengthPercentageOrNormal = Either; /// A type for possible values for min- and max- flavors of width, height, /// block-size, and inline-size. @@ -881,23 +885,23 @@ pub enum ExtremumLength { } /// A computed value for `min-width`, `min-height`, `width` or `height` property. -pub type MozLength = GenericMozLength; +pub type MozLength = GenericMozLength; impl MozLength { /// Returns the `auto` value. #[inline] pub fn auto() -> Self { - GenericMozLength::LengthOrPercentageOrAuto(LengthOrPercentageOrAuto::Auto) + GenericMozLength::LengthPercentageOrAuto(LengthPercentageOrAuto::Auto) } } /// A computed value for `max-width` or `min-height` property. -pub type MaxLength = GenericMaxLength; +pub type MaxLength = GenericMaxLength; impl MaxLength { /// Returns the `none` value. #[inline] pub fn none() -> Self { - GenericMaxLength::LengthOrPercentageOrNone(LengthOrPercentageOrNone::None) + GenericMaxLength::LengthPercentageOrNone(LengthPercentageOrNone::None) } } diff --git a/components/style/values/computed/mod.rs b/components/style/values/computed/mod.rs index 7877fddc192..c389e1d1267 100644 --- a/components/style/values/computed/mod.rs +++ b/components/style/values/computed/mod.rs @@ -62,9 +62,9 @@ pub use self::font::{MozScriptLevel, MozScriptMinSize, MozScriptSizeMultiplier, pub use self::gecko::ScrollSnapPoint; pub use self::image::{Gradient, GradientItem, Image, ImageLayer, LineDirection, MozImageRect}; pub use self::length::{CSSPixelLength, ExtremumLength, NonNegativeLength}; -pub use self::length::{Length, LengthOrNumber, LengthOrPercentage}; -pub use self::length::{LengthOrPercentageOrAuto, LengthOrPercentageOrNone, MaxLength, MozLength}; -pub use self::length::{NonNegativeLengthOrPercentage, NonNegativeLengthOrPercentageOrAuto}; +pub use self::length::{Length, LengthOrNumber, LengthPercentage}; +pub use self::length::{LengthPercentageOrAuto, LengthPercentageOrNone, MaxLength, MozLength}; +pub use self::length::{NonNegativeLengthPercentage, NonNegativeLengthPercentageOrAuto}; #[cfg(feature = "gecko")] pub use self::list::ListStyleType; pub use self::list::{QuotePair, Quotes}; @@ -689,20 +689,20 @@ impl ToCss for ClipRect { pub type ClipRectOrAuto = Either; /// The computed value of a grid `` -pub type TrackBreadth = GenericTrackBreadth; +pub type TrackBreadth = GenericTrackBreadth; /// The computed value of a grid `` -pub type TrackSize = GenericTrackSize; +pub type TrackSize = GenericTrackSize; /// The computed value of a grid `` /// (could also be `` or ``) -pub type TrackList = GenericTrackList; +pub type TrackList = GenericTrackList; /// The computed value of a ``. pub type GridLine = GenericGridLine; /// ` | ` -pub type GridTemplateComponent = GenericGridTemplateComponent; +pub type GridTemplateComponent = GenericGridTemplateComponent; impl ClipRectOrAuto { /// Return an auto (default for clip-rect and image-region) value diff --git a/components/style/values/computed/position.rs b/components/style/values/computed/position.rs index 7bcdb59f89e..d6f9161903b 100644 --- a/components/style/values/computed/position.rs +++ b/components/style/values/computed/position.rs @@ -7,7 +7,7 @@ //! //! [position]: https://drafts.csswg.org/css-backgrounds-3/#position -use crate::values::computed::{Integer, LengthOrPercentage, Percentage}; +use crate::values::computed::{Integer, LengthPercentage, Percentage}; use crate::values::generics::position::Position as GenericPosition; use crate::values::generics::position::ZIndex as GenericZIndex; pub use crate::values::specified::position::{GridAutoFlow, GridTemplateAreas}; @@ -18,25 +18,25 @@ use style_traits::{CssWriter, ToCss}; pub type Position = GenericPosition; /// The computed value of a CSS horizontal position. -pub type HorizontalPosition = LengthOrPercentage; +pub type HorizontalPosition = LengthPercentage; /// The computed value of a CSS vertical position. -pub type VerticalPosition = LengthOrPercentage; +pub type VerticalPosition = LengthPercentage; impl Position { /// `50% 50%` #[inline] pub fn center() -> Self { Self::new( - LengthOrPercentage::new_percent(Percentage(0.5)), - LengthOrPercentage::new_percent(Percentage(0.5)), + LengthPercentage::new_percent(Percentage(0.5)), + LengthPercentage::new_percent(Percentage(0.5)), ) } /// `0% 0%` #[inline] pub fn zero() -> Self { - Self::new(LengthOrPercentage::zero(), LengthOrPercentage::zero()) + Self::new(LengthPercentage::zero(), LengthPercentage::zero()) } } diff --git a/components/style/values/computed/svg.rs b/components/style/values/computed/svg.rs index 02583189e4f..f3ca86aa5b0 100644 --- a/components/style/values/computed/svg.rs +++ b/components/style/values/computed/svg.rs @@ -6,7 +6,7 @@ use crate::values::computed::color::Color; use crate::values::computed::url::ComputedUrl; -use crate::values::computed::{LengthOrPercentage, NonNegativeLengthOrPercentage}; +use crate::values::computed::{LengthPercentage, NonNegativeLengthPercentage}; use crate::values::computed::{NonNegativeNumber, Number, Opacity}; use crate::values::generics::svg as generic; use crate::values::RGBA; @@ -42,56 +42,56 @@ impl SVGPaint { /// A value of | | for stroke-dashoffset. /// -pub type SvgLengthOrPercentageOrNumber = - generic::SvgLengthOrPercentageOrNumber; +pub type SvgLengthPercentageOrNumber = + generic::SvgLengthPercentageOrNumber; /// | | | context-value -pub type SVGLength = generic::SVGLength; +pub type SVGLength = generic::SVGLength; impl SVGLength { /// `0px` pub fn zero() -> Self { - generic::SVGLength::Length(generic::SvgLengthOrPercentageOrNumber::LengthOrPercentage( - LengthOrPercentage::zero(), + generic::SVGLength::Length(generic::SvgLengthPercentageOrNumber::LengthPercentage( + LengthPercentage::zero(), )) } } /// A value of | | for stroke-width/stroke-dasharray. /// -pub type NonNegativeSvgLengthOrPercentageOrNumber = - generic::SvgLengthOrPercentageOrNumber; +pub type NonNegativeSvgLengthPercentageOrNumber = + generic::SvgLengthPercentageOrNumber; // FIXME(emilio): This is really hacky, and can go away with a bit of work on // the clone_stroke_width code in gecko.mako.rs. -impl Into for SvgLengthOrPercentageOrNumber { - fn into(self) -> NonNegativeSvgLengthOrPercentageOrNumber { +impl Into for SvgLengthPercentageOrNumber { + fn into(self) -> NonNegativeSvgLengthPercentageOrNumber { match self { - generic::SvgLengthOrPercentageOrNumber::LengthOrPercentage(lop) => { - generic::SvgLengthOrPercentageOrNumber::LengthOrPercentage(lop.into()) + generic::SvgLengthPercentageOrNumber::LengthPercentage(lop) => { + generic::SvgLengthPercentageOrNumber::LengthPercentage(lop.into()) }, - generic::SvgLengthOrPercentageOrNumber::Number(num) => { - generic::SvgLengthOrPercentageOrNumber::Number(num.into()) + generic::SvgLengthPercentageOrNumber::Number(num) => { + generic::SvgLengthPercentageOrNumber::Number(num.into()) }, } } } /// An non-negative wrapper of SVGLength. -pub type SVGWidth = generic::SVGLength; +pub type SVGWidth = generic::SVGLength; impl SVGWidth { /// `1px`. pub fn one() -> Self { use crate::values::generics::NonNegative; - generic::SVGLength::Length(generic::SvgLengthOrPercentageOrNumber::LengthOrPercentage( - NonNegative(LengthOrPercentage::one()), + generic::SVGLength::Length(generic::SvgLengthPercentageOrNumber::LengthPercentage( + NonNegative(LengthPercentage::one()), )) } } /// [ | | ]# | context-value -pub type SVGStrokeDashArray = generic::SVGStrokeDashArray; +pub type SVGStrokeDashArray = generic::SVGStrokeDashArray; impl Default for SVGStrokeDashArray { fn default() -> Self { diff --git a/components/style/values/computed/text.rs b/components/style/values/computed/text.rs index ce5545308b0..030a6df6cff 100644 --- a/components/style/values/computed/text.rs +++ b/components/style/values/computed/text.rs @@ -6,7 +6,7 @@ #[cfg(feature = "servo")] use crate::properties::StyleBuilder; -use crate::values::computed::length::{Length, LengthOrPercentage}; +use crate::values::computed::length::{Length, LengthPercentage}; use crate::values::computed::{NonNegativeLength, NonNegativeNumber}; use crate::values::generics::text::InitialLetter as GenericInitialLetter; use crate::values::generics::text::LineHeight as GenericLineHeight; @@ -29,7 +29,7 @@ pub type InitialLetter = GenericInitialLetter; pub type LetterSpacing = Spacing; /// A computed value for the `word-spacing` property. -pub type WordSpacing = Spacing; +pub type WordSpacing = Spacing; /// A computed value for the `line-height` property. pub type LineHeight = GenericLineHeight; diff --git a/components/style/values/computed/transform.rs b/components/style/values/computed/transform.rs index 14115295213..979886aa996 100644 --- a/components/style/values/computed/transform.rs +++ b/components/style/values/computed/transform.rs @@ -7,7 +7,7 @@ use super::CSSFloat; use crate::values::animated::transform::{Perspective, Scale3D, Translate3D}; use crate::values::animated::ToAnimatedZero; -use crate::values::computed::{Angle, Integer, Length, LengthOrPercentage, Number, Percentage}; +use crate::values::computed::{Angle, Integer, Length, LengthPercentage, Number, Percentage}; use crate::values::generics::transform as generic; use euclid::{Transform3D, Vector3D}; use num_traits::Zero; @@ -16,12 +16,12 @@ pub use crate::values::generics::transform::TransformStyle; /// A single operation in a computed CSS `transform` pub type TransformOperation = - generic::TransformOperation; + generic::TransformOperation; /// A computed CSS `transform` pub type Transform = generic::Transform; /// The computed value of a CSS `` -pub type TransformOrigin = generic::TransformOrigin; +pub type TransformOrigin = generic::TransformOrigin; /// A vector to represent the direction vector (rotate axis) for Rotate3D. pub type DirectionVector = Vector3D; @@ -31,8 +31,8 @@ impl TransformOrigin { #[inline] pub fn initial_value() -> Self { Self::new( - LengthOrPercentage::new_percent(Percentage(0.5)), - LengthOrPercentage::new_percent(Percentage(0.5)), + LengthPercentage::new_percent(Percentage(0.5)), + LengthPercentage::new_percent(Percentage(0.5)), Length::new(0.), ) } @@ -374,7 +374,7 @@ impl TransformOperation { generic::TransformOperation::Translate(ref x, None) => { generic::TransformOperation::Translate3D( x.clone(), - LengthOrPercentage::zero(), + LengthPercentage::zero(), Length::zero(), ) }, @@ -383,15 +383,15 @@ impl TransformOperation { }, generic::TransformOperation::TranslateY(ref y) => { generic::TransformOperation::Translate3D( - LengthOrPercentage::zero(), + LengthPercentage::zero(), y.clone(), Length::zero(), ) }, generic::TransformOperation::TranslateZ(ref z) => { generic::TransformOperation::Translate3D( - LengthOrPercentage::zero(), - LengthOrPercentage::zero(), + LengthPercentage::zero(), + LengthPercentage::zero(), z.clone(), ) }, @@ -576,7 +576,7 @@ impl Rotate { } /// A computed CSS `translate` -pub type Translate = generic::Translate; +pub type Translate = generic::Translate; impl Translate { /// Convert TransformOperation to Translate. diff --git a/components/style/values/generics/background.rs b/components/style/values/generics/background.rs index 68bd08b29dd..4a7ee4b9b95 100644 --- a/components/style/values/generics/background.rs +++ b/components/style/values/generics/background.rs @@ -22,13 +22,13 @@ use style_traits::{CssWriter, ToCss}; ToAnimatedZero, ToComputedValue, )] -pub enum BackgroundSize { +pub enum BackgroundSize { /// ` ` Explicit { /// Explicit width. - width: LengthOrPercentageOrAuto, + width: LengthPercentageOrAuto, /// Explicit height. - height: LengthOrPercentageOrAuto, + height: LengthPercentageOrAuto, }, /// `cover` #[animation(error)] @@ -38,9 +38,9 @@ pub enum BackgroundSize { Contain, } -impl ToCss for BackgroundSize +impl ToCss for BackgroundSize where - LengthOrPercentageOrAuto: ToCss + IsAuto, + LengthPercentageOrAuto: ToCss + IsAuto, { fn to_css(&self, dest: &mut CssWriter) -> fmt::Result where diff --git a/components/style/values/generics/basic_shape.rs b/components/style/values/generics/basic_shape.rs index bfe709ceb4b..f224f936ccb 100644 --- a/components/style/values/generics/basic_shape.rs +++ b/components/style/values/generics/basic_shape.rs @@ -104,11 +104,11 @@ pub enum ShapeSource { ToComputedValue, ToCss, )] -pub enum BasicShape { - Inset(#[css(field_bound)] InsetRect), - Circle(#[css(field_bound)] Circle), - Ellipse(#[css(field_bound)] Ellipse), - Polygon(Polygon), +pub enum BasicShape { + Inset(#[css(field_bound)] InsetRect), + Circle(#[css(field_bound)] Circle), + Ellipse(#[css(field_bound)] Ellipse), + Polygon(Polygon), } /// @@ -125,9 +125,9 @@ pub enum BasicShape { ToAnimatedValue, ToComputedValue, )] -pub struct InsetRect { - pub rect: Rect, - pub round: Option>, +pub struct InsetRect { + pub rect: Rect, + pub round: Option>, } /// @@ -145,9 +145,9 @@ pub struct InsetRect { ToAnimatedValue, ToComputedValue, )] -pub struct Circle { +pub struct Circle { pub position: Position, - pub radius: ShapeRadius, + pub radius: ShapeRadius, } /// @@ -165,10 +165,10 @@ pub struct Circle { ToAnimatedValue, ToComputedValue, )] -pub struct Ellipse { +pub struct Ellipse { pub position: Position, - pub semiaxis_x: ShapeRadius, - pub semiaxis_y: ShapeRadius, + pub semiaxis_x: ShapeRadius, + pub semiaxis_y: ShapeRadius, } /// @@ -186,8 +186,8 @@ pub struct Ellipse { ToComputedValue, ToCss, )] -pub enum ShapeRadius { - Length(NonNegativeLengthOrPercentage), +pub enum ShapeRadius { + Length(NonNegativeLengthPercentage), #[animation(error)] ClosestSide, #[animation(error)] @@ -208,13 +208,13 @@ pub enum ShapeRadius { ToComputedValue, ToCss, )] -pub struct Polygon { +pub struct Polygon { /// The filling rule for a polygon. #[css(skip_if = "fill_is_default")] pub fill: FillRule, /// A collection of (x, y) coordinates to draw the polygon. #[css(iterable)] - pub coordinates: Vec>, + pub coordinates: Vec>, } /// Coordinates for Polygon. @@ -228,7 +228,7 @@ pub struct Polygon { ToComputedValue, ToCss, )] -pub struct PolygonCoord(pub LengthOrPercentage, pub LengthOrPercentage); +pub struct PolygonCoord(pub LengthPercentage, pub LengthPercentage); // https://drafts.csswg.org/css-shapes/#typedef-fill-rule // NOTE: Basic shapes spec says that these are the only two values, however diff --git a/components/style/values/generics/border.rs b/components/style/values/generics/border.rs index 20274816615..0a1cef3b4bb 100644 --- a/components/style/values/generics/border.rs +++ b/components/style/values/generics/border.rs @@ -13,9 +13,9 @@ use style_traits::{CssWriter, ToCss}; #[derive( Clone, Copy, Debug, MallocSizeOf, PartialEq, SpecifiedValueInfo, ToComputedValue, ToCss, )] -pub enum BorderImageSideWidth { +pub enum BorderImageSideWidth { /// `` - Length(LengthOrPercentage), + Length(LengthPercentage), /// `` Number(Number), /// `auto` @@ -98,15 +98,15 @@ impl BorderSpacing { ToAnimatedValue, ToComputedValue, )] -pub struct BorderRadius { +pub struct BorderRadius { /// The top left radius. - pub top_left: BorderCornerRadius, + pub top_left: BorderCornerRadius, /// The top right radius. - pub top_right: BorderCornerRadius, + pub top_right: BorderCornerRadius, /// The bottom right radius. - pub bottom_right: BorderCornerRadius, + pub bottom_right: BorderCornerRadius, /// The bottom left radius. - pub bottom_left: BorderCornerRadius, + pub bottom_left: BorderCornerRadius, } impl BorderRadius { diff --git a/components/style/values/generics/box.rs b/components/style/values/generics/box.rs index 1c40702dd6c..8a8dc58fd92 100644 --- a/components/style/values/generics/box.rs +++ b/components/style/values/generics/box.rs @@ -19,7 +19,7 @@ use crate::values::animated::ToAnimatedZero; ToComputedValue, ToCss, )] -pub enum VerticalAlign { +pub enum VerticalAlign { /// `baseline` Baseline, /// `sub` @@ -40,7 +40,7 @@ pub enum VerticalAlign { #[cfg(feature = "gecko")] MozMiddleWithBaseline, /// `` - Length(LengthOrPercentage), + Length(LengthPercentage), } impl VerticalAlign { diff --git a/components/style/values/generics/gecko.rs b/components/style/values/generics/gecko.rs index e8bddc871f9..fb84fdf4acc 100644 --- a/components/style/values/generics/gecko.rs +++ b/components/style/values/generics/gecko.rs @@ -8,12 +8,12 @@ /// A generic value for scroll snap points. #[cfg_attr(feature = "gecko", derive(MallocSizeOf))] #[derive(Clone, Copy, Debug, PartialEq, SpecifiedValueInfo, ToComputedValue, ToCss)] -pub enum ScrollSnapPoint { +pub enum ScrollSnapPoint { /// `none` None, /// `repeat()` #[css(function)] - Repeat(LengthOrPercentage), + Repeat(LengthPercentage), } impl ScrollSnapPoint { diff --git a/components/style/values/generics/grid.rs b/components/style/values/generics/grid.rs index 9944ef6a212..400b04cae61 100644 --- a/components/style/values/generics/grid.rs +++ b/components/style/values/generics/grid.rs @@ -482,11 +482,11 @@ impl TrackRepeat { /// Track list values. Can be or #[derive(Clone, Debug, MallocSizeOf, PartialEq, SpecifiedValueInfo, ToComputedValue, ToCss)] -pub enum TrackListValue { +pub enum TrackListValue { /// A value. - TrackSize(TrackSize), + TrackSize(TrackSize), /// A value. - TrackRepeat(TrackRepeat), + TrackRepeat(TrackRepeat), } /// The type of a `` as determined during parsing. @@ -515,7 +515,7 @@ pub enum TrackListType { /// /// #[derive(Clone, Debug, MallocSizeOf, PartialEq, SpecifiedValueInfo)] -pub struct TrackList { +pub struct TrackList { /// The type of this `` (auto, explicit or general). /// /// In order to avoid parsing the same value multiple times, this does a single traversal @@ -523,7 +523,7 @@ pub struct TrackList { #[css(skip)] pub list_type: TrackListType, /// A vector of ` | ` values. - pub values: Vec>, + pub values: Vec>, /// `` accompanying ` | ` values. /// /// If there's no ``, then it's represented by an empty vector. @@ -531,7 +531,7 @@ pub struct TrackList { /// length is always one value more than that of the ``. pub line_names: Box<[Box<[CustomIdent]>]>, /// `` value. There can only be one `` in a TrackList. - pub auto_repeat: Option>, + pub auto_repeat: Option>, } impl ToCss for TrackList { diff --git a/components/style/values/generics/image.rs b/components/style/values/generics/image.rs index a4bbc2b44d2..44ff903b4f4 100644 --- a/components/style/values/generics/image.rs +++ b/components/style/values/generics/image.rs @@ -37,11 +37,11 @@ pub enum Image { /// A CSS gradient. /// #[derive(Clone, Debug, MallocSizeOf, PartialEq, ToComputedValue)] -pub struct Gradient { +pub struct Gradient { /// Gradients can be linear or radial. - pub kind: GradientKind, + pub kind: GradientKind, /// The color stops and interpolation hints. - pub items: Vec>, + pub items: Vec>, /// True if this is a repeating gradient. pub repeating: bool, /// Compatibility mode. @@ -61,12 +61,12 @@ pub enum CompatMode { /// A gradient kind. #[derive(Clone, Copy, Debug, MallocSizeOf, PartialEq, ToComputedValue)] -pub enum GradientKind { +pub enum GradientKind { /// A linear gradient. Linear(LineDirection), /// A radial gradient. Radial( - EndingShape, + EndingShape, Position, Option, ), @@ -74,11 +74,11 @@ pub enum GradientKind { +pub enum EndingShape { /// A circular gradient. Circle(Circle), /// An elliptic gradient. - Ellipse(Ellipse), + Ellipse(Ellipse), } /// A circle shape. @@ -92,9 +92,9 @@ pub enum Circle { /// An ellipse shape. #[derive(Clone, Copy, Debug, MallocSizeOf, PartialEq, ToComputedValue, ToCss)] -pub enum Ellipse { +pub enum Ellipse { /// An ellipse pair of radii. - Radii(LengthOrPercentage, LengthOrPercentage), + Radii(LengthPercentage, LengthPercentage), /// An ellipse extent. Extent(ShapeExtent), } @@ -115,21 +115,21 @@ pub enum ShapeExtent { /// A gradient item. /// #[derive(Clone, Copy, Debug, MallocSizeOf, PartialEq, ToComputedValue, ToCss)] -pub enum GradientItem { +pub enum GradientItem { /// A color stop. - ColorStop(ColorStop), + ColorStop(ColorStop), /// An interpolation hint. - InterpolationHint(LengthOrPercentage), + InterpolationHint(LengthPercentage), } /// A color stop. /// #[derive(Clone, Copy, Debug, MallocSizeOf, PartialEq, ToComputedValue, ToCss)] -pub struct ColorStop { +pub struct ColorStop { /// The color of this stop. pub color: Color, /// The position of this stop. - pub position: Option, + pub position: Option, } /// Specified values for a paint worklet. diff --git a/components/style/values/generics/length.rs b/components/style/values/generics/length.rs index ade1e4bb3a9..006739462aa 100644 --- a/components/style/values/generics/length.rs +++ b/components/style/values/generics/length.rs @@ -26,8 +26,8 @@ use crate::values::computed::ExtremumLength; ToComputedValue, ToCss, )] -pub enum MozLength { - LengthOrPercentageOrAuto(LengthOrPercentageOrAuto), +pub enum MozLength { + LengthPercentageOrAuto(LengthPercentageOrAuto), #[animation(error)] ExtremumLength(ExtremumLength), } @@ -47,8 +47,8 @@ pub enum MozLength { ToComputedValue, ToCss, )] -pub enum MaxLength { - LengthOrPercentageOrNone(LengthOrPercentageOrNone), +pub enum MaxLength { + LengthPercentageOrNone(LengthPercentageOrNone), #[animation(error)] ExtremumLength(ExtremumLength), } diff --git a/components/style/values/generics/svg.rs b/components/style/values/generics/svg.rs index 0559f8f1514..a96d5221c93 100644 --- a/components/style/values/generics/svg.rs +++ b/components/style/values/generics/svg.rs @@ -142,28 +142,28 @@ impl Parse for SVGPaint { +pub enum SvgLengthPercentageOrNumber { /// | - LengthOrPercentage(LengthOrPercentage), + LengthPercentage(LengthPercentage), /// Number(Number), } -/// Parsing the SvgLengthOrPercentageOrNumber. At first, we need to parse number +/// Parsing the SvgLengthPercentageOrNumber. At first, we need to parse number /// since prevent converting to the length. -impl Parse - for SvgLengthOrPercentageOrNumber +impl Parse + for SvgLengthPercentageOrNumber { fn parse<'i, 't>( context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result> { if let Ok(num) = input.try(|i| NumberType::parse(context, i)) { - return Ok(SvgLengthOrPercentageOrNumber::Number(num)); + return Ok(SvgLengthPercentageOrNumber::Number(num)); } - let lop = LengthOrPercentageType::parse(context, input)?; - Ok(SvgLengthOrPercentageOrNumber::LengthOrPercentage(lop)) + let lop = LengthPercentageType::parse(context, input)?; + Ok(SvgLengthPercentageOrNumber::LengthPercentage(lop)) } } diff --git a/components/style/values/generics/text.rs b/components/style/values/generics/text.rs index 2ee92513cf9..5a4f9213908 100644 --- a/components/style/values/generics/text.rs +++ b/components/style/values/generics/text.rs @@ -123,7 +123,7 @@ impl ToAnimatedZero for Spacing { ToAnimatedValue, ToCss, )] -pub enum LineHeight { +pub enum LineHeight { /// `normal` Normal, /// `-moz-block-height` @@ -132,7 +132,7 @@ pub enum LineHeight { /// `` Number(Number), /// `` - Length(LengthOrPercentage), + Length(LengthPercentage), } impl ToAnimatedZero for LineHeight { diff --git a/components/style/values/generics/transform.rs b/components/style/values/generics/transform.rs index d4b69b02e72..87f26efa0d9 100644 --- a/components/style/values/generics/transform.rs +++ b/components/style/values/generics/transform.rs @@ -5,10 +5,10 @@ //! Generic types for CSS values that are related to transformations. use crate::values::computed::length::Length as ComputedLength; -use crate::values::computed::length::LengthOrPercentage as ComputedLengthOrPercentage; +use crate::values::computed::length::LengthPercentage as ComputedLengthPercentage; use crate::values::specified::angle::Angle as SpecifiedAngle; use crate::values::specified::length::Length as SpecifiedLength; -use crate::values::specified::length::LengthOrPercentage as SpecifiedLengthOrPercentage; +use crate::values::specified::length::LengthPercentage as SpecifiedLengthPercentage; use crate::values::{computed, CSSFloat}; use app_units::Au; use euclid::{self, Rect, Transform3D}; @@ -105,7 +105,7 @@ impl TransformOrigin { #[derive(Clone, Debug, MallocSizeOf, PartialEq, SpecifiedValueInfo, ToComputedValue, ToCss)] /// A single operation in the list of a `transform` value -pub enum TransformOperation { +pub enum TransformOperation { /// Represents a 2D 2x3 matrix. Matrix(Matrix), /// Represents a 3D 4x4 matrix. @@ -125,19 +125,19 @@ pub enum TransformOperation SkewY(Angle), /// translate(x, y) or translate(x) #[css(comma, function)] - Translate(LengthOrPercentage, Option), + Translate(LengthPercentage, Option), /// translateX(x) #[css(function = "translateX")] - TranslateX(LengthOrPercentage), + TranslateX(LengthPercentage), /// translateY(y) #[css(function = "translateY")] - TranslateY(LengthOrPercentage), + TranslateY(LengthPercentage), /// translateZ(z) #[css(function = "translateZ")] TranslateZ(Length), /// translate3d(x, y, z) #[css(comma, function = "translate3d")] - Translate3D(LengthOrPercentage, LengthOrPercentage, Length), + Translate3D(LengthPercentage, LengthPercentage, Length), /// A 2D scaling factor. /// /// `scale(2)` is parsed as `Scale(Number::new(2.0), None)` and is equivalent to @@ -192,8 +192,8 @@ pub enum TransformOperation #[css(comma, function = "interpolatematrix")] InterpolateMatrix { from_list: - Transform>, - to_list: Transform>, + Transform>, + to_list: Transform>, progress: computed::Percentage, }, /// A intermediate type for accumulation of mismatched transform lists. @@ -201,8 +201,8 @@ pub enum TransformOperation #[css(comma, function = "accumulatematrix")] AccumulateMatrix { from_list: - Transform>, - to_list: Transform>, + Transform>, + to_list: Transform>, count: Integer, }, } @@ -211,8 +211,8 @@ pub enum TransformOperation /// A value of the `transform` property pub struct Transform(#[css(if_empty = "none", iterable)] pub Vec); -impl - TransformOperation +impl + TransformOperation { /// Check if it is any rotate function. pub fn is_rotate(&self) -> bool { @@ -263,13 +263,13 @@ impl ToAbsoluteLength for SpecifiedLength { } } -impl ToAbsoluteLength for SpecifiedLengthOrPercentage { +impl ToAbsoluteLength for SpecifiedLengthPercentage { // This returns Err(()) if there is any relative length or percentage. We use this when // parsing a transform list of DOMMatrix because we want to return a DOM Exception // if there is relative length. #[inline] fn to_pixel_length(&self, _containing_len: Option) -> Result { - use self::SpecifiedLengthOrPercentage::*; + use self::SpecifiedLengthPercentage::*; match *self { Length(len) => len.to_computed_pixel_length_without_context(), Calc(ref calc) => calc.to_computed_pixel_length_without_context(), @@ -285,7 +285,7 @@ impl ToAbsoluteLength for ComputedLength { } } -impl ToAbsoluteLength for ComputedLengthOrPercentage { +impl ToAbsoluteLength for ComputedLengthPercentage { #[inline] fn to_pixel_length(&self, containing_len: Option) -> Result { match containing_len { @@ -633,18 +633,18 @@ impl ToCss for Scale { /// A value of the `Translate` property /// /// -pub enum Translate { +pub enum Translate { /// 'none' None, /// '' or ' ' - Translate(LengthOrPercentage, LengthOrPercentage), + Translate(LengthPercentage, LengthPercentage), /// ' ' - Translate3D(LengthOrPercentage, LengthOrPercentage, Length), + Translate3D(LengthPercentage, LengthPercentage, Length), } /// A trait to check if this is a zero length. /// An alternative way is use num_traits::Zero. However, in order to implement num_traits::Zero, -/// we also have to implement Add, which may be complicated for LengthOrPercentage::Calc. +/// we also have to implement Add, which may be complicated for LengthPercentage::Calc. /// We could do this if other types also need it. If so, we could drop this trait. pub trait IsZeroLength { /// Returns true if this is a zero length. diff --git a/components/style/values/specified/background.rs b/components/style/values/specified/background.rs index d3c1b2c0d14..47c66feaef6 100644 --- a/components/style/values/specified/background.rs +++ b/components/style/values/specified/background.rs @@ -6,24 +6,24 @@ use crate::parser::{Parse, ParserContext}; use crate::values::generics::background::BackgroundSize as GenericBackgroundSize; -use crate::values::specified::length::NonNegativeLengthOrPercentageOrAuto; +use crate::values::specified::length::NonNegativeLengthPercentageOrAuto; use cssparser::Parser; use selectors::parser::SelectorParseErrorKind; use std::fmt::{self, Write}; use style_traits::{CssWriter, ParseError, ToCss}; /// A specified value for the `background-size` property. -pub type BackgroundSize = GenericBackgroundSize; +pub type BackgroundSize = GenericBackgroundSize; impl Parse for BackgroundSize { fn parse<'i, 't>( context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result> { - if let Ok(width) = input.try(|i| NonNegativeLengthOrPercentageOrAuto::parse(context, i)) { + if let Ok(width) = input.try(|i| NonNegativeLengthPercentageOrAuto::parse(context, i)) { let height = input - .try(|i| NonNegativeLengthOrPercentageOrAuto::parse(context, i)) - .unwrap_or(NonNegativeLengthOrPercentageOrAuto::auto()); + .try(|i| NonNegativeLengthPercentageOrAuto::parse(context, i)) + .unwrap_or(NonNegativeLengthPercentageOrAuto::auto()); return Ok(GenericBackgroundSize::Explicit { width, height }); } Ok(try_match_ident_ignore_ascii_case! { input, @@ -37,8 +37,8 @@ impl BackgroundSize { /// Returns `auto auto`. pub fn auto() -> Self { GenericBackgroundSize::Explicit { - width: NonNegativeLengthOrPercentageOrAuto::auto(), - height: NonNegativeLengthOrPercentageOrAuto::auto(), + width: NonNegativeLengthPercentageOrAuto::auto(), + height: NonNegativeLengthPercentageOrAuto::auto(), } } } diff --git a/components/style/values/specified/basic_shape.rs b/components/style/values/specified/basic_shape.rs index 84624671ffe..88c7b384d41 100644 --- a/components/style/values/specified/basic_shape.rs +++ b/components/style/values/specified/basic_shape.rs @@ -17,7 +17,7 @@ use crate::values::specified::image::Image; use crate::values::specified::position::{HorizontalPosition, Position, VerticalPosition}; use crate::values::specified::url::SpecifiedUrl; use crate::values::specified::SVGPathData; -use crate::values::specified::{LengthOrPercentage, NonNegativeLengthOrPercentage}; +use crate::values::specified::{LengthPercentage, NonNegativeLengthPercentage}; use cssparser::Parser; use std::fmt::{self, Write}; use style_traits::{CssWriter, ParseError, StyleParseErrorKind, ToCss}; @@ -35,26 +35,26 @@ pub type FloatAreaShape = generic::FloatAreaShape; pub type BasicShape = generic::BasicShape< HorizontalPosition, VerticalPosition, - LengthOrPercentage, - NonNegativeLengthOrPercentage, + LengthPercentage, + NonNegativeLengthPercentage, >; /// The specified value of `inset()` -pub type InsetRect = generic::InsetRect; +pub type InsetRect = generic::InsetRect; /// A specified circle. pub type Circle = - generic::Circle; + generic::Circle; /// A specified ellipse. pub type Ellipse = - generic::Ellipse; + generic::Ellipse; /// The specified value of `ShapeRadius` -pub type ShapeRadius = generic::ShapeRadius; +pub type ShapeRadius = generic::ShapeRadius; /// The specified value of `Polygon` -pub type Polygon = generic::Polygon; +pub type Polygon = generic::Polygon; #[cfg(feature = "gecko")] fn is_clip_path_path_enabled(context: &ParserContext) -> bool { @@ -200,7 +200,7 @@ impl InsetRect { context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result> { - let rect = Rect::parse_with(context, input, LengthOrPercentage::parse)?; + let rect = Rect::parse_with(context, input, LengthPercentage::parse)?; let round = if input.try(|i| i.expect_ident_matching("round")).is_ok() { Some(BorderRadius::parse(context, input)?) } else { @@ -316,7 +316,7 @@ impl Parse for ShapeRadius { context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result> { - if let Ok(lop) = input.try(|i| NonNegativeLengthOrPercentage::parse(context, i)) { + if let Ok(lop) = input.try(|i| NonNegativeLengthPercentage::parse(context, i)) { return Ok(generic::ShapeRadius::Length(lop)); } @@ -353,8 +353,8 @@ impl Polygon { let buf = input.parse_comma_separated(|i| { Ok(PolygonCoord( - LengthOrPercentage::parse(context, i)?, - LengthOrPercentage::parse(context, i)?, + LengthPercentage::parse(context, i)?, + LengthPercentage::parse(context, i)?, )) })?; diff --git a/components/style/values/specified/border.rs b/components/style/values/specified/border.rs index acd38ea5ba4..c3f1dd6f4af 100644 --- a/components/style/values/specified/border.rs +++ b/components/style/values/specified/border.rs @@ -13,7 +13,7 @@ use crate::values::generics::border::BorderRadius as GenericBorderRadius; use crate::values::generics::border::BorderSpacing as GenericBorderSpacing; use crate::values::generics::rect::Rect; use crate::values::generics::size::Size; -use crate::values::specified::length::{NonNegativeLength, NonNegativeLengthOrPercentage}; +use crate::values::specified::length::{NonNegativeLength, NonNegativeLengthPercentage}; use crate::values::specified::{AllowQuirks, NonNegativeNumber, NonNegativeNumberOrPercentage}; use cssparser::Parser; use std::fmt::{self, Write}; @@ -79,16 +79,16 @@ pub type BorderImageWidth = Rect; /// A specified value for a single side of a `border-image-width` property. pub type BorderImageSideWidth = - GenericBorderImageSideWidth; + GenericBorderImageSideWidth; /// A specified value for the `border-image-slice` property. pub type BorderImageSlice = GenericBorderImageSlice; /// A specified value for the `border-radius` property. -pub type BorderRadius = GenericBorderRadius; +pub type BorderRadius = GenericBorderRadius; /// A specified value for the `border-*-radius` longhand properties. -pub type BorderCornerRadius = GenericBorderCornerRadius; +pub type BorderCornerRadius = GenericBorderCornerRadius; /// A specified value for the `border-spacing` longhand properties. pub type BorderSpacing = GenericBorderSpacing; @@ -178,7 +178,7 @@ impl Parse for BorderImageSideWidth { return Ok(GenericBorderImageSideWidth::Auto); } - if let Ok(len) = input.try(|i| NonNegativeLengthOrPercentage::parse(context, i)) { + if let Ok(len) = input.try(|i| NonNegativeLengthPercentage::parse(context, i)) { return Ok(GenericBorderImageSideWidth::Length(len)); } @@ -206,9 +206,9 @@ impl Parse for BorderRadius { context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result> { - let widths = Rect::parse_with(context, input, NonNegativeLengthOrPercentage::parse)?; + let widths = Rect::parse_with(context, input, NonNegativeLengthPercentage::parse)?; let heights = if input.try(|i| i.expect_delim('/')).is_ok() { - Rect::parse_with(context, input, NonNegativeLengthOrPercentage::parse)? + Rect::parse_with(context, input, NonNegativeLengthPercentage::parse)? } else { widths.clone() }; @@ -227,7 +227,7 @@ impl Parse for BorderCornerRadius { context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result> { - Size::parse_with(context, input, NonNegativeLengthOrPercentage::parse) + Size::parse_with(context, input, NonNegativeLengthPercentage::parse) .map(GenericBorderCornerRadius) } } diff --git a/components/style/values/specified/box.rs b/components/style/values/specified/box.rs index c785fb0c0db..65f66de8129 100644 --- a/components/style/values/specified/box.rs +++ b/components/style/values/specified/box.rs @@ -11,7 +11,7 @@ use crate::properties::{PropertyId, ShorthandId}; use crate::values::generics::box_::AnimationIterationCount as GenericAnimationIterationCount; use crate::values::generics::box_::Perspective as GenericPerspective; use crate::values::generics::box_::VerticalAlign as GenericVerticalAlign; -use crate::values::specified::length::{LengthOrPercentage, NonNegativeLength}; +use crate::values::specified::length::{LengthPercentage, NonNegativeLength}; use crate::values::specified::{AllowQuirks, Number}; use crate::values::{CustomIdent, KeyframesName}; use crate::Atom; @@ -271,7 +271,7 @@ impl Display { } /// A specified value for the `vertical-align` property. -pub type VerticalAlign = GenericVerticalAlign; +pub type VerticalAlign = GenericVerticalAlign; impl Parse for VerticalAlign { fn parse<'i, 't>( @@ -279,7 +279,7 @@ impl Parse for VerticalAlign { input: &mut Parser<'i, 't>, ) -> Result> { if let Ok(lop) = - input.try(|i| LengthOrPercentage::parse_quirky(context, i, AllowQuirks::Yes)) + input.try(|i| LengthPercentage::parse_quirky(context, i, AllowQuirks::Yes)) { return Ok(GenericVerticalAlign::Length(lop)); } diff --git a/components/style/values/specified/calc.rs b/components/style/values/specified/calc.rs index 2fe00ff8799..9e66edd9a9e 100644 --- a/components/style/values/specified/calc.rs +++ b/components/style/values/specified/calc.rs @@ -52,7 +52,7 @@ pub enum CalcUnit { /// `` Percentage, /// ` | ` - LengthOrPercentage, + LengthPercentage, /// `` Angle, /// `