Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix comment and add TODO for webdriver pointermove (#36929)

Browse source 
Testing: No. Just updating comments

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye 2025-05-12 16:20:43 +08:00 • committed by GitHub
parent c0339dd360
commit db83601b62
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/webdriver_server/actions.rs
View file

@ -413,21 +413,21 @@ impl Handler {
// Step 5 - 6 // Step 5 - 6
self.check_viewport_bound(x, y)?; self.check_viewport_bound(x, y)?;
// Step 9 // Step 7
let duration = match action.duration { let duration = match action.duration {
Some(duration) => duration, Some(duration) => duration,
None => tick_duration, None => tick_duration,
}; };
// Step 10 // Step 8
if duration > 0 { if duration > 0 {
thread::sleep(Duration::from_millis(POINTERMOVE_INTERVAL)); thread::sleep(Duration::from_millis(POINTERMOVE_INTERVAL));
} }
// Step 11 // Step 9 - 18
self.perform_pointer_move(source_id, duration, start_x, start_y, x, y, tick_start); self.perform_pointer_move(source_id, duration, start_x, start_y, x, y, tick_start);
// Step 12 // Step 19
Ok(()) Ok(())
} }
@ -482,6 +482,7 @@ impl Handler {
// Step 7.2 // Step 7.2
let cmd_msg = let cmd_msg =
WebDriverCommandMsg::MouseMoveAction(session.webview_id, x as f32, y as f32); WebDriverCommandMsg::MouseMoveAction(session.webview_id, x as f32, y as f32);
//TODO: Need Synchronization here before updating `pointer_input_state`
self.constellation_chan self.constellation_chan
.send(EmbedderToConstellationMessage::WebDriverCommand(cmd_msg)) .send(EmbedderToConstellationMessage::WebDriverCommand(cmd_msg))
.unwrap(); .unwrap();