Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement Node.baseURI

Browse source
This commit is contained in:
Kevin Ball 2015-07-05 15:29:04 -07:00
parent 0fb6604cb3
commit dbbab3b113
4 changed files with 38 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/node.rs
View file

@ -993,7 +993,7 @@ impl<'a> NodeHelpers for &'a Node {
fn summarize(self) -> NodeInfo { fn summarize(self) -> NodeInfo {
NodeInfo { NodeInfo {
uniqueId: self.get_unique_id(), uniqueId: self.get_unique_id(),
baseURI: self.GetBaseURI().unwrap_or("".to_owned()), baseURI: self.BaseURI(),
parent: self.GetParentNode().map(|node| node.r().get_unique_id()).unwrap_or("".to_owned()), parent: self.GetParentNode().map(|node| node.r().get_unique_id()).unwrap_or("".to_owned()),
nodeType: self.NodeType(), nodeType: self.NodeType(),
namespaceURI: "".to_owned(), //FIXME namespaceURI: "".to_owned(), //FIXME
@ -1956,9 +1956,8 @@ impl<'a> NodeMethods for &'a Node {
} }
// https://dom.spec.whatwg.org/#dom-node-baseuri // https://dom.spec.whatwg.org/#dom-node-baseuri
fn GetBaseURI(self) -> Option<DOMString> { fn BaseURI(self) -> DOMString {
// FIXME (#1824) implement. self.owner_doc().URL()
None
} }
// https://dom.spec.whatwg.org/#dom-node-ownerdocument // https://dom.spec.whatwg.org/#dom-node-ownerdocument

2
components/script/dom/webidls/Node.webidl
View file

@ -26,7 +26,7 @@ interface Node : EventTarget {
readonly attribute DOMString nodeName; readonly attribute DOMString nodeName;
[Pure] [Pure]
readonly attribute DOMString? baseURI; readonly attribute DOMString baseURI;
[Pure] [Pure]
readonly attribute Document? ownerDocument; readonly attribute Document? ownerDocument;

4
tests/wpt/metadata/MANIFEST.json
View file

@ -13117,6 +13117,10 @@
"path": "dom/nodes/Node-appendChild.html", "path": "dom/nodes/Node-appendChild.html",
"url": "/dom/nodes/Node-appendChild.html" "url": "/dom/nodes/Node-appendChild.html"
}, },
{
"path": "dom/nodes/Node-baseURI.html",
"url": "/dom/nodes/Node-baseURI.html"
},
{ {
"path": "dom/nodes/Node-childNodes.html", "path": "dom/nodes/Node-childNodes.html",
"url": "/dom/nodes/Node-childNodes.html" "url": "/dom/nodes/Node-childNodes.html"

29
tests/wpt/web-platform-tests/dom/nodes/Node-baseURI.html Normal file
View file

@ -0,0 +1,29 @@
<!DOCTYPE html>
<title>Node.baseURI</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<div id="log"></div>
<script>
test(function() {
var element =document.createElement("div");
document.getElementById("log").appendChild(element);
assert_equals(element.baseURI, document.URL);
}, "For elements belonging to document, baseURI should be document url")
test(function() {
var element =document.createElement("div");
assert_equals(element.baseURI, document.URL);
}, "For elements unassigned to document, baseURI should be document url")
test(function() {
var fragment = document.createDocumentFragment();
var element =document.createElement("div");
fragment.appendChild(element);
assert_equals(element.baseURI, document.URL)
}, "For elements belonging to document fragments, baseURI should be document url")
test(function() {
var fragment = document.createDocumentFragment();
var element =document.createElement("div");
fragment.appendChild(element);
document.getElementById("log").appendChild(fragment);
assert_equals(element.baseURI, document.URL)
}, "After inserting fragment into document, element baseURI should be document url")
</script>