Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement NonElementParentNode for DocumentFragment

Browse source
This commit is contained in:
Anthony Ramine 2015-09-10 01:33:13 +02:00
parent 3f5b3053b9
commit dc125f9eb1
3 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/script/dom/documentfragment.rs
View file

@ -17,6 +17,7 @@ use dom::eventtarget::{EventTarget, EventTargetTypeId};
use dom::htmlcollection::HTMLCollection; use dom::htmlcollection::HTMLCollection;
use dom::node::{Node, NodeTypeId, window_from_node}; use dom::node::{Node, NodeTypeId, window_from_node};
use dom::nodelist::NodeList; use dom::nodelist::NodeList;
use string_cache::Atom;
use util::str::DOMString; use util::str::DOMString;
// https://dom.spec.whatwg.org/#documentfragment // https://dom.spec.whatwg.org/#documentfragment
@ -58,6 +59,18 @@ impl DocumentFragmentMethods for DocumentFragment {
HTMLCollection::children(window.r(), NodeCast::from_ref(self)) HTMLCollection::children(window.r(), NodeCast::from_ref(self))
} }
// https://dom.spec.whatwg.org/#dom-nonelementparentnode-getelementbyid
fn GetElementById(&self, id: DOMString) -> Option<Root<Element>> {
let node = NodeCast::from_ref(self);
let id = Atom::from_slice(&id);
node.traverse_preorder().filter_map(ElementCast::to_root).find(|descendant| {
match descendant.get_attribute(&ns!(""), &atom!(id)) {
None => false,
Some(attr) => *attr.value().as_atom() == id,
}
})
}
// https://dom.spec.whatwg.org/#dom-parentnode-firstelementchild // https://dom.spec.whatwg.org/#dom-parentnode-firstelementchild
fn GetFirstElementChild(&self) -> Option<Root<Element>> { fn GetFirstElementChild(&self) -> Option<Root<Element>> {
NodeCast::from_ref(self).child_elements().next() NodeCast::from_ref(self).child_elements().next()

1
components/script/dom/webidls/DocumentFragment.webidl
View file

@ -8,4 +8,5 @@
interface DocumentFragment : Node { interface DocumentFragment : Node {
}; };
DocumentFragment implements NonElementParentNode;
DocumentFragment implements ParentNode; DocumentFragment implements ParentNode;

9
tests/wpt/metadata/dom/interfaces.html.ini
View file

@ -123,21 +123,12 @@
[DocumentFragment interface: existence and properties of interface object] [DocumentFragment interface: existence and properties of interface object]
expected: FAIL expected: FAIL
[DocumentFragment interface: operation getElementById(DOMString)]
expected: FAIL
[DocumentFragment interface: operation query(DOMString)] [DocumentFragment interface: operation query(DOMString)]
expected: FAIL expected: FAIL
[DocumentFragment interface: operation queryAll(DOMString)] [DocumentFragment interface: operation queryAll(DOMString)]
expected: FAIL expected: FAIL
[DocumentFragment interface: document.createDocumentFragment() must inherit property "getElementById" with the proper type (0)]
expected: FAIL
[DocumentFragment interface: calling getElementById(DOMString) on document.createDocumentFragment() with too few arguments must throw TypeError]
expected: FAIL
[DocumentFragment interface: document.createDocumentFragment() must inherit property "query" with the proper type (7)] [DocumentFragment interface: document.createDocumentFragment() must inherit property "query" with the proper type (7)]
expected: FAIL expected: FAIL