mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
Use a struct variant for clarity
This commit is contained in:
parent
7561f7b83f
commit
dce048dd54
3 changed files with 18 additions and 5 deletions
|
@ -252,7 +252,12 @@ fn run_server(sender: Sender<DevtoolsControlMsg>,
|
|||
let actors = actors.lock().unwrap();
|
||||
let console_actor = actors.find::<ConsoleActor>(&console_actor_name);
|
||||
match console_message {
|
||||
ConsoleMessage::LogMessage(message, filename, lineNumber, columnNumber) => {
|
||||
ConsoleMessage::LogMessage {
|
||||
message,
|
||||
filename,
|
||||
lineNumber,
|
||||
columnNumber,
|
||||
} => {
|
||||
let msg = ConsoleAPICall {
|
||||
from: console_actor.name.clone(),
|
||||
__type__: "consoleAPICall".to_string(),
|
||||
|
|
|
@ -148,9 +148,12 @@ impl Decodable for Modification {
|
|||
//TODO: Include options for Warn, Debug, Info, Error messages from Console
|
||||
#[derive(Clone)]
|
||||
pub enum ConsoleMessage {
|
||||
// Log: message, filename, line number, column number
|
||||
LogMessage(String, String, u32, u32),
|
||||
//WarnMessage(String),
|
||||
LogMessage {
|
||||
message: String,
|
||||
filename: String,
|
||||
lineNumber: u32,
|
||||
columnNumber: u32,
|
||||
},
|
||||
}
|
||||
|
||||
#[derive(Clone)]
|
||||
|
|
|
@ -37,7 +37,12 @@ impl<'a> ConsoleMethods for JSRef<'a, Console> {
|
|||
for message in messages {
|
||||
println!("{}", message);
|
||||
//TODO: Sending fake values for filename, lineNumber and columnNumber in LogMessage; adjust later
|
||||
propagate_console_msg(&self, ConsoleMessage::LogMessage(message, String::from_str("test"), 1, 1));
|
||||
propagate_console_msg(&self, ConsoleMessage::LogMessage {
|
||||
message: message,
|
||||
filename: "test".to_owned(),
|
||||
lineNumber: 1,
|
||||
columnNumber: 1,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue