From afc6a2b1fed2ce38791b15d279887becc3f4e5da Mon Sep 17 00:00:00 2001 From: Glenn Watson Date: Fri, 10 Feb 2017 13:57:38 +1000 Subject: [PATCH] Ensure that position_fixed reftest matches ahem font requirements. The ahem font should always be a multiple of 5px and a minimum size of 20px for reliable results [1]. In particular, on some macs, using the default size of 16 results in a reported metric of 16 x 17 from the OS. This is currently working, but breaks when WR is updated to do pixel snapping in world space. [1] http://testthewebforward.org/docs/test-style-guidelines.html#special-fonts --- tests/wpt/mozilla/meta/MANIFEST.json | 4 ++-- tests/wpt/mozilla/tests/css/position_fixed_a.html | 1 + tests/wpt/mozilla/tests/css/position_fixed_b.html | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json index 625ba20f9c8..7c008ea990c 100644 --- a/tests/wpt/mozilla/meta/MANIFEST.json +++ b/tests/wpt/mozilla/meta/MANIFEST.json @@ -22977,11 +22977,11 @@ "support" ], "css/position_fixed_a.html": [ - "e0cec72521c5ad893c260f7d0f3542d1464161e9", + "afbcc31b0460931d7ed8a2fdc1399d2f84fe33d5", "reftest" ], "css/position_fixed_b.html": [ - "4a4589634026999bbb40d0cb92c114e7af4ad61a", + "251a490233a7836accc5883093a765f88e6006b5", "support" ], "css/position_fixed_background_color_a.html": [ diff --git a/tests/wpt/mozilla/tests/css/position_fixed_a.html b/tests/wpt/mozilla/tests/css/position_fixed_a.html index 06fe7687ceb..708fc8bcf8e 100644 --- a/tests/wpt/mozilla/tests/css/position_fixed_a.html +++ b/tests/wpt/mozilla/tests/css/position_fixed_a.html @@ -13,6 +13,7 @@ because test reference depends on dynamic sizing, and different fonts change the required margins. */ font-family: 'Ahem'; + font-size: 20px; } .fixed_block { background: green; diff --git a/tests/wpt/mozilla/tests/css/position_fixed_b.html b/tests/wpt/mozilla/tests/css/position_fixed_b.html index 80c078e2a6f..5d40c68109c 100644 --- a/tests/wpt/mozilla/tests/css/position_fixed_b.html +++ b/tests/wpt/mozilla/tests/css/position_fixed_b.html @@ -9,6 +9,7 @@ background: blue; font-family: 'Ahem'; + font-size: 20px; } div { position: absolute;