From c10049327a391c8e7c6bd3f872a76c1bb57d6e8f Mon Sep 17 00:00:00 2001 From: Jim Hoskins Date: Sat, 3 Jan 2015 11:51:05 -0500 Subject: [PATCH] Implement Document.defaultView - fixes #4518 --- components/script/dom/document.rs | 5 +++++ components/script/dom/webidls/Document.webidl | 3 +++ tests/content/test_document_defaultView.html | 10 ++++++++++ tests/wpt/metadata/html/dom/interfaces.html.ini | 3 --- 4 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 tests/content/test_document_defaultView.html diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs index 888796dcaee..30099bb1798 100644 --- a/components/script/dom/document.rs +++ b/components/script/dom/document.rs @@ -994,6 +994,11 @@ impl<'a> DocumentMethods for JSRef<'a, Document> { self.ready_state.get() } + // https://html.spec.whatwg.org/multipage/browsers.html#dom-document-defaultview + fn DefaultView(self) -> Temporary { + Temporary::new(self.window) + } + global_event_handlers!() event_handler!(readystatechange, GetOnreadystatechange, SetOnreadystatechange) } diff --git a/components/script/dom/webidls/Document.webidl b/components/script/dom/webidls/Document.webidl index 8d75f20a8f7..92b7f35c34b 100644 --- a/components/script/dom/webidls/Document.webidl +++ b/components/script/dom/webidls/Document.webidl @@ -84,5 +84,8 @@ partial interface Document { // special event handler IDL attributes that only apply to Document objects [LenientThis] attribute EventHandler onreadystatechange; + + // user interaction + readonly attribute Window defaultView; }; Document implements GlobalEventHandlers; diff --git a/tests/content/test_document_defaultView.html b/tests/content/test_document_defaultView.html new file mode 100644 index 00000000000..e5f6d36a433 --- /dev/null +++ b/tests/content/test_document_defaultView.html @@ -0,0 +1,10 @@ + + + + + + + + diff --git a/tests/wpt/metadata/html/dom/interfaces.html.ini b/tests/wpt/metadata/html/dom/interfaces.html.ini index 0a0250c004f..f8fbde7b085 100644 --- a/tests/wpt/metadata/html/dom/interfaces.html.ini +++ b/tests/wpt/metadata/html/dom/interfaces.html.ini @@ -36,9 +36,6 @@ [Document interface: operation writeln(DOMString)] expected: FAIL - [Document interface: attribute defaultView] - expected: FAIL - [Document interface: attribute activeElement] expected: FAIL