clean up spurious changes and todos with no action needed

This commit is contained in:
Delan Azabani 2023-03-21 13:48:28 +08:00
parent 65da7b668b
commit dd905d8434
3 changed files with 3 additions and 6 deletions

View file

@ -526,8 +526,9 @@ impl EventTarget {
let args = if is_error { ERROR_ARG_NAMES } else { ARG_NAMES };
let cx = window.get_cx();
let options =
unsafe { CompileOptionsWrapper::new(*cx, handler.url.as_str(), handler.line as u32) };
let options = unsafe {
CompileOptionsWrapper::new(*cx, &handler.url.to_string(), handler.line as u32)
};
// Step 3.9, subsection Scope steps 1-6
let scopechain = RootedObjectVectorWrapper::new(*cx);

View file

@ -1432,9 +1432,6 @@ impl WindowMethods for Window {
.filter(|elem| is_named_element_with_id_attribute(elem));
// Step 2.
// TODO(pylbrecht): it would be great to just iterate over
// elements_with_id, but it seems document.get_elements_with_id()
// does not return HTMLIFrameElements. Why is that?
for elem in iframe_iter.clone() {
if let Some(nested_window_proxy) = elem
.downcast::<HTMLIFrameElement>()