mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
clean up spurious changes and todos with no action needed
This commit is contained in:
parent
65da7b668b
commit
dd905d8434
3 changed files with 3 additions and 6 deletions
|
@ -526,8 +526,9 @@ impl EventTarget {
|
||||||
let args = if is_error { ERROR_ARG_NAMES } else { ARG_NAMES };
|
let args = if is_error { ERROR_ARG_NAMES } else { ARG_NAMES };
|
||||||
|
|
||||||
let cx = window.get_cx();
|
let cx = window.get_cx();
|
||||||
let options =
|
let options = unsafe {
|
||||||
unsafe { CompileOptionsWrapper::new(*cx, handler.url.as_str(), handler.line as u32) };
|
CompileOptionsWrapper::new(*cx, &handler.url.to_string(), handler.line as u32)
|
||||||
|
};
|
||||||
|
|
||||||
// Step 3.9, subsection Scope steps 1-6
|
// Step 3.9, subsection Scope steps 1-6
|
||||||
let scopechain = RootedObjectVectorWrapper::new(*cx);
|
let scopechain = RootedObjectVectorWrapper::new(*cx);
|
||||||
|
|
|
@ -1432,9 +1432,6 @@ impl WindowMethods for Window {
|
||||||
.filter(|elem| is_named_element_with_id_attribute(elem));
|
.filter(|elem| is_named_element_with_id_attribute(elem));
|
||||||
|
|
||||||
// Step 2.
|
// Step 2.
|
||||||
// TODO(pylbrecht): it would be great to just iterate over
|
|
||||||
// elements_with_id, but it seems document.get_elements_with_id()
|
|
||||||
// does not return HTMLIFrameElements. Why is that?
|
|
||||||
for elem in iframe_iter.clone() {
|
for elem in iframe_iter.clone() {
|
||||||
if let Some(nested_window_proxy) = elem
|
if let Some(nested_window_proxy) = elem
|
||||||
.downcast::<HTMLIFrameElement>()
|
.downcast::<HTMLIFrameElement>()
|
||||||
|
|
|
@ -242,7 +242,6 @@ pub fn create(
|
||||||
HANDLER.0,
|
HANDLER.0,
|
||||||
UndefinedHandleValue,
|
UndefinedHandleValue,
|
||||||
proto.get(),
|
proto.get(),
|
||||||
// TODO: pass proper clasp
|
|
||||||
&CLASS,
|
&CLASS,
|
||||||
false,
|
false,
|
||||||
));
|
));
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue