Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #21906 - Manishearth:minor-webaudio-fixes, r=ferjm

Browse source 
Minor WebAudio fixes

Stuff I discovered whilst working on https://github.com/servo/media/pull/148

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21906)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-10-11 08:46:18 -04:00 • committed by GitHub
commit ddcb72f750
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/audiobuffer.rs
View file

@ -20,10 +20,10 @@ use servo_media::audio::buffer_source_node::AudioBuffer as ServoMediaAudioBuffer
use std::cmp::min; use std::cmp::min;
use std::ptr::{self, NonNull}; use std::ptr::{self, NonNull};
// This range is defined by the spec. // Spec mandates at least [8000, 96000], we use [8000, 192000] to match Firefox
// https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-createbuffer // https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-createbuffer
pub const MIN_SAMPLE_RATE: f32 = 8000.; pub const MIN_SAMPLE_RATE: f32 = 8000.;
pub const MAX_SAMPLE_RATE: f32 = 96000.; pub const MAX_SAMPLE_RATE: f32 = 192000.;
type JSAudioChannel = Heap<*mut JSObject>; type JSAudioChannel = Heap<*mut JSObject>;

6
components/script/dom/offlineaudiocontext.rs
View file

@ -151,10 +151,14 @@ impl OfflineAudioContextMethods for OfflineAudioContext {
task!(resolve: move || { task!(resolve: move || {
let this = this.root(); let this = this.root();
let processed_audio = processed_audio.lock().unwrap(); let processed_audio = processed_audio.lock().unwrap();
let processed_audio: Vec<_> = processed_audio let mut processed_audio: Vec<_> = processed_audio
.chunks(this.length as usize) .chunks(this.length as usize)
.map(|channel| channel.to_vec()) .map(|channel| channel.to_vec())
.collect(); .collect();
// it can end up being empty if the task failed
if processed_audio.len() != this.length as usize {
processed_audio.resize(this.length as usize, Vec::new())
}
let buffer = AudioBuffer::new( let buffer = AudioBuffer::new(
&this.global().as_window(), &this.global().as_window(),
this.channel_count, this.channel_count,

2
tests/wpt/metadata/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail.html.ini
View file

@ -1,2 +0,0 @@
[biquad-tail.html]
expected: ERROR