From de262327e77652ba14d2fdd1f4fa11b24158e28a Mon Sep 17 00:00:00 2001 From: Mukilan Thiyagarajan Date: Sat, 12 Apr 2025 18:36:55 +0530 Subject: [PATCH] Add support for static SVG images using `resvg` This commit contains the bulk of changes to add support for rasterizing static SVG images using the `resvg` crate. There are also other limitations in using resvg: 1. There is no support for animations or interactivty as these would require implementing the full dom layer of SVG specification. 2. Only system fonts can be used for text rendering. There is some mechanims to provide a custom font resolver to usvg, but that is not explored in this change. 3. resvg's handling of certain edge cases involving lack of explict `width` and `height` on the root svg element deviates from what the specification expects from browsers. For example, resvg uses he values in `viewBox` to derive the missing width or height dimension, but without scaling that dimension to preserve the aspect ratio. It also doesn't allow overriding this behaviour. Signed-off-by: Mukilan Thiyagarajan --- Cargo.lock | 234 ++++++++++++ Cargo.toml | 1 + components/compositing/compositor.rs | 12 +- components/layout/context.rs | 157 +++++--- components/layout/display_list/mod.rs | 60 ++-- components/layout/dom.rs | 12 +- components/layout/layout_impl.rs | 17 +- components/layout/replaced.rs | 43 ++- components/malloc_size_of/Cargo.toml | 2 + components/malloc_size_of/lib.rs | 2 + components/net/Cargo.toml | 1 + components/net/image_cache.rs | 335 +++++++++++++++--- components/pixels/lib.rs | 30 +- components/script/canvas_state.rs | 12 +- components/script/dom/datatransfer.rs | 6 +- components/script/dom/htmlimageelement.rs | 63 ++-- components/script/dom/htmlmediaelement.rs | 12 +- components/script/dom/htmlobjectelement.rs | 4 +- components/script/dom/htmlvideoelement.rs | 10 +- components/script/dom/node.rs | 8 +- components/script/dom/notification.rs | 39 +- .../script/dom/webglrenderingcontext.rs | 14 +- components/script/dom/window.rs | 68 +++- components/script/drag_data_store.rs | 6 +- components/script/image_animation.rs | 5 +- components/script/layout_dom/node.rs | 6 +- components/script/messaging.rs | 17 +- components/script/script_thread.rs | 25 +- components/shared/compositing/lib.rs | 4 +- components/shared/embedder/lib.rs | 10 +- components/shared/embedder/webdriver.rs | 4 +- components/shared/net/Cargo.toml | 1 + components/shared/net/image_cache.rs | 101 +++++- components/shared/script_layout/lib.rs | 28 +- .../shared/script_layout/wrapper_traits.rs | 6 +- components/webdriver_server/lib.rs | 8 +- 36 files changed, 1083 insertions(+), 280 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 391c553a00b..778cd256a7e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -737,6 +737,12 @@ version = "1.5.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "1fd0f2584146f6f2ef48085050886acf353beff7305ebd1ae69500e27c67f64b" +[[package]] +name = "byteorder-lite" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8f1fe948ff07f4bd06c30984e69f5b4899c516a3ef74f34df92a2df2ab535495" + [[package]] name = "bytes" version = "1.10.1" @@ -2129,6 +2135,12 @@ dependencies = [ "miniz_oxide", ] +[[package]] +name = "float-cmp" +version = "0.9.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "98de4bbd547a563b716d8dfa9aad1cb19bfab00f4fa09a6a4ed21dbcf44ce9c4" + [[package]] name = "float-ord" version = "0.3.2" @@ -2172,6 +2184,29 @@ dependencies = [ "yeslogic-fontconfig-sys", ] +[[package]] +name = "fontconfig-parser" +version = "0.5.7" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "c1fcfcd44ca6e90c921fee9fa665d530b21ef1327a4c1a6c5250ea44b776ada7" +dependencies = [ + "roxmltree", +] + +[[package]] +name = "fontdb" +version = "0.23.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "457e789b3d1202543297a350643cf459f836cade38934e7a4cf6a39e7cde2905" +dependencies = [ + "fontconfig-parser", + "log", + "memmap2", + "slotmap", + "tinyvec", + "ttf-parser", +] + [[package]] name = "fonts" version = "0.0.1" @@ -3909,6 +3944,22 @@ dependencies = [ "tiff", ] +[[package]] +name = "image-webp" +version = "0.2.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "b77d01e822461baa8409e156015a1d91735549f0f2c17691bd2d996bef238f7f" +dependencies = [ + "byteorder-lite", + "quick-error", +] + +[[package]] +name = "imagesize" +version = "0.13.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "edcd27d72f2f071c64249075f42e205ff93c9a4c5f6c6da53e79ed9f9832c285" + [[package]] name = "imsz" version = "0.2.2" @@ -4148,6 +4199,16 @@ version = "3.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e2db585e1d738fc771bf08a151420d3ed193d9d895a36df7f6f8a9456b911ddc" +[[package]] +name = "kurbo" +version = "0.11.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "89234b2cc610a7dd927ebde6b41dd1a5d4214cffaef4cf1fb2195d592f92518f" +dependencies = [ + "arrayvec", + "smallvec", +] + [[package]] name = "layout" version = "0.0.1" @@ -4831,6 +4892,7 @@ dependencies = [ "pixels", "profile_traits", "rayon", + "resvg", "rustls", "rustls-pemfile", "rustls-pki-types", @@ -4885,6 +4947,7 @@ dependencies = [ "servo_url", "url", "uuid", + "webrender_api", ] [[package]] @@ -5612,6 +5675,12 @@ dependencies = [ "siphasher", ] +[[package]] +name = "pico-args" +version = "0.5.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "5be167a7af36ee22fe3115051bc51f6e6c7054c9348e28deb4f49bd6f705a315" + [[package]] name = "pin-project" version = "1.1.10" @@ -5899,6 +5968,12 @@ dependencies = [ "bytemuck", ] +[[package]] +name = "quick-error" +version = "2.0.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a993555f31e5a609f617c12db6250dedcac1b0a85076912c436e6fc9b2c8e6a3" + [[package]] name = "quick-xml" version = "0.37.5" @@ -6117,6 +6192,32 @@ version = "0.8.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "2b15c43186be67a4fd63bee50d0303afffcef381492ebe2c5d87f324e1b8815c" +[[package]] +name = "resvg" +version = "0.45.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a8928798c0a55e03c9ca6c4c6846f76377427d2c1e1f7e6de3c06ae57942df43" +dependencies = [ + "gif", + "image-webp", + "log", + "pico-args", + "rgb", + "svgtypes", + "tiny-skia", + "usvg", + "zune-jpeg", +] + +[[package]] +name = "rgb" +version = "0.8.50" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "57397d16646700483b67d2dd6511d79318f9d057fdbd21a4066aeac8b41d310a" +dependencies = [ + "bytemuck", +] + [[package]] name = "ring" version = "0.17.14" @@ -6144,6 +6245,12 @@ dependencies = [ "unicode-ident", ] +[[package]] +name = "roxmltree" +version = "0.20.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "6c20b6793b5c2fa6553b250154b78d6d0db37e72700ae35fad9387a46f487c97" + [[package]] name = "rustc-demangle" version = "0.1.24" @@ -6235,6 +6342,24 @@ version = "1.0.21" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8a0d197bd2c9dc6e53b84da9556a69ba4cdfab8619eb41a8bd1cc2027a0f6b1d" +[[package]] +name = "rustybuzz" +version = "0.20.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "fd3c7c96f8a08ee34eff8857b11b49b07d71d1c3f4e88f8a88d4c9e9f90b1702" +dependencies = [ + "bitflags 2.9.1", + "bytemuck", + "core_maths", + "log", + "smallvec", + "ttf-parser", + "unicode-bidi-mirroring", + "unicode-ccc", + "unicode-properties", + "unicode-script", +] + [[package]] name = "ryu" version = "1.0.20" @@ -6856,6 +6981,8 @@ dependencies = [ "ipc-channel", "keyboard-types", "markup5ever", + "mime", + "resvg", "servo_allocator", "servo_arc", "smallvec", @@ -7027,6 +7154,15 @@ dependencies = [ "windows-sys 0.48.0", ] +[[package]] +name = "simplecss" +version = "0.2.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "7a9c6883ca9c3c7c90e888de77b7a5c849c779d25d74a1269b0218b14e8b136c" +dependencies = [ + "log", +] + [[package]] name = "siphasher" version = "1.0.1" @@ -7179,6 +7315,9 @@ name = "strict-num" version = "0.1.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "6637bab7722d379c8b41ba849228d680cc12d0a45ba1fa2b48f2a30577a06731" +dependencies = [ + "float-cmp", +] [[package]] name = "string_cache" @@ -7422,6 +7561,16 @@ version = "0.4.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "0193cc4331cfd2f3d2011ef287590868599a2f33c3e69bc22c1a3d3acf9e02fb" +[[package]] +name = "svgtypes" +version = "0.15.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "68c7541fff44b35860c1a7a47a7cadf3e4a304c457b58f9870d9706ece028afc" +dependencies = [ + "kurbo", + "siphasher", +] + [[package]] name = "sw-composite" version = "0.7.16" @@ -7709,6 +7858,7 @@ dependencies = [ "bytemuck", "cfg-if", "log", + "png", "tiny-skia-path", ] @@ -7743,6 +7893,21 @@ dependencies = [ "serde_json", ] +[[package]] +name = "tinyvec" +version = "1.9.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "09b3661f17e86524eccd4371ab0429194e0d7c008abb45f7a7495b1719463c71" +dependencies = [ + "tinyvec_macros", +] + +[[package]] +name = "tinyvec_macros" +version = "0.1.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "1f3ccbac311fea05f86f61904b462b55fb3df8837a366dfc601a0161d0532f20" + [[package]] name = "to_shmem" version = "0.2.0" @@ -7988,6 +8153,9 @@ name = "ttf-parser" version = "0.25.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d2df906b07856748fa3f6e0ad0cbaa047052d4a7dd609e231c4f72cee8c36f31" +dependencies = [ + "core_maths", +] [[package]] name = "tungstenite" @@ -8089,6 +8257,18 @@ version = "0.3.18" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "5c1cb5db39152898a79168971543b1cb5020dff7fe43c8dc468b0885f5e29df5" +[[package]] +name = "unicode-bidi-mirroring" +version = "0.4.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "5dfa6e8c60bb66d49db113e0125ee8711b7647b5579dc7f5f19c42357ed039fe" + +[[package]] +name = "unicode-ccc" +version = "0.4.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "ce61d488bcdc9bc8b5d1772c404828b17fc481c0a582b5581e95fb233aef503e" + [[package]] name = "unicode-ident" version = "1.0.18" @@ -8113,6 +8293,12 @@ version = "1.12.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "f6ccf251212114b54433ec949fd6a7841275f9ada20dddd2f29e9ceea4501493" +[[package]] +name = "unicode-vo" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "b1d386ff53b415b7fe27b50bb44679e2cc4660272694b7b6f3326d8480823a94" + [[package]] name = "unicode-width" version = "0.1.14" @@ -8169,6 +8355,33 @@ dependencies = [ "url", ] +[[package]] +name = "usvg" +version = "0.45.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "80be9b06fbae3b8b303400ab20778c80bbaf338f563afe567cf3c9eea17b47ef" +dependencies = [ + "base64 0.22.1", + "data-url", + "flate2", + "fontdb", + "imagesize", + "kurbo", + "log", + "pico-args", + "roxmltree", + "rustybuzz", + "simplecss", + "siphasher", + "strict-num", + "svgtypes", + "tiny-skia-path", + "unicode-bidi", + "unicode-script", + "unicode-vo", + "xmlwriter", +] + [[package]] name = "utf-8" version = "0.7.6" @@ -9466,6 +9679,12 @@ dependencies = [ "markup5ever", ] +[[package]] +name = "xmlwriter" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "ec7a2a501ed189703dba8b08142f057e887dfc4b2cc4db2d343ac6376ba3e0b9" + [[package]] name = "yeslogic-fontconfig-sys" version = "6.0.0" @@ -9582,6 +9801,12 @@ dependencies = [ "syn", ] +[[package]] +name = "zune-core" +version = "0.4.12" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "3f423a2c17029964870cfaabb1f13dfab7d092a62a29a89264f4d36990ca414a" + [[package]] name = "zune-inflate" version = "0.2.54" @@ -9590,3 +9815,12 @@ checksum = "73ab332fe2f6680068f3582b16a24f90ad7096d5d39b974d1c0aff0125116f02" dependencies = [ "simd-adler32", ] + +[[package]] +name = "zune-jpeg" +version = "0.4.14" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "99a5bab8d7dedf81405c4bb1f2b83ea057643d9cb28778cea9eecddeedd2e028" +dependencies = [ + "zune-core", +] diff --git a/Cargo.toml b/Cargo.toml index 1373440d67e..b24a468abd0 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -113,6 +113,7 @@ rand_isaac = "0.3" raw-window-handle = "0.6" rayon = "1" regex = "1.11" +resvg = "0.45.0" rustls = { version = "0.23", default-features = false, features = ["logging", "std", "tls12"] } rustls-pemfile = "2.0" rustls-pki-types = "1.12" diff --git a/components/compositing/compositor.rs b/components/compositing/compositor.rs index 855f60e57b2..27d1e8f93e1 100644 --- a/components/compositing/compositor.rs +++ b/components/compositing/compositor.rs @@ -32,7 +32,7 @@ use fnv::FnvHashMap; use ipc_channel::ipc::{self, IpcSharedMemory}; use libc::c_void; use log::{debug, info, trace, warn}; -use pixels::{CorsStatus, Image, ImageFrame, PixelFormat}; +use pixels::{CorsStatus, ImageFrame, ImageMetadata, PixelFormat, RasterImage}; use profile_traits::mem::{ProcessReports, ProfilerRegistration, Report, ReportKind}; use profile_traits::time::{self as profile_time, ProfilerCategory}; use profile_traits::{path, time_profile}; @@ -1431,7 +1431,7 @@ impl IOCompositor { &mut self, webview_id: WebViewId, page_rect: Option>, - ) -> Result, UnableToComposite> { + ) -> Result, UnableToComposite> { self.render_inner()?; let size = self.rendering_context.size2d().to_i32(); @@ -1458,9 +1458,11 @@ impl IOCompositor { Ok(self .rendering_context .read_to_image(rect) - .map(|image| Image { - width: image.width(), - height: image.height(), + .map(|image| RasterImage { + metadata: ImageMetadata { + width: image.width(), + height: image.height(), + }, format: PixelFormat::RGBA8, frames: vec![ImageFrame { delay: None, diff --git a/components/layout/context.rs b/components/layout/context.rs index 54afd4ca209..1ee76606b0b 100644 --- a/components/layout/context.rs +++ b/components/layout/context.rs @@ -10,17 +10,21 @@ use fnv::FnvHashMap; use fonts::FontContext; use fxhash::FxHashMap; use net_traits::image_cache::{ - ImageCache, ImageCacheResult, ImageOrMetadataAvailable, UsePlaceholder, + Image as CachedImage, ImageCache, ImageCacheResult, ImageOrMetadataAvailable, PendingImageId, + UsePlaceholder, }; use parking_lot::{Mutex, RwLock}; -use pixels::Image as PixelImage; -use script_layout_interface::{IFrameSizes, ImageAnimationState, PendingImage, PendingImageState}; +use pixels::RasterImage; +use script_layout_interface::{ + IFrameSizes, ImageAnimationState, PendingImage, PendingImageState, PendingRasterizationImage, +}; use servo_url::{ImmutableOrigin, ServoUrl}; use style::context::SharedStyleContext; use style::dom::OpaqueNode; use style::values::computed::image::{Gradient, Image}; +use webrender_api::units::{DeviceIntSize, DeviceSize}; -use crate::display_list::WebRenderImageInfo; +pub(crate) type CachedImageOrError = Result; pub struct LayoutContext<'a> { pub id: PipelineId, @@ -39,11 +43,17 @@ pub struct LayoutContext<'a> { /// A list of in-progress image loads to be shared with the script thread. pub pending_images: Mutex>, + /// A list of fully loaded vector images that need to be rasterized to a specific + /// size determined by layout. This will be shared with the script thread. + pub pending_rasterization_images: Mutex>, + /// A collection of `