From ded518dfd0a22d6e6b8bec8a59e8498f18124616 Mon Sep 17 00:00:00 2001 From: shanehandley <1322294+shanehandley@users.noreply.github.com> Date: Sun, 13 Oct 2024 22:56:37 +1100 Subject: [PATCH] Remove some fixed fixmes (#33824) Signed-off-by: Shane Handley --- components/script/dom/htmlmediaelement.rs | 10 ++++------ components/script/dom/webidls/ServiceWorker.webidl | 1 - 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs index 89b1eebac78..6b55ed5d0b7 100644 --- a/components/script/dom/htmlmediaelement.rs +++ b/components/script/dom/htmlmediaelement.rs @@ -1075,14 +1075,12 @@ impl HTMLMediaElement { self.error.get().is_some() } - // https://html.spec.whatwg.org/multipage/#potentially-playing + /// fn is_potentially_playing(&self) -> bool { !self.paused.get() && - // FIXME: We need https://github.com/servo/servo/pull/22348 - // to know whether playback has ended or not - // !self.Ended() && - self.error.get().is_none() && - !self.is_blocked_media_element() + !self.Ended() && + self.error.get().is_none() && + !self.is_blocked_media_element() } // https://html.spec.whatwg.org/multipage/#blocked-media-element diff --git a/components/script/dom/webidls/ServiceWorker.webidl b/components/script/dom/webidls/ServiceWorker.webidl index 263737d03f9..a5bc8938602 100644 --- a/components/script/dom/webidls/ServiceWorker.webidl +++ b/components/script/dom/webidls/ServiceWorker.webidl @@ -14,7 +14,6 @@ interface ServiceWorker : EventTarget { attribute EventHandler onstatechange; }; -// FIXME: use `includes` instead of `implements` after #22539 is fixed. ServiceWorker includes AbstractWorker; enum ServiceWorkerState {