From dedebc5cb58a88ff0c1608eeaab97df796d966a5 Mon Sep 17 00:00:00 2001
From: Manish Goregaokar <manishsmail@gmail.com>
Date: Mon, 2 Jan 2017 15:53:51 -0800
Subject: [PATCH] Add spec links for column properties

---
 .../style/properties/longhand/column.mako.rs  | 25 ++++++++++++-------
 .../style/properties/shorthand/column.mako.rs |  7 +++---
 2 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/components/style/properties/longhand/column.mako.rs b/components/style/properties/longhand/column.mako.rs
index ef2802be00d..a508a5daf9f 100644
--- a/components/style/properties/longhand/column.mako.rs
+++ b/components/style/properties/longhand/column.mako.rs
@@ -12,11 +12,13 @@ ${helpers.predefined_type("column-width",
                           "Either::Second(Auto)",
                           parse_method="parse_non_negative_length",
                           animatable=False,
-                          experimental=True)}
+                          experimental=True,
+                          spec="https://drafts.csswg.org/css-multicol/#propdef-column-width")}
 
 
 // FIXME: This prop should be animatable.
-<%helpers:longhand name="column-count" experimental="True" animatable="False">
+<%helpers:longhand name="column-count" experimental="True" animatable="False"
+                   spec="https://drafts.csswg.org/css-multicol/#propdef-column-count">
     use std::fmt;
     use style_traits::ToCss;
     use values::NoViewportPercentage;
@@ -101,13 +103,16 @@ ${helpers.predefined_type("column-gap",
                           "Either::Second(Normal)",
                           parse_method='parse_non_negative_length',
                           experimental=True,
-                          animatable=False)}
+                          animatable=False,
+                          spec="https://drafts.csswg.org/css-multicol/#propdef-column-gap")}
 
 ${helpers.single_keyword("column-fill", "auto balance",
-                         products="gecko", animatable=False)}
+                         products="gecko", animatable=False,
+                         spec="https://drafts.csswg.org/css-multicol/#propdef-column-gap")}
 
 // https://drafts.csswg.org/css-multicol-1/#propdef-column-rule-width
-<%helpers:longhand name="column-rule-width" products="gecko" animatable="True">
+<%helpers:longhand name="column-rule-width" products="gecko" animatable="True"
+                   spec="https://drafts.csswg.org/css-multicol/#propdef-column-rule-width">
     use app_units::Au;
     use std::fmt;
     use style_traits::ToCss;
@@ -140,15 +145,17 @@ ${helpers.single_keyword("column-fill", "auto balance",
 ${helpers.predefined_type("column-rule-color", "CSSColor",
                           "::cssparser::Color::CurrentColor",
                           products="gecko", animatable=True,
-                          complex_color=True, need_clone=True)}
+                          complex_color=True, need_clone=True,
+                          spec="https://drafts.csswg.org/css-multicol/#propdef-column-rule-color")}
 
 // It's not implemented in servo or gecko yet.
-// https://drafts.csswg.org/css-multicol-1/#column-span
 ${helpers.single_keyword("column-span", "none all",
-                         products="none", animatable=False)}
+                         products="none", animatable=False,
+                         spec="https://drafts.csswg.org/css-multicol/#propdef-column-span")}
 
 ${helpers.single_keyword("column-rule-style",
                          "none hidden dotted dashed solid double groove ridge inset outset",
                          products="gecko",
                          gecko_constant_prefix="NS_STYLE_BORDER_STYLE",
-                         animatable=False)}
+                         animatable=False,
+                         spec="https://drafts.csswg.org/css-multicol/#propdef-column-rule-style")}
diff --git a/components/style/properties/shorthand/column.mako.rs b/components/style/properties/shorthand/column.mako.rs
index e2b6f2ac5a7..69aa6baeeb6 100644
--- a/components/style/properties/shorthand/column.mako.rs
+++ b/components/style/properties/shorthand/column.mako.rs
@@ -4,7 +4,8 @@
 
 <%namespace name="helpers" file="/helpers.mako.rs" />
 
-<%helpers:shorthand name="columns" sub_properties="column-count column-width" experimental="True">
+<%helpers:shorthand name="columns" sub_properties="column-count column-width" experimental="True"
+                    spec="https://drafts.csswg.org/css-multicol/#propdef-columns">
     use properties::longhands::{column_count, column_width};
 
     pub fn parse_value(context: &ParserContext, input: &mut Parser) -> Result<Longhands, ()> {
@@ -58,9 +59,9 @@
     }
 </%helpers:shorthand>
 
-// https://drafts.csswg.org/css-multicol/#column-rule
 <%helpers:shorthand name="column-rule" products="gecko"
-    sub_properties="column-rule-width column-rule-style column-rule-color">
+    sub_properties="column-rule-width column-rule-style column-rule-color"
+    spec="https://drafts.csswg.org/css-multicol/#propdef-column-rule">
     use properties::longhands::{column_rule_width, column_rule_style};
     use properties::longhands::column_rule_color;