Only add --manifest-path if not already present

This commit is contained in:
Simon Sapin 2018-09-25 21:00:26 +02:00
parent 4e85f9c186
commit deeb79669f
3 changed files with 10 additions and 8 deletions

View file

@ -256,7 +256,7 @@ class MachCommands(CommandBase):
self.ensure_bootstrapped(target=target)
self.ensure_clobbered()
opts += ["--manifest-path", self.manifest_path(android, libsimpleservo)]
self.add_manifest_path(opts, android, libsimpleservo)
if debug_mozjs:
features += ["debugmozjs"]

View file

@ -670,11 +670,14 @@ install them, let us know by filing a bug!")
def ports_servo_crate(self):
return path.join(self.context.topdir, "ports", "servo")
def manifest_path(self, android=False, libsimpleservo=False):
if libsimpleservo or android:
return self.ports_libsimpleservo_manifest()
else:
return self.ports_servo_manifest()
def add_manifest_path(self, args, android=False, libsimpleservo=False):
if "--manifest-path" not in args:
if libsimpleservo or android:
manifest = self.ports_libsimpleservo_manifest()
else:
manifest = self.ports_servo_manifest()
args.append("--manifest-path")
args.append(manifest)
def ports_servo_manifest(self):
return path.join(self.context.topdir, "ports", "servo", "Cargo.toml")

View file

@ -40,8 +40,7 @@ class MachCommands(CommandBase):
if check:
params = ['check'] + params
if "--manifest-path" not in params:
params += ["--manifest-path", self.ports_servo_manifest()]
self.add_manifest_path(params)
build_start = time()
status = self.call_rustup_run(["cargo"] + params, env=env)