Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Actually, node_position probably won't be needed later.

Browse source 
This is why you shouldn't make assumptions about what you'll need later!
This commit is contained in:
Permutator 2017-01-05 01:23:06 -08:00
parent 4825169fb0
commit defa7d99a6
No known key found for this signature in database
GPG key ID: 62D7A8D792C3B058
1 changed files with 4 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/layout/query.rs
View file

@ -564,20 +564,12 @@ impl FragmentBorderBoxIterator for ParentOffsetBorderBoxIterator {
if fragment.style.get_box().position == computed_values::position::T::fixed { if fragment.style.get_box().position == computed_values::position::T::fixed {
self.parent_nodes.clear(); self.parent_nodes.clear();
} }
} else if let Some((inline_context, node_position)) = } else if let Some(node) = fragment.inline_context.as_ref().and_then(|inline_context| {
fragment.inline_context.as_ref().and_then(|inline_context| { inline_context.nodes.iter().find(|node| node.address == self.node_address)
inline_context.nodes.iter().position(|node| node.address == self.node_address).map(|node_position| { }) {
(inline_context, node_position)
})
}) {
// TODO: Handle cases where the `offsetParent` is an inline // TODO: Handle cases where the `offsetParent` is an inline
// element. This will likely be impossible until // element. This will likely be impossible until
// https://github.com/servo/servo/issues/13982 is fixed. It would // https://github.com/servo/servo/issues/13982 is fixed.
// have been much easier to just use find() instead of position(),
// but node_position will be needed later in order to handle those
// cases.
let node = &inline_context.nodes[node_position];
// Found a fragment in the flow tree whose inline context contains // Found a fragment in the flow tree whose inline context contains
// the DOM node we're looking for, i.e. the node is inline and // the DOM node we're looking for, i.e. the node is inline and