Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-25 16:20:36 +01:00
Code Issues Projects Releases Packages Wiki Activity

'closeevent' argument for Document::createEvent

Browse source 
fix alphabetical order

delete unused tests
This commit is contained in:
mrmiywj 2016-05-06 19:16:10 +08:00
parent 0558687d71
commit dfaad2dab2
4 changed files with 10 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/closeevent.rs
View file

@ -33,6 +33,12 @@ impl CloseEvent {
} }
} }
pub fn new_uninitialized(global: GlobalRef) -> Root<CloseEvent> {
reflect_dom_object(box CloseEvent::new_inherited(false, 0, DOMString::new()),
global,
CloseEventBinding::Wrap)
}
pub fn new(global: GlobalRef, pub fn new(global: GlobalRef,
type_: Atom, type_: Atom,
bubbles: EventBubbles, bubbles: EventBubbles,
@ -66,6 +72,7 @@ impl CloseEvent {
init.code, init.code,
init.reason.clone())) init.reason.clone()))
} }
} }
impl CloseEventMethods for CloseEvent { impl CloseEventMethods for CloseEvent {

3
components/script/dom/document.rs
View file

@ -32,6 +32,7 @@ use dom::bindings::trace::RootedVec;
use dom::bindings::xmlname::XMLName::InvalidXMLName; use dom::bindings::xmlname::XMLName::InvalidXMLName;
use dom::bindings::xmlname::{validate_and_extract, namespace_from_domstring, xml_name_type}; use dom::bindings::xmlname::{validate_and_extract, namespace_from_domstring, xml_name_type};
use dom::browsingcontext::BrowsingContext; use dom::browsingcontext::BrowsingContext;
use dom::closeevent::CloseEvent;
use dom::comment::Comment; use dom::comment::Comment;
use dom::customevent::CustomEvent; use dom::customevent::CustomEvent;
use dom::documentfragment::DocumentFragment; use dom::documentfragment::DocumentFragment;
@ -2190,6 +2191,8 @@ impl DocumentMethods for Document {
Ok(Root::upcast(FocusEvent::new_uninitialized(GlobalRef::Window(&self.window)))), Ok(Root::upcast(FocusEvent::new_uninitialized(GlobalRef::Window(&self.window)))),
"errorevent" => "errorevent" =>
Ok(Root::upcast(ErrorEvent::new_uninitialized(GlobalRef::Window(&self.window)))), Ok(Root::upcast(ErrorEvent::new_uninitialized(GlobalRef::Window(&self.window)))),
"closeevent" =>
Ok(Root::upcast(CloseEvent::new_uninitialized(GlobalRef::Window(&self.window)))),
_ => _ =>
Err(Error::NotSupported), Err(Error::NotSupported),
} }

24
tests/wpt/metadata/dom/nodes/Document-createEvent.html.ini
View file

@ -37,30 +37,6 @@
[createEvent('BEFOREUNLOADEVENT') should be initialized correctly.] [createEvent('BEFOREUNLOADEVENT') should be initialized correctly.]
expected: FAIL expected: FAIL
[CloseEvent should be an alias for CloseEvent.]
bug: https://github.com/servo/servo/issues/10737
expected: FAIL
[createEvent('CloseEvent') should be initialized correctly.]
bug: https://github.com/servo/servo/issues/10737
expected: FAIL
[closeevent should be an alias for CloseEvent.]
bug: https://github.com/servo/servo/issues/10737
expected: FAIL
[createEvent('closeevent') should be initialized correctly.]
bug: https://github.com/servo/servo/issues/10737
expected: FAIL
[CLOSEEVENT should be an alias for CloseEvent.]
bug: https://github.com/servo/servo/issues/10737
expected: FAIL
[createEvent('CLOSEEVENT') should be initialized correctly.]
bug: https://github.com/servo/servo/issues/10737
expected: FAIL
[CompositionEvent should be an alias for CompositionEvent.] [CompositionEvent should be an alias for CompositionEvent.]
expected: FAIL expected: FAIL

6
tests/wpt/web-platform-tests/websockets/interfaces/CloseEvent/historical.html
View file

@ -5,12 +5,6 @@
<script src=/resources/testharnessreport.js></script> <script src=/resources/testharnessreport.js></script>
<div id=log></div> <div id=log></div>
<script> <script>
test(function() {
assert_throws("NotSupportedError", function() {
document.createEvent("CloseEvent")
});
}, "createEvent(\"CloseEvent\")");
test(function() { test(function() {
assert_false("initCloseEvent" in CloseEvent.prototype); assert_false("initCloseEvent" in CloseEvent.prototype);
assert_false("initCloseEvent" in new CloseEvent('close')); assert_false("initCloseEvent" in new CloseEvent('close'));