From e0526661538f89e50ecbdd5c04f991e1c055f3e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Tue, 5 Jun 2018 20:11:04 +0200 Subject: [PATCH] style: Fix a typo. Nobody looks at the result from parsing, but this is the right thing to return. Bug: 1466963 Reviewed-by: xidorn MozReview-Commit-ID: 9P5VARiPIAk --- components/style/properties/declaration_block.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/style/properties/declaration_block.rs b/components/style/properties/declaration_block.rs index 3cdbf61de66..e192d08b22d 100644 --- a/components/style/properties/declaration_block.rs +++ b/components/style/properties/declaration_block.rs @@ -492,9 +492,9 @@ impl PropertyDeclarationBlock { /// declaration with more importance, and will ensure that, if inserted, /// it's inserted at the end of the declaration block. /// - /// * For `DeclarationSource::CssOm`, this will override importance and - /// will preserve the original position on the block. + /// * For `DeclarationSource::CssOm`, this will override importance. /// + /// Returns whether the declaration has changed. pub fn push( &mut self, declaration: PropertyDeclaration, @@ -522,7 +522,7 @@ impl PropertyDeclarationBlock { // shouldn't override existing important one. if important && !importance.important() && matches!(source, DeclarationSource::Parsing) { - return true; + return false; } if matches!(source, DeclarationSource::Parsing) {