Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-24 15:50:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove viewMatrix

Browse source 
Users are supposed to use `view.transform.inverse.matrix`

The view matrix was incorrect anyway, we had forgotten to invert it, but that was okay since we transposed it by accident (due to euclid's use of the row-vector convention), and for 3DOF devices these transforms are mostly rotations so  transposing instead of inverting doesn't lead to visible effects.
This commit is contained in:
Manish Goregaokar 2019-04-03 13:31:34 -07:00
parent e73920ee97
commit e055884564
2 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/script/dom/webidls/XRView.webidl
View file

@ -13,6 +13,5 @@ enum XREye {
interface XRView { interface XRView {
readonly attribute XREye eye; readonly attribute XREye eye;
readonly attribute Float32Array projectionMatrix; readonly attribute Float32Array projectionMatrix;
readonly attribute Float32Array viewMatrix;
readonly attribute XRRigidTransform transform; readonly attribute XRRigidTransform transform;
}; };

8
components/script/dom/xrview.rs
View file

@ -63,7 +63,6 @@ impl XRView {
let offset = Vector3D::new(offset[0] as f64, offset[1] as f64, offset[2] as f64); let offset = Vector3D::new(offset[0] as f64, offset[1] as f64, offset[2] as f64);
let transform = pose.post_mul(&offset.into()); let transform = pose.post_mul(&offset.into());
let view = transform.to_transform().cast().to_column_major_array();
let transform = XRRigidTransform::new(global, transform); let transform = XRRigidTransform::new(global, transform);
let ret = reflect_dom_object( let ret = reflect_dom_object(
@ -75,7 +74,6 @@ impl XRView {
let cx = global.get_cx(); let cx = global.get_cx();
unsafe { unsafe {
create_typed_array(cx, proj, &ret.proj); create_typed_array(cx, proj, &ret.proj);
create_typed_array(cx, &view, &ret.view);
} }
ret ret
} }
@ -97,12 +95,6 @@ impl XRViewMethods for XRView {
NonNull::new(self.proj.get()).unwrap() NonNull::new(self.proj.get()).unwrap()
} }
#[allow(unsafe_code)]
/// https://immersive-web.github.io/webxr/#dom-xrview-projectionmatrix
unsafe fn ViewMatrix(&self, _cx: *mut JSContext) -> NonNull<JSObject> {
NonNull::new(self.view.get()).unwrap()
}
/// https://immersive-web.github.io/webxr/#dom-xrview-transform /// https://immersive-web.github.io/webxr/#dom-xrview-transform
fn Transform(&self) -> DomRoot<XRRigidTransform> { fn Transform(&self) -> DomRoot<XRRigidTransform> {
DomRoot::from_ref(&self.transform) DomRoot::from_ref(&self.transform)