Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

servoshell: Fix reversed logic for WebDriver open window and window.open from #37284 (#37346)

Browse source 
The logic was opposite to intended in #37284. We ended up staying in
same tab for `window.open` but focus new tab for WebDriver.

Testing: This modifies whether or not tabs are activated in servoshell
and WebDriver. WebDriver is currently not tested and neither is
servoshell.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye 2025-06-09 23:24:52 +08:00 • committed by GitHub
parent 7f536e8092
commit e0aec1c8d2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ports/servoshell/desktop/app_state.rs
View file

@ -480,7 +480,7 @@ impl WebViewDelegate for RunningAppState {
// When WebDriver is enabled, do not focus and raise the WebView to the top,
// as that is what the specification expects. Otherwise, we would like `window.open()`
// to create a new foreground tab
if opts::get().webdriver_port.is_some() {
if opts::get().webdriver_port.is_none() {
webview.focus();
webview.raise_to_top(true);
}