Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Enable multiple grid repeat values in Servo.

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D60931
This commit is contained in:
Emily McDonough 2020-03-19 22:11:48 +00:00 • committed by Emilio Cobos Álvarez
parent b85b6ac16f
commit e0b4619fa5
2 changed files with 0 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/style/values/generics/grid.rs
View file

@ -696,14 +696,6 @@ impl Parse for LineNameList {
.take(num.value() as usize * names_list.len()), .take(num.value() as usize * names_list.len()),
), ),
RepeatCount::AutoFill if fill_data.is_none() => { RepeatCount::AutoFill if fill_data.is_none() => {
// `repeat(autof-fill, ..)` should have just one line name.
// FIXME(bug 1341507) the above comment is wrong per:
// https://drafts.csswg.org/css-grid-2/#typedef-name-repeat
if names_list.len() != 1 {
return Err(
input.new_custom_error(StyleParseErrorKind::UnspecifiedError)
);
}
let fill_idx = line_names.len(); let fill_idx = line_names.len();
let fill_len = names_list.len(); let fill_len = names_list.len();
fill_data = Some((fill_idx, fill_len)); fill_data = Some((fill_idx, fill_len));

10
components/style/values/specified/grid.rs
View file

@ -185,16 +185,6 @@ impl TrackRepeat<LengthPercentage, Integer> {
values.push(track_size); values.push(track_size);
names.push(current_names); names.push(current_names);
if is_auto {
// FIXME: In the older version of the spec
// (https://www.w3.org/TR/2015/WD-css-grid-1-20150917/#typedef-auto-repeat),
// if the repeat type is `<auto-repeat>` we shouldn't try to parse more than
// one `TrackSize`. But in current version of the spec, this is deprecated
// but we are adding this for gecko parity. We should remove this when
// gecko implements new spec.
names.push(input.try(parse_line_names).unwrap_or_default());
break;
}
} else { } else {
if values.is_empty() { if values.is_empty() {
// expecting at least one <track-size> // expecting at least one <track-size>