Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-08 06:55:31 +01:00
Code Issues Projects Releases Packages Wiki Activity

Rewrite From/TryFrom conversions on generated types to avoid future orphan rule violations (#34554)

Browse source 
* script: Add traits to allow converting between types that are not defined in the script crate.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* script: Rewrite all From/TryFrom implementations on generated WebIDL types to use new Convert/TryConvert traits.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-12-11 00:52:48 -05:00 • committed by GitHub
parent e10e989abb
commit e0cbab2fbb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
40 changed files with 439 additions and 380 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/mediadeviceinfo.rs
View file

@ -5,6 +5,7 @@
use dom_struct::dom_struct;
use servo_media::streams::device_monitor::MediaDeviceKind as ServoMediaDeviceKind;
use crate::conversions::Convert;
use crate::dom::bindings::codegen::Bindings::MediaDeviceInfoBinding::{
MediaDeviceInfoMethods, MediaDeviceKind,
};
@ -76,9 +77,9 @@ impl MediaDeviceInfoMethods<crate::DomTypeHolder> for MediaDeviceInfo {
}
}
impl From<ServoMediaDeviceKind> for MediaDeviceKind {
fn from(kind: ServoMediaDeviceKind) -> MediaDeviceKind {
match kind {
impl Convert<MediaDeviceKind> for ServoMediaDeviceKind {
fn convert(self) -> MediaDeviceKind {
match self {
ServoMediaDeviceKind::AudioInput => MediaDeviceKind::Audioinput,
ServoMediaDeviceKind::AudioOutput => MediaDeviceKind::Audiooutput,
ServoMediaDeviceKind::VideoInput => MediaDeviceKind::Videoinput,