Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed some clippy warnings by replacing 'match' with 'if' (#32007)

Browse source
This commit is contained in:
komuhangi 2024-04-07 10:39:05 +03:00 • committed by GitHub
parent 05f1bbf0a9
commit e0e3408650
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 57 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

59
components/script/dom/htmloptgroupelement.rs
View file

@ -87,38 +87,35 @@ impl VirtualMethods for HTMLOptGroupElement {
fn attribute_mutated(&self, attr: &Attr, mutation: AttributeMutation) {
self.super_type().unwrap().attribute_mutated(attr, mutation);
match attr.local_name() {
&local_name!("disabled") => {
let disabled_state = match mutation {
AttributeMutation::Set(None) => true,
AttributeMutation::Set(Some(_)) => {
// Option group was already disabled.
return;
},
AttributeMutation::Removed => false,
};
let el = self.upcast::<Element>();
el.set_disabled_state(disabled_state);
el.set_enabled_state(!disabled_state);
let options = el
.upcast::<Node>()
.children()
.filter(|child| child.is::<HTMLOptionElement>())
.map(|child| DomRoot::from_ref(child.downcast::<HTMLOptionElement>().unwrap()));
if disabled_state {
for option in options {
let el = option.upcast::<Element>();
el.set_disabled_state(true);
el.set_enabled_state(false);
}
} else {
for option in options {
let el = option.upcast::<Element>();
el.check_disabled_attribute();
}
if attr.local_name() == &local_name!("disabled") {
let disabled_state = match mutation {
AttributeMutation::Set(None) => true,
AttributeMutation::Set(Some(_)) => {
// Option group was already disabled.
return;
},
AttributeMutation::Removed => false,
};
let el = self.upcast::<Element>();
el.set_disabled_state(disabled_state);
el.set_enabled_state(!disabled_state);
let options = el
.upcast::<Node>()
.children()
.filter(|child| child.is::<HTMLOptionElement>())
.map(|child| DomRoot::from_ref(child.downcast::<HTMLOptionElement>().unwrap()));
if disabled_state {
for option in options {
let el = option.upcast::<Element>();
el.set_disabled_state(true);
el.set_enabled_state(false);
}
},
_ => {},
} else {
for option in options {
let el = option.upcast::<Element>();
el.check_disabled_attribute();
}
}
}
}