mirror of
https://github.com/servo/servo.git
synced 2025-09-30 16:49:16 +01:00
Auto merge of #16807 - mrobinson:scroll-clamping, r=emilio
Fix clamping of scroll position in window.scrollBy For rightward and downward overflow the spec says: Let x be max(0, min(x, viewport scrolling area width - viewport width)). Let y be max(0, min(y, viewport scrolling area height - viewport height)). Previously, those operations were reversed, which created negative overflow even when the overflow direction was downward. This change ensures that Servo matches spec behavior. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16807) <!-- Reviewable:end -->
This commit is contained in:
commit
e196776c24
3 changed files with 38 additions and 2 deletions
|
@ -19783,6 +19783,12 @@
|
|||
{}
|
||||
]
|
||||
],
|
||||
"mozilla/scrollBy.html": [
|
||||
[
|
||||
"/_mozilla/mozilla/scrollBy.html",
|
||||
{}
|
||||
]
|
||||
],
|
||||
"mozilla/scrollTo.html": [
|
||||
[
|
||||
"/_mozilla/mozilla/scrollTo.html",
|
||||
|
@ -31354,6 +31360,10 @@
|
|||
"b247e3a0ba733c1a8b129ce2994b862d8ed3a423",
|
||||
"testharness"
|
||||
],
|
||||
"mozilla/scrollBy.html": [
|
||||
"0243d584bc615a73ea1667fc35f5d73b5165d19f",
|
||||
"testharness"
|
||||
],
|
||||
"mozilla/scrollTo.html": [
|
||||
"b9917be5fed364dbc46264f641f54f275b5c054a",
|
||||
"testharness"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue