Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-22 21:00:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: switch to Element::create in HTMLSelectElement (#39390)

Browse source 
This file was missed in 07b2ff5d60
(#39325). See that commit for the motivation.

Testing: Covered by existing web platform tests.

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This commit is contained in:
Mukilan Thiyagarajan 2025-09-20 17:21:31 +05:30 • committed by GitHub
parent 715818cf73
commit e2241a93fe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 30 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

42
components/script/dom/html/htmlselectelement.rs
View file

@ -9,7 +9,7 @@ use dom_struct::dom_struct;
use embedder_traits::{EmbedderMsg, FormControl as EmbedderFormControl}; use embedder_traits::{EmbedderMsg, FormControl as EmbedderFormControl};
use embedder_traits::{SelectElementOption, SelectElementOptionOrOptgroup}; use embedder_traits::{SelectElementOption, SelectElementOptionOrOptgroup};
use euclid::{Point2D, Rect, Size2D}; use euclid::{Point2D, Rect, Size2D};
use html5ever::{LocalName, Prefix, local_name}; use html5ever::{LocalName, Prefix, QualName, local_name, ns};
use js::rust::HandleObject; use js::rust::HandleObject;
use style::attr::AttrValue; use style::attr::AttrValue;
use stylo_dom::ElementState; use stylo_dom::ElementState;
@ -37,11 +37,10 @@ use crate::dom::bindings::root::{Dom, DomRoot, MutNullableDom};
use crate::dom::bindings::str::DOMString; use crate::dom::bindings::str::DOMString;
use crate::dom::characterdata::CharacterData; use crate::dom::characterdata::CharacterData;
use crate::dom::document::Document; use crate::dom::document::Document;
use crate::dom::element::{AttributeMutation, Element}; use crate::dom::element::{AttributeMutation, CustomElementCreationMode, Element, ElementCreator};
use crate::dom::event::Event; use crate::dom::event::Event;
use crate::dom::eventtarget::EventTarget; use crate::dom::eventtarget::EventTarget;
use crate::dom::html::htmlcollection::CollectionFilter; use crate::dom::html::htmlcollection::CollectionFilter;
use crate::dom::html::htmldivelement::HTMLDivElement;
use crate::dom::html::htmlelement::HTMLElement; use crate::dom::html::htmlelement::HTMLElement;
use crate::dom::html::htmlfieldsetelement::HTMLFieldSetElement; use crate::dom::html::htmlfieldsetelement::HTMLFieldSetElement;
use crate::dom::html::htmlformelement::{FormControl, FormDatum, FormDatumValue, HTMLFormElement}; use crate::dom::html::htmlformelement::{FormControl, FormDatum, FormDatumValue, HTMLFormElement};
@ -257,15 +256,27 @@ impl HTMLSelectElement {
let document = self.owner_document(); let document = self.owner_document();
let root = self.upcast::<Element>().attach_ua_shadow_root(true, can_gc); let root = self.upcast::<Element>().attach_ua_shadow_root(true, can_gc);
let select_box = HTMLDivElement::new(local_name!("div"), None, &document, None, can_gc); let select_box = Element::create(
select_box.upcast::<Element>().set_string_attribute( QualName::new(None, ns!(html), local_name!("div")),
&local_name!("style"), None,
SELECT_BOX_STYLE.into(), &document,
ElementCreator::ScriptCreated,
CustomElementCreationMode::Asynchronous,
None,
can_gc, can_gc,
); );
select_box.set_string_attribute(&local_name!("style"), SELECT_BOX_STYLE.into(), can_gc);
let text_container = HTMLDivElement::new(local_name!("div"), None, &document, None, can_gc); let text_container = Element::create(
text_container.upcast::<Element>().set_string_attribute( QualName::new(None, ns!(html), local_name!("div")),
None,
&document,
ElementCreator::ScriptCreated,
CustomElementCreationMode::Asynchronous,
None,
can_gc,
);
text_container.set_string_attribute(
&local_name!("style"), &local_name!("style"),
TEXT_CONTAINER_STYLE.into(), TEXT_CONTAINER_STYLE.into(),
can_gc, can_gc,
@ -284,9 +295,16 @@ impl HTMLSelectElement {
.AppendChild(text.upcast::<Node>(), can_gc) .AppendChild(text.upcast::<Node>(), can_gc)
.unwrap(); .unwrap();
let chevron_container = let chevron_container = Element::create(
HTMLDivElement::new(local_name!("div"), None, &document, None, can_gc); QualName::new(None, ns!(html), local_name!("div")),
chevron_container.upcast::<Element>().set_string_attribute( None,
&document,
ElementCreator::ScriptCreated,
CustomElementCreationMode::Asynchronous,
None,
can_gc,
);
chevron_container.set_string_attribute(
&local_name!("style"), &local_name!("style"),
CHEVRON_CONTAINER_STYLE.into(), CHEVRON_CONTAINER_STYLE.into(),
can_gc, can_gc,