Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-30 02:30:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #21050 - jonathanKingston:fix-replacability-of-window-attrs, r=jdm

Browse source 
Allow supported window attributes to be replacable.

As seen in https://github.com/servo/servo/pull/21045 some Window attributes don't support JavaScript from being able to shadow and replace their values.

This PR adds all other attributes I could find that are supported by servo to be replaceable.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21050)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-06-19 18:11:06 -04:00 • committed by GitHub
commit e231a68acf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/wpt/metadata/css/cssom-view/window-interface.xht.ini Normal file
View file

@ -0,0 +1,4 @@
[window-interface.xht]
[window_properties_readonly]
expected: FAIL

36
tests/wpt/metadata/html/browsers/the-window-object/window-properties.https.html.ini
View file

@ -53,39 +53,3 @@
[Window replaceable attribute: external]
expected: FAIL
[Window replaceable attribute: screen]
expected: FAIL
[Window replaceable attribute: scrollX]
expected: FAIL
[Window replaceable attribute: scrollY]
expected: FAIL
[Window replaceable attribute: pageXOffset]
expected: FAIL
[Window replaceable attribute: pageYOffset]
expected: FAIL
[Window replaceable attribute: innerWidth]
expected: FAIL
[Window replaceable attribute: innerHeight]
expected: FAIL
[Window replaceable attribute: screenX]
expected: FAIL
[Window replaceable attribute: screenY]
expected: FAIL
[Window replaceable attribute: outerWidth]
expected: FAIL
[Window replaceable attribute: outerHeight]
expected: FAIL
[Window replaceable attribute: devicePixelRatio]
expected: FAIL