From e2424fcec7511b683a06fbf624d06c63570560dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20W=C3=BClker?= Date: Sun, 18 May 2025 19:42:21 +0200 Subject: [PATCH] Remove the `dom_shadowdom_enabled` preference (#37043) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The preference was enabled by default in early march 2025, but was kept around in case something major breaks (https://github.com/servo/servo/pull/35899#discussion_r1988222297). In the time since, no major bugs have been reported: * https://github.com/servo/servo/issues/36722 is a bug in the UA shadow tree, not the shadow dom itself. It's also independent of the preference. * https://github.com/servo/servo/issues/36273 looks like it *might* be related to the shadow DOM, but it also requires experimental features so it might be caused by something else entirely. Signed-off-by: Simon Wülker --- components/config/prefs.rs | 2 -- components/script_bindings/webidls/Element.webidl | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/components/config/prefs.rs b/components/config/prefs.rs index a9ec112e3eb..64dd9659e56 100644 --- a/components/config/prefs.rs +++ b/components/config/prefs.rs @@ -99,7 +99,6 @@ pub struct Preferences { pub dom_serviceworker_timeout_seconds: i64, pub dom_servo_helpers_enabled: bool, pub dom_servoparser_async_html_tokenizer_enabled: bool, - pub dom_shadowdom_enabled: bool, pub dom_svg_enabled: bool, pub dom_testable_crash_enabled: bool, pub dom_testbinding_enabled: bool, @@ -277,7 +276,6 @@ impl Preferences { dom_serviceworker_timeout_seconds: 60, dom_servo_helpers_enabled: false, dom_servoparser_async_html_tokenizer_enabled: false, - dom_shadowdom_enabled: true, dom_svg_enabled: false, dom_testable_crash_enabled: false, dom_testbinding_enabled: false, diff --git a/components/script_bindings/webidls/Element.webidl b/components/script_bindings/webidls/Element.webidl index 42733b91929..4545b18d058 100644 --- a/components/script_bindings/webidls/Element.webidl +++ b/components/script_bindings/webidls/Element.webidl @@ -84,7 +84,7 @@ interface Element : Node { [CEReactions, Throws] undefined insertAdjacentHTML(DOMString position, (TrustedHTML or DOMString) string); - [Throws, Pref="dom_shadowdom_enabled"] ShadowRoot attachShadow(ShadowRootInit init); + [Throws] ShadowRoot attachShadow(ShadowRootInit init); readonly attribute ShadowRoot? shadowRoot; };