Expose BeforeUnloadEvent only in Window

This commit is contained in:
Anthony Ramine 2017-01-21 01:10:38 +01:00
parent 1b68f79468
commit e3980e6235
4 changed files with 7 additions and 7 deletions

View file

@ -13,7 +13,7 @@ use dom::bindings::js::Root;
use dom::bindings::reflector::reflect_dom_object; use dom::bindings::reflector::reflect_dom_object;
use dom::bindings::str::DOMString; use dom::bindings::str::DOMString;
use dom::event::{Event, EventBubbles, EventCancelable}; use dom::event::{Event, EventBubbles, EventCancelable};
use dom::globalscope::GlobalScope; use dom::window::Window;
use servo_atoms::Atom; use servo_atoms::Atom;
// https://html.spec.whatwg.org/multipage/#beforeunloadevent // https://html.spec.whatwg.org/multipage/#beforeunloadevent
@ -31,17 +31,17 @@ impl BeforeUnloadEvent {
} }
} }
pub fn new_uninitialized(global: &GlobalScope) -> Root<BeforeUnloadEvent> { pub fn new_uninitialized(window: &Window) -> Root<BeforeUnloadEvent> {
reflect_dom_object(box BeforeUnloadEvent::new_inherited(), reflect_dom_object(box BeforeUnloadEvent::new_inherited(),
global, window,
BeforeUnloadEventBinding::Wrap) BeforeUnloadEventBinding::Wrap)
} }
pub fn new(global: &GlobalScope, pub fn new(window: &Window,
type_: Atom, type_: Atom,
bubbles: EventBubbles, bubbles: EventBubbles,
cancelable: EventCancelable) -> Root<BeforeUnloadEvent> { cancelable: EventCancelable) -> Root<BeforeUnloadEvent> {
let ev = BeforeUnloadEvent::new_uninitialized(global); let ev = BeforeUnloadEvent::new_uninitialized(window);
{ {
let event = ev.upcast::<Event>(); let event = ev.upcast::<Event>();
event.init_event(type_, bool::from(bubbles), event.init_event(type_, bool::from(bubbles),

View file

@ -6,7 +6,7 @@
* https://html.spec.whatwg.org/multipage/#beforeunloadevent * https://html.spec.whatwg.org/multipage/#beforeunloadevent
*/ */
[Exposed=(Window,Worker)] [Exposed=Window]
interface BeforeUnloadEvent : Event { interface BeforeUnloadEvent : Event {
attribute DOMString returnValue; attribute DOMString returnValue;
}; };

View file

@ -7,7 +7,6 @@ importScripts("interfaces.js");
// IMPORTANT: Do not change the list below without review from a DOM peer! // IMPORTANT: Do not change the list below without review from a DOM peer!
test_interfaces([ test_interfaces([
"BeforeUnloadEvent",
"Blob", "Blob",
"CloseEvent", "CloseEvent",
"CSSStyleDeclaration", "CSSStyleDeclaration",

View file

@ -16,6 +16,7 @@ var unexpected = [
"DrawingStyle", "DrawingStyle",
"CanvasGradient", "CanvasGradient",
"CanvasPattern", "CanvasPattern",
"BeforeUnloadEvent",
"PopStateEvent", "PopStateEvent",
"HashChangeEvent", "HashChangeEvent",
"PageTransitionEvent", "PageTransitionEvent",