Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-30 17:48:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25575 - pshaughn:celoop, r=jdm

Browse source 
Prevent infinite recursion when upgrading custom elements

<!-- Please describe your changes on the following line: -->
The spec and tests were out of sync when I implemented #25410 and I mentioned I'd have an extra detail to attend to if whatwg/html#5126 landed; it did, and I did, and a couple test cases pass.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix two WPT test cases, see test metadata in commit

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-01-26 06:07:08 -05:00 • committed by GitHub
commit e3a9063412
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/wpt/metadata/custom-elements/upgrading.html.ini
View file

@ -4,10 +4,3 @@
[If definition's disable shadow is true and element's shadow root is non-null, then throw a "NotSupportedError" DOMException.]
expected: FAIL
[Infinite constructor recursion with upgrade(this) should not be possible]
expected: FAIL
[Infinite constructor recursion with appendChild should not be possible]
expected: FAIL