From e5878b96a9edb134b7b0771fd8cdc24e7f17c8a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Mon, 23 Apr 2018 18:46:10 +0200 Subject: [PATCH] style: Remove Valgrind workaround to make ::slotted use the rule hash. Bug: 1426516 Reviewed-by: emilio MozReview-Commit-ID: 2q14kHjajIr --- components/style/selector_map.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/components/style/selector_map.rs b/components/style/selector_map.rs index 68f025b3e64..3b9b6f20184 100644 --- a/components/style/selector_map.rs +++ b/components/style/selector_map.rs @@ -454,13 +454,7 @@ fn specific_bucket_for<'a>(component: &'a Component) -> Bucket<'a> // // So inserting `span` in the rule hash makes sense since we want to // match the slotted . - // - // FIXME(emilio, bug 1426516): The line below causes valgrind failures - // and it's probably a false positive, we should uncomment whenever - // jseward is back to confirm / whitelist it. - // - // Meanwhile taking the code path below is slower, but still correct. - // Component::Slotted(ref selector) => find_bucket(selector.iter()), + Component::Slotted(ref selector) => find_bucket(selector.iter()), Component::Host(Some(ref selector)) => find_bucket(selector.iter()), _ => Bucket::Universal, }