From e5ae267e80a4b4d878254c5fa432358e019a343c Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Thu, 1 Jan 2015 17:34:46 +0100 Subject: [PATCH] Remove unsound Root::deref() call in Document::get_html_element. --- components/script/dom/document.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs index 0bf8070fe80..747e88eb067 100644 --- a/components/script/dom/document.rs +++ b/components/script/dom/document.rs @@ -24,7 +24,7 @@ use dom::bindings::error::Error::{NotSupported, InvalidCharacter}; use dom::bindings::error::Error::{HierarchyRequest, NamespaceError}; use dom::bindings::global::GlobalRef; use dom::bindings::js::{MutNullableJS, JS, JSRef, Temporary, OptionalSettable, TemporaryPushable}; -use dom::bindings::js::OptionalRootable; +use dom::bindings::js::{OptionalRootable, RootedReference}; use dom::bindings::utils::reflect_dom_object; use dom::bindings::utils::xml_name_type; use dom::bindings::utils::XMLName::{QName, Name, InvalidXMLName}; @@ -491,9 +491,11 @@ impl<'a> PrivateDocumentHelpers for JSRef<'a, Document> { } fn get_html_element(self) -> Option> { - self.GetDocumentElement().root().and_then(|element| { - HTMLHtmlElementCast::to_ref(*element) - }).map(Temporary::from_rooted) + self.GetDocumentElement() + .root() + .r() + .and_then(HTMLHtmlElementCast::to_ref) + .map(Temporary::from_rooted) } }