Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Replace CanGc::note() calls with arguments in components/script (#33816)

Browse source 
* Replace CanGc::note() calls with arguments in components/script

Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>

* Revert changes for task macro

Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>

---------

Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
This commit is contained in:
tanishka 2024-10-12 00:53:58 +05:30 • committed by GitHub
parent a86dcfc6e7
commit e5e1ef9fb6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/window.rs
View file

@ -1342,7 +1342,7 @@ impl WindowMethods for Window {
init: RootedTraceableBox<RequestInit>,
comp: InRealm,
) -> Rc<Promise> {
fetch::Fetch(self.upcast(), input, init, comp)
fetch::Fetch(self.upcast(), input, init, comp, CanGc::note())
}
fn TestRunner(&self) -> DomRoot<TestRunner> {

4
components/script/dom/workerglobalscope.rs
View file

@ -55,7 +55,7 @@ use crate::dom::workernavigator::WorkerNavigator;
use crate::fetch;
use crate::realms::{enter_realm, InRealm};
use crate::script_runtime::{
get_reports, CommonScriptMsg, JSContext, Runtime, ScriptChan, ScriptPort,
get_reports, CanGc, CommonScriptMsg, JSContext, Runtime, ScriptChan, ScriptPort,
};
use crate::task::TaskCanceller;
use crate::task_source::dom_manipulation::DOMManipulationTaskSource;
@ -406,7 +406,7 @@ impl WorkerGlobalScopeMethods for WorkerGlobalScope {
init: RootedTraceableBox<RequestInit>,
comp: InRealm,
) -> Rc<Promise> {
fetch::Fetch(self.upcast(), input, init, comp)
fetch::Fetch(self.upcast(), input, init, comp, CanGc::note())
}
// https://w3c.github.io/hr-time/#the-performance-attribute

3
components/script/fetch.rs
View file

@ -145,6 +145,7 @@ pub fn Fetch(
input: RequestInfo,
init: RootedTraceableBox<RequestInit>,
comp: InRealm,
can_gc: CanGc,
) -> Rc<Promise> {
let core_resource_thread = global.core_resource_thread();
@ -158,7 +159,7 @@ pub fn Fetch(
// Step 2. Let requestObject be the result of invoking the initial value of Request as constructor
// with input and init as arguments. If this throws an exception, reject p with it and return p.
let request = match Request::Constructor(global, None, CanGc::note(), input, init) {
let request = match Request::Constructor(global, None, can_gc, input, init) {
Err(e) => {
response.error_stream(e.clone());
promise.reject_error(e);