mirror of
https://github.com/servo/servo.git
synced 2025-08-02 04:00:32 +01:00
Auto merge of #18617 - TheDan64:master, r=KiChjang
Removed integrity check and test for no-cors requests Removed Step 30.2 which raised a JS TypeError if the integrity metadata was not empty. I manually ran `new Request("", {"mode" : "no-cors", "integrity" : "not an empty string"});` in servo to validate that the exception no longer arose. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #18345 - [x] These changes do not require tests because according to the ticket "Unfortunately, there's no automated test available for this yet because we are having trouble updating our copy of the upstream tests. " <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18617) <!-- Reviewable:end -->
This commit is contained in:
commit
e6099b4364
3 changed files with 1 additions and 11 deletions
|
@ -324,10 +324,6 @@ impl Request {
|
|||
"The mode is 'no-cors' but the method is not a cors-safelisted method".to_string()));
|
||||
}
|
||||
// Step 30.2
|
||||
if !borrowed_request.integrity_metadata.is_empty() {
|
||||
return Err(Error::Type("Integrity metadata is not an empty string".to_string()));
|
||||
}
|
||||
// Step 30.3
|
||||
r.Headers().set_guard(Guard::RequestNoCors);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue