Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-28 11:03:39 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #24197 - Manishearth:vs-crt, r=jdm

Browse source 
Pull in CRT runtime on VS 2019 as well

Building for x64 UWP leads to the build system complaining about this DLL not being in the target/ folder.

I think these three VS versions are the only ones we support, perhaps we should remove this check entirely and unconditionally include this DLL?

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24197)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2019-09-12 16:57:18 -04:00 • committed by GitHub
commit e6376ab322
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
python/servo/build_commands.py
View file

@ -951,7 +951,7 @@ def package_msvc_dlls(servo_exe_dir, target, vcinstalldir, vs_version):
"msvcp140.dll",
"vcruntime140.dll",
]
if target_arch != "aarch64" and vs_version in ("14.0", "15.0"):
if target_arch != "aarch64" and vs_version in ("14.0", "15.0", "16.0"):
msvc_deps += ["api-ms-win-crt-runtime-l1-1-0.dll"]
# Check if it's Visual C++ Build Tools or Visual Studio 2015