Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 05:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't move the data when extracting the bytes in XMLHttpRequest::Send.

Browse source 
The data is used later to set the Content-Type header. Current rustc
(4d2af3861) does not detect this use-after-move, but treats the later use as
if the data was None. It will, however, detect the bug in d2b30f7d3, which we
are upgrading to.
This commit is contained in:
Ms2ger 2014-09-29 17:52:41 +02:00
parent 760f28b551
commit e72b5613ee
4 changed files with 1 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/xmlhttprequest.rs
View file

@ -450,7 +450,7 @@ impl<'a> XMLHttpRequestMethods for JSRef<'a, XMLHttpRequest> {
Get | Head => None, // Step 3 Get | Head => None, // Step 3
_ => data _ => data
}; };
let extracted = data.map(|d| d.extract()); let extracted = data.as_ref().map(|d| d.extract());
self.request_body_len.set(extracted.as_ref().map(|e| e.len()).unwrap_or(0)); self.request_body_len.set(extracted.as_ref().map(|e| e.len()).unwrap_or(0));
// Step 6 // Step 6

3
tests/wpt/metadata/XMLHttpRequest/formdata.htm.ini
View file

@ -1,8 +1,5 @@
[formdata.htm] [formdata.htm]
type: testharness type: testharness
[empty formdata]
expected: FAIL
[formdata with string] [formdata with string]
expected: FAIL expected: FAIL

3
tests/wpt/metadata/XMLHttpRequest/send-content-type-charset.htm.ini
View file

@ -15,6 +15,3 @@
[XMLHttpRequest: send() - charset parameter of Content-Type 6] [XMLHttpRequest: send() - charset parameter of Content-Type 6]
expected: FAIL expected: FAIL
[XMLHttpRequest: send() - charset parameter of Content-Type 7]
expected: FAIL

5
tests/wpt/metadata/XMLHttpRequest/send-content-type-string.htm.ini
View file

@ -1,5 +0,0 @@
[send-content-type-string.htm]
type: testharness
[XMLHttpRequest: send() - Content-Type]
expected: FAIL